Commit Graph

7715 Commits

Author SHA1 Message Date
Guy Brand 4f50e20a51 Hotfix release 2014-09-29c "Hrun" 2015-02-24 21:01:05 +01:00
Andreas Gohr 4970ad24ce check permissions in ACL plugin's RPC API component. #1056
Security Fix

Severity: Medium
Type:     Remote Priviledge Escalation
Remote:   yes

Vulnerability Details:

This fixes a security hole in the ACL plugins remote API component. The
plugin failed to check for superuser permissions before executing ACL
addition or deletion. This means everybody with permissions to call the
XMLRPC API also had permissions to set up their own ACL rules and thus
circumventing any existing rules.

Risk Assessment:

The XMLRPC API in DokuWiki is marked experimental and off by default. It
also implements an additional safeguard by giving access to a configured
circle of users and groups only. So only a minor number of DokuWiki
installations will be affected at all.
For affected installations the risk is high if users with access to the
API are not to be trusted.
Thus the overall severity of medium.

Resolution:

Installations applying this commit are safe. A hotfix is about to be
released. Meanwhile users are advised to disable the XMLRPC API in the
config manager.
2015-02-24 20:58:47 +01:00
Guy Brand 639b58cb1e Hotfix Release 2014-09-29b "Hrun" 2014-12-03 15:44:54 +01:00
Andreas Gohr 778ddf6f2c disable flash uploading by default
Thanks to Kacper Szurek for reporting this
2014-12-03 15:43:36 +01:00
Guy Brand 32e7ff2a83 Hotfix Release 2014-09-29a "Hrun" 2014-10-08 09:59:23 +02:00
Guy Brand f256c70f22 Merge branch 'master' into stable 2014-10-08 09:56:58 +02:00
Guy Brand 7172294d0c Release preparation 2014-10-08 09:56:30 +02:00
Christopher Smith 1d27290af0 Merge pull request #886 from splitbrain/chris_pcre66_bug
Fix for issues #877 & #885 related to a bug in PCRE 6.6
2014-10-07 15:51:12 +01:00
Andreas Gohr 60aca4b904 do not use Accept-Encoding in browser UID
Since Chrome 37, they send differen accept encodings for POST and GET
requests which will break BrowserUID checks as reported in
cosmocode/dokuwiki-plugin-oauth/issues/3

See https://code.google.com/p/chromium/issues/detail?id=410559 for
official bug report at Google
2014-10-06 14:59:03 +02:00
Christopher Smith 8ab9b36bd8 Merge pull request #887 from hanche/fix-lang-no
Fix broken format string
2014-10-06 12:44:09 +01:00
Harald Hanche-Olsen 19a24e5859 Fix brokan format string 2014-10-05 18:38:53 +02:00
Christopher Smith 9d846ff4e2 escaping backslash should be included in split items 2014-10-04 11:59:42 +01:00
Christopher Smith 6c8c1f4632 Fix for issues 877 & 885 related to a bug in PCRE 6.6 2014-10-03 17:41:14 +01:00
Andreas Gohr fe2e516621 Release 2014-09-29 "Hrun" 2014-09-29 20:20:01 +02:00
Andreas Gohr 6c1ae99615 Merge branch 'master' into stable
* master: (214 commits)
  release preparations
  postgresql auth plugin: correct function name
  parse AT parameter: first strtotime then timestamp remove config option
  move more strings to lang.php
  move strings to lang.php
  add placeholders for create page text
  phpdocs parserutils
  improve some scrutinizer issues
  visibility plugin methods
  use config cascade for loading of localizations
  reformatting config cascade
  add lang files to cascading
  work around missing gzopen on certain systems #865
  translation update
  fix scrutinizer issues
  fixed typos in docblock comments
  do not allow empty passwords
  clean user credentials from control chars
  added filter method to INPUT class
  translation update
  ...
2014-09-29 20:17:39 +02:00
Andreas Gohr 57271d078b release preparations 2014-09-29 20:15:27 +02:00
Andreas Gohr 85674a734d Merge pull request #708 from splitbrain/overridablelangstrings
extend lang file cascade, so users can override some lang strings
2014-09-29 18:34:02 +02:00
Andreas Gohr 17553fca19 Merge pull request #624 from lisps/revisions
date_at support
2014-09-29 18:29:20 +02:00
Andreas Gohr 2f981761b3 Merge pull request #563 from splitbrain/FS#2697searchpagereadonly
Update text above searchresults, when only read-acl FS#2697
2014-09-29 18:27:54 +02:00
Andreas Gohr a8a1824893 Merge branch 'bug865'
* bug865:
  work around missing gzopen on certain systems #865
2014-09-29 18:15:42 +02:00
Christopher Smith 07a1dd10b8 postgresql auth plugin: correct function name 2014-09-29 14:10:08 +01:00
lisps 80d9f3ddb3 parse AT parameter: first strtotime then timestamp
remove config option
2014-09-29 10:13:57 +02:00
Gerrit Uitslag c50a128d96 move more strings to lang.php 2014-09-28 21:53:59 +02:00
Gerrit Uitslag a55c49a274 move strings to lang.php 2014-09-28 21:44:06 +02:00
Gerrit Uitslag 82f2bcd02b add placeholders for create page text 2014-09-28 15:45:53 +02:00
Gerrit Uitslag 0c1b02bead Merge remote-tracking branch 'origin/master' into FS#2697searchpagereadonly
Conflicts:
	inc/lang/hr/searchpage.txt
	inc/lang/ko/searchpage.txt
2014-09-28 15:36:21 +02:00
Gerrit Uitslag 0440ca46b6 phpdocs parserutils 2014-09-28 15:07:17 +02:00
Gerrit Uitslag 21d806cd54 improve some scrutinizer issues
different types
unused vars
PHPDocs
2014-09-28 14:44:17 +02:00
Gerrit Uitslag b79379f2e5 Merge remote-tracking branch 'origin/master' into overridablelangstrings
Conflicts:
	inc/plugin.php
2014-09-28 13:46:04 +02:00
Gerrit Uitslag 73411587cb visibility plugin methods 2014-09-28 13:40:54 +02:00
Gerrit Uitslag dd7a6159c4 use config cascade for loading of localizations 2014-09-28 13:27:05 +02:00
Gerrit Uitslag 89417bb7bf reformatting config cascade 2014-09-27 23:41:56 +02:00
Gerrit Uitslag 64d489db28 add lang files to cascading 2014-09-27 23:35:44 +02:00
Andreas Gohr 92b9f19672 work around missing gzopen on certain systems #865 2014-09-27 13:47:48 +02:00
Andreas Gohr da9572711f Merge pull request #826 from splitbrain/external-video-audio
Added support for external video and audio files
2014-09-27 13:10:55 +02:00
Andreas Gohr 3c7cda8a8c Merge pull request #869 from splitbrain/filter
added filter method to INPUT class
2014-09-27 12:40:03 +02:00
Andreas Gohr 3df1d4a6fe Merge pull request #868 from splitbrain/authclean
clean user credentials from control chars
2014-09-27 12:39:46 +02:00
Andreas Gohr b24ed43ebb Merge pull request #828 from ssahara/extension-make_info
Last Update Date info of extension fix
2014-09-27 12:33:04 +02:00
Andreas Gohr e037e42835 Merge pull request #870 from dokuwiki-translate/lang_update_46
Translation update (zh)
2014-09-27 12:07:30 +02:00
Yuwei Sun 73b19ad115 translation update 2014-09-26 22:36:12 +02:00
lisps 1d053a561d fix scrutinizer issues 2014-09-26 13:02:24 +02:00
lisps 8d39e80d36 Merge remote-tracking branch master into revisions 2014-09-26 12:48:02 +02:00
Andreas Gohr 7b950f2d59 Merge remote-tracking branch 'origin/auth_getUserData_improvements'
* origin/auth_getUserData_improvements:
  KISS - remove class constants for REQUIRE_GROUPS & IGNORE_GROUPS and replace with boolean values
  use $requireGroups constants in auth classes; comments; code improvements
  fix comment errors, sp. & grammar
  code styling - add missing braces
  Allow user info to be retrieved without groups
  Restore correct public interface of getUserData() for authldap plugin

Conflicts:
	inc/common.php
2014-09-26 11:31:13 +02:00
Andreas Gohr 9d209ab877 Merge pull request #821 from splitbrain/searchns
improve qsearch suggestions
2014-09-26 11:13:07 +02:00
Andreas Gohr c3c7c422c0 Merge pull request #799 from enricotagliavini/master
Adding X-Forwarded-Proto support
2014-09-26 11:11:44 +02:00
Andreas Gohr 1dc0e65fa0 fixed typos in docblock comments 2014-09-26 11:04:32 +02:00
Andreas Gohr cdb157d1be Merge remote-tracking branch 'origin/pr/814'
* origin/pr/814:
  translation update

Conflicts:
	inc/lang/ta/lang.php
2014-09-26 10:58:46 +02:00
Andreas Gohr 310f25af41 Merge pull request #822 from jurrehart/Issue#637
Added @ALL handeling in auth_isMember
2014-09-26 10:51:41 +02:00
Andreas Gohr 5e9e105404 do not allow empty passwords
When a username but no password is submitted, the login is denied right
away instead of relying on the backend to refuse the login.
2014-09-26 10:36:05 +02:00
Andreas Gohr 395c2f0ff3 clean user credentials from control chars
This is to prevent zero byte attacks on external auth systems as
described in
http://www.freelists.org/post/dokuwiki/Fwd-Dokuwiki-maybe-security-issue-Null-byte-poisoning-in-LDAP-authentication
2014-09-23 20:17:49 +02:00