Some info which is used for extension management (e.g. installed date, latest
version) is not being forced to pull from single source by those getters.
This closes#2965.
Nowadays it is not necessary to specify "type" or "charset" attribute at <script> tag:
1. "type" attribute defaults to "application/javascript", so there is no need to specify that. The recent value "text/javascript" is obsolete in favor of the default "application/javascript", as stated e.g. here: https://www.iana.org/assignments/media-types/media-types.xhtml#text
2. "charset" attribute of the <script> tag defaults to encoding be the same as the encoding of the script element's node document. As DokuWiki's default encoding is "utf-8", there is no need to specify this encoding in external resources. See: https://html.spec.whatwg.org/multipage/scripting.html#the-script-element
Manual merging, closes#2921.
Co-Authored-By: petrkajzar <58340153+petrkajzar@users.noreply.github.com>
Fixes#1892. This will be triggered by:
- PHP 7+: "If an appropriate source of randomness cannot be found, an Exception will be thrown"
- paragonie/random_compat: PHP 5.6 support will fail if urandom is not readable
Fixes#1716. Before it will only set min-height based on aside height.
I added a current height check before applying min-height, because there might be a min-height CSS on .page in stylesheet, and I want to respect that and only apply if necessery.
Splitting them out allows for plugins to use _test/phpcs.xml as the
basis for their own linting without having an overly permissive coding
standard.
Also, this makes it more obvious and painful that these are just
intended as temporary exceptions and should be actually fixed.
The rule `Generic.ControlStructures.InlineControlStructure.NotAllowed`
has its comment adjust to make it clear that this is an intended
deviation from the PSR-2/PSR-12 coding standard.
The rule `PSR1.Classes.ClassDeclaration.MissingNamespace` has to remain
in the DokuWiki coding standard as the plugin base classes can currently
not reasonably be in namespaces.
The $conf['fperm'] value was checked in multiple files using different methods.
This can cause permission trouble with restricted environments, i.e. when chmod is forbidden and file permissions are non-default.
Now, all checks use implicit cast to boolean which leads to consistent behaviour.
Also, a misleading variable was renamed in context to better understand one of the checks.
Phy