In lantis, we have a power LED and two battery LEDs. Also, we have two
USB-C ports, and which battery LED takes action related to different
charging states will depend on which USB-C port has been plugged in for
power charge. We blink power LED to indicate system suspend, and we also
override battery LEDs for clamshell SKU, which doesn't have power LED.
BUG=b:171546871
BRANCH=dedede
TEST=Make sure that all LEDs act correctly.
Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
Change-Id: I32e931efad9477f64e83e75057b3ae04db997e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2556726
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
These sleep lines were never used in code and have since been removed
from the reference schematic, but they are driven on nocturne.
This means that it would be bad if thee lines were ever accidentally
repurposed in the future.
Confirmed on A70 PVT/MP schematic.
TEST=make BOARD=dartmonkey
BUG=b:175115925
Change-Id: I3d1e3bbee5d242026a37464f6f0154243e262972
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2579463
Tested-by: Craig Hesling <hesling@chromium.org>
Auto-Submit: Craig Hesling <hesling@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org>
Configure additional unused signals to save power on S0ix. Savings are
about 200 uW.
EC power consumption, averaged over 60 minutes:
Before changes: Avg 5.07 mW, max 13.61 mW, min 3.68 mW
With changes: Avg 4.84 mW, max 7.14 mW, min 3.54 mW
BUG=b:155882590
BRANCH=none
TEST=make buildall
TEST=Use Volteer reworked with sweetberry and measure power.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I9f01b04b0c363a31a8c6f703666d65f00c79ad8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2578932
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
This change allows the `accelspoof` ec command to also
override the calibration data (bypassing the calibration
module). This config flag should be used when testing
layers above the EC (kernel and up)'s handling of the
calibration values.
BRANCH=none
BUG=none
TEST=Built on eve and added unit tests.
TEST=make run-online_calibration_spoof -j
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I4735b9613c152af5559661a91565b05635d6495e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2494986
Create the initial EC image for the storo variant by copying the
waddledee reference board EC files into a new directory named for
the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.3.0).
BUG=b:174284884
BRANCH=None
TEST=make BOARD=storo
Signed-off-by: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Change-Id: If1648599689e6da5985248ffa095b298ef221142
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567079
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: Wentao Qin <qinwentao@huaqin.corp-partner.google.com>
Commit-Queue: Henry Sun <henrysun@google.com>
CL:2321874 moves sleep_set_notify() and sleep_notify_transition()
under CONFIG_POWER_SLEEP_FAILURE_DETECTION ifdef and introduces their
no-op counterparts if CONFIG_POWER_SLEEP_FAILURE_DETECTION is not
defined. Before that CL aforementioned functions were outside ifdef.
Commit message also mentions that CL is only moving code, not performing
any logical changes.
Therefore this CL is moving sleep_set_notify() and sleep_notify_transition()
outside ifdef and removes their no-on counterparts to eliminate logical
changes introduced in CL:2321874
Issue was found when running EC ToT on octopus (casta). When AP was
going to S0ix EC reported that fact, but PD was not changing DRP
state to 'toggle off'.
BUG=b:162083524, b:161775827
BRANCH=none
TEST=Compile and flash firmware on octopus (tested on casta).
Go to ChromeOS Developer Console and issue 'powerd_dbus_suspend'
Check EC console if PD stack is reporting state transition and make
sure that DRP is set to 'toggling off'
Signed-off-by: Patryk Duda <pdk@semihalf.com>
Change-Id: I6ba4187c8549ee6d9e3b19543d67c49520927cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2575064
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Replace them with charger_get_input_current_limit which is
aligned to the old usage, no funcional changes.
Keep OCPC charger_get_input_current uses as was, since it
is its intended use.
Also, implement
- isl923x_get_input_current, raa48900_get_input_current
- sm5803_get_input_current_limit
BUG=b:171853295
TEST=1. grep "\<charger_get_input_current\>"; only ocpc uses the function.
2. make buildall
3. test with CL:2569086 on waddledee(sm5803), waddledoo(raa489000),
hayato(isl923x), pompom(isl923x), and ensure the output
of `curr 0|1` equalts to the report of power meter.
BRANCH=none
Change-Id: I71aca33cbc88dda9b0238cb71b1609665a9c9a7f
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569085
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
A pre-processing CL for the later CL which migrate API from
charger_get_input_current.
BUG=b:171853295
TEST=make buildall
BRANCH=none
Change-Id: Ia15ce47ac5d068b7125c58115e368f9dfa87958c
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569084
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
charger_set_input_current was actually sets the input current limit,
so renames it to charger_set_input_current_limit.
BUG=b:171853295
TEST=make buildall
TEST=not output from `grep -r "\<charger_set_input_current\>"`
BRANCH=none
Change-Id: Icf4e99f287a7d4fc2d9560e8502e46cc07bfc085
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569083
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
To be able to send data to the host, the oversampling ratio must be
non-zero. It implies:
- the host send a set frequency request for the RGB sensor
- the EC use the frequency from the clear sensor to calculate the
RGB sensor oversampling ratio
BUG=b:172343923
BRANCH=kukui,hatch,volteer
TEST=On Volteer, in calibration mode, check we get samples from the RGB
sensor.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I70eb62287cae983800cdadaee4cfe00b2f22b734
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2570825
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
When in calibration mode, send data periodically, even when
measurement is identical to the previous one.
BUG=b:172343923
TEST=On Volteer, check data is coming periodically.
BRANCH=kukui,hatch,volteer
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I31da6edcf5d175812697b99b7e7ef6ec85497770
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2570824
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Fix the battery charging status for gauge bq27542.
BUG=b:174725434
BRANCH=master
TEST=1.make -j BOARD=kakadu
2.verified the battery charging status and the result is OK.
Change-Id: Ie3a926dd96b967679d2c51856afc3d1c157835f5
Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2576196
Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
BUG=b:174324375
TEST=insert Apple dongle, and HDMI port works.
BRANCH=kukui
Change-Id: I6ac5c6ce172c6f395a38b0be7dffb4e92f3b9dc4
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2578221
Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Fix the following behavior:
1. Rescue LED from EVT and previous board(board id<3)
2. Change low battery led color according to customer's demand
3. Fixing the issue that when removing AC from right port, left
battery led will blink and go off.
BUG=b:173464588
BRANCH=None
TEST=flash on EVT board and change cbi to verify the LED functions
Signed-off-by: Ko_Ko <Ko_Ko@compal.corp-partner.google.com>
Change-Id: Ie4a855e4d846a05b681e386cb82f702eea8c4e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2577152
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Ko Ko <ko_ko@compal.corp-partner.google.com>
Tested-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
The SYV682 has a 'soft' overcurrent protection on VCONN which current
limits to ~600mA. If the cause is a short it will eventually hit thermal
shutdown. Instead, we should disable VCONN when we get an OCP event. We
must allow current spikes for at least 1ms, so disable with a deglitch.
BUG=b:170441866,b:172710638
TEST=make buildall
TEST=On Voxel, short VCONN to ground for at least 100ms, then observe
that VCONN is disabled and 'VCONN OC!' is printed in the EC console.
BRANCH=None
Signed-off-by: Eric Herrmann <eherrmann@chromium.org>
Change-Id: I6712543b73072c959597c73cd493f248267a42ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2572237
Reviewed-by: Keith Short <keithshort@chromium.org>
Tested-by: Keith Short <keithshort@chromium.org>
Prior to this change, device policy was inhibited from requesting
partner sink capabilities when entering SNK.Ready out of a power role
swap (because the flag gets cleared while invalidating the old contract
in the PRS process), which prevents Fast Role Swap from being enabled
in most situations- for instance Section E.2 of the USB-PD specification
revision 3.0 version 2.0 states that a PRS is a normal part of
connecting to a hub and the device should request sink caps via device
policy in order to enable FRS.
This change attempts to get sink caps from the port partner in
PE_SNK_Ready, then use them to evaluate support for FRS. By moving
partner capabilities evaluation to PE_SNK_Ready, we also prevent
FRS from being enabled when operating as a source: we don't expect
sinks to send FRS, and this helps avoid detecting (and attempting to
act on) spurious FRS signaling.
BUG=b:146393213
TEST=Morphius connects to a hub supporting FRS as expected and successfully
completes a fast role swap when power is removed from the hub.
BRANCH=zork
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: Icf402b4ded99d35e23b51b168cb7f306c3ac156b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2564978
Reviewed-by: Diana Z <dzigterman@chromium.org>
Waking from PSL hibernate is power-on for EC but not for H1, so
we should not add the 2 second delay for CONFIG_BOARD_RESET_AFTER_POWER_ON
in this case.
BUG=b:173180800
BRANCH=zork
TEST=no 2 second delay on wake from hibernate
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ib0c8f2ca7f197626b20a11e21ace44a5046db18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2576439
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Depend on b/160937185 #32, initial PS8811 registers.
BUG=b:160937185
BRANCH=firmware-volteer-13521.B
TEST=manual
Check register value under s0.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I262858b61050f9ad857f44e703bbd3cfd0e989f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2561904
Reviewed-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
modify LED function to match LED SPEC
BUG=b:174443628
BRANCH=firmware-vloteer-13521.B
TEST=make -j BOARD=lindar
Signed-off-by: amber.chen <amber.chen@lcfc.corp-partner.google.com>
Change-Id: Ie51eaa92aed3c22c5452a132048f95287ea94367
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2566857
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
BUG🅱️150323106,b:169929627
BRANCH:master
TEST:make -b servo_v4p1.
Verify that we are receiving descriptive message for all GL3590
events. E.g. try to access invalid port:
i2cxfer raw 1 0x50 0 0xd0
For the full list of events refer to GL3590 I2C Application Note.
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: Ia34f1deb508bbbaad94d2eb1a279d200958db92e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2563687
Reviewed-by: Brian Nemec <bnemec@chromium.org>
GL3590 is a USB hub with support for out-of-band transactions via I2C.
Set of additional registers allow to disable/enable ports, query port
status (including power-related information), handle over-current events
and others.
This initial driver implements method for reading and writing from/to
GL3590 registers as well as event handler to parse asynchronous messages
from hub.
BUG🅱️150323106,b:169929627
BRANCH:master
TEST:buildall. Functionality can be tested on servo_v4p1 with a
consecutive commit applied.
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: I385ff4790ddc367d07b7e588f4e10aeb83e9f1c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2563686
Reviewed-by: Brian Nemec <bnemec@chromium.org>
Formerly, if a board want to customize the body detection settings, it
need to fill all the settings. This CL makes it just have to fill the
exact settings that we want to customize.
BRANCH=None
BUG=b:123434029
TEST=buildall
Signed-off-by: Ching-Kang Yen <chingkang@chromium.org>
Change-Id: I7554e8f21a446f8d93b2558402690e265e82b58e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569087
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org>
Commit-Queue: Ching-Kang Yen <chingkang@chromium.org>
Tested-by: Ching-Kang Yen <chingkang@chromium.org>
Disable Vivaldi keyboard since Vivaldi currently does not
allow for side volume buttons to be distinguished from
keyboard volume F9/F10 keys. This is necessary so that Chrome
can ignore F9/F10 in tablet mode, but side volume buttons still work.
BUG=b:173147060
BRANCH=master
TEST=make -j BOARD=voxel
TEST=make buildall
TEST=test on voxel, side-buttons work in clamshell/tablet mode
and that F9/F10 only work in clamshell.
Change-Id: I6bcc07ede9e88a82c44642493037eca81936f98f
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573658
Reviewed-by: Keith Short <keithshort@chromium.org>
Base on schematic, change EC chip to npcx7m7fc from npcx7m6fc.
BUG=b:174720060
BRANCH=firmware-volteer-13521.B
TEST=make BOARD=copano
Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Change-Id: Iaf9d52636f6ffc14a9a15d776a3d65a0241a5ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2571135
Reviewed-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
See platform/ec/common/build.mk for reference. The use of
keyboard_scan.c should only be allowed when HAS_TASK_KEYSCAN
is defined. As such, we should always set HAS_TASK_KEYSCAN to
1 if CONFIG_PLATFORM_EC_KEYBOARD is defined. Further,
CROS_EC_TASK_LIST was defined per project and it doesn't need
to be, we can instead define it once for all boards depending
on which tasks are set to 1 in shimmed_tasks.h
Note that shimmed_tasks.h can still be used in tests.
BRANCH=none
BUG=none
TEST=zmake testall
Cq-Depend: chromium:2566421
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: Id0ed49dd49e3c4eb2ac23184cf943c91dcd261eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567560
We have quite a few options already and plan to add more. Sort them to
make it easier to see what is there.
The I2C enum isn't really connected with the basic CONFIG munging done
in config_chip.h so move it to i2c.h instead.
Fix the 'keybaord' typo while we are here.
BRANCH=none
BUG=none
TEST=build and boot on volteer
Change-Id: Id03fe44ff859736f1e2f86231ca1e8d9dc4c50af
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2575198
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
usleep is unstable on asurada, we use udelay instead to prevent from
the pulse width over the spec (1ms).
BUG=b:171172053
TEST=ensure the pulse width is reliable.
BRANCH=none
Change-Id: I8b349b6d09dca3a116e6fc9a2552faa041664674
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539262
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
`apshutdown` sometimes fails to shutdown PMIC, when this happens,
powerstate will bounce between G3 and S5G3 until watchdog kicks in.
To fix this, we should detect PMIC status in S5G3, go back to S5 to
retry shutdown if PMIC is still alive.
BUG=b:174546890
TEST=Run the reproduce steps in b/174546890#comment13,
verify EC enters G3.
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I1f0544e16d818074378f58f1208bd586031a5ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573895
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
The VBAT OVP function is actually protecting the CC lines (if not VCONN
SRC), and VBAT (if VCONN SRC).
BUG=none
TEST=none
BRANCH=none
Change-Id: I2eda0d2777d7e0facaf7340afe8e500454fc7169
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573664
Reviewed-by: Ayo Wu <ayowu@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Fix the battery is_present status for gauge bq27542.
BUG=b:174802149
BRANCH=master
TEST=1.make -j BOARD=kakadu
2.verified the battery present status and the result is OK.
Change-Id: Ic8d9d503bc2f7d9648df56c150018f304aacfb18
Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2571145
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Rename local variables and related comments in common i2c_controller
code.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I712217d86f7232f509f1f649b772ec73204ceb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558906
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Inputs have to be guarded with parenthesis.
BUG=none
TEST=make buildall
BRANCH=main
Change-Id: Iedf678e1a2b0f3525aa2b788b0e2c9171d3b4acc
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2570885
Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
The proto boards have an error in which GPIO_BJ_ADP_PRESENT_L never
pulls low due to an error in the board layout. Since it's not possible
to boot genesis with type-C power anyway, just hardcode the connection.
BUG=b:173566595
TEST=Boot to AP
BRANCH=None
Change-Id: I56b4393b5ddce03ac79158c41f66e3463c064b83
Signed-off-by: Matt Ziegelbaum <ziegs@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552227
Reviewed-by: Joe Tessler <jrt@chromium.org>
Genesis is similar to Ambassador, so the starting point for its firmware
is a copy of Ambassador's firmware.
BUG=b:173566595
TEST=None/doesn't boot due to power differences
BRANCH=None
Change-Id: I6de3c9ae83f58c21bf5588817cfde02c7ef1247a
Signed-off-by: Matt Ziegelbaum <ziegs@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552226
Reviewed-by: Joe Tessler <jrt@chromium.org>
This change will make the firmware builder auto-detect new tests.
BRANCH=none
BUG=none
TEST=Ran zephyr's firmware_builder.py
Cq-Depend: chromium:2551964
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I70ba1b32b67e2cb4e3676d228b299294028597a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552848
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
After COIL rename, we need to update the CMakeLists.txt for the i2c test
BRANCH=none
BUG=b:174572350
TEST=builds and passes test
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I33b712876c11dc77e7835c2505749d449e11ffa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2572398
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Jason.Guo