API: rig up tracker { subscription }
This commit is contained in:
parent
78b187bb75
commit
cccc0c0ea6
|
@ -426,7 +426,9 @@ func (r *trackerResolver) Acls(ctx context.Context, obj *model.Tracker, cursor *
|
|||
}
|
||||
|
||||
func (r *trackerResolver) Subscription(ctx context.Context, obj *model.Tracker) (*model.TrackerSubscription, error) {
|
||||
panic(fmt.Errorf("not implemented"))
|
||||
// Regarding unsafe: if they have access to this tracker resource, they
|
||||
// were already authenticated for it.
|
||||
return loaders.ForContext(ctx).SubsByTrackerIDUnsafe.Load(obj.ID)
|
||||
}
|
||||
|
||||
func (r *trackerResolver) ACL(ctx context.Context, obj *model.Tracker) (model.ACL, error) {
|
||||
|
|
|
@ -10,6 +10,7 @@ package loaders
|
|||
//go:generate go run github.com/vektah/dataloaden ParticipantsByIDLoader int git.sr.ht/~sircmpwn/todo.sr.ht/api/graph/model.Entity
|
||||
//go:generate ./gen LabelsByIDLoader int api/graph/model.Label
|
||||
//go:generate ./gen SubsByTicketIDLoader int api/graph/model.TicketSubscription
|
||||
//go:generate ./gen SubsByTrackerIDLoader int api/graph/model.TrackerSubscription
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
@ -43,8 +44,9 @@ type Loaders struct {
|
|||
ParticipantsByID ParticipantsByIDLoader
|
||||
LabelsByID LabelsByIDLoader
|
||||
|
||||
CommentsByIDUnsafe CommentsByIDLoader
|
||||
SubsByTicketIDUnsafe SubsByTicketIDLoader
|
||||
CommentsByIDUnsafe CommentsByIDLoader
|
||||
SubsByTicketIDUnsafe SubsByTicketIDLoader
|
||||
SubsByTrackerIDUnsafe SubsByTrackerIDLoader
|
||||
}
|
||||
|
||||
func fetchUsersByID(ctx context.Context) func(ids []int) ([]*model.User, []error) {
|
||||
|
@ -655,6 +657,61 @@ func fetchSubsByTicketIDUnsafe(ctx context.Context) func(ids []int) ([]*model.Ti
|
|||
}
|
||||
}
|
||||
|
||||
func fetchSubsByTrackerIDUnsafe(ctx context.Context) func(ids []int) ([]*model.TrackerSubscription, []error) {
|
||||
return func(ids []int) ([]*model.TrackerSubscription, []error) {
|
||||
subs := make([]*model.TrackerSubscription, len(ids))
|
||||
|
||||
if err := database.WithTx(ctx, &sql.TxOptions{
|
||||
Isolation: 0,
|
||||
ReadOnly: true,
|
||||
}, func (tx *sql.Tx) error {
|
||||
var (
|
||||
err error
|
||||
rows *sql.Rows
|
||||
)
|
||||
query := database.
|
||||
Select(ctx, (&model.SubscriptionInfo{}).As(`sub`)).
|
||||
Column(`sub.tracker_id`).
|
||||
From(`ticket_subscription sub`).
|
||||
Join(`participant p ON p.id = sub.participant_id`).
|
||||
Where(`p.user_id = ? AND sub.tracker_id = ANY(?)`,
|
||||
auth.ForContext(ctx).UserID, pq.Array(ids))
|
||||
if rows, err = query.RunWith(tx).QueryContext(ctx); err != nil {
|
||||
return err
|
||||
}
|
||||
defer rows.Close()
|
||||
|
||||
subsByTrackerID := map[int]*model.TrackerSubscription{}
|
||||
for rows.Next() {
|
||||
var trackerID int
|
||||
si := model.SubscriptionInfo{}
|
||||
if err := rows.Scan(append(database.Scan(
|
||||
ctx, &si), &trackerID)...); err != nil {
|
||||
return err
|
||||
}
|
||||
subsByTrackerID[trackerID] = &model.TrackerSubscription{
|
||||
ID: si.ID,
|
||||
Created: si.Created,
|
||||
TrackerID: trackerID,
|
||||
}
|
||||
}
|
||||
if err = rows.Err(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
for i, id := range ids {
|
||||
subs[i] = subsByTrackerID[id]
|
||||
}
|
||||
|
||||
return nil
|
||||
}); err != nil {
|
||||
panic(err)
|
||||
}
|
||||
|
||||
return subs, nil
|
||||
}
|
||||
}
|
||||
|
||||
func Middleware(next http.Handler) http.Handler {
|
||||
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
ctx := context.WithValue(r.Context(), loadersCtxKey, &Loaders{
|
||||
|
@ -708,6 +765,11 @@ func Middleware(next http.Handler) http.Handler {
|
|||
wait: 1 * time.Millisecond,
|
||||
fetch: fetchSubsByTicketIDUnsafe(r.Context()),
|
||||
},
|
||||
SubsByTrackerIDUnsafe: SubsByTrackerIDLoader{
|
||||
maxBatch: 100,
|
||||
wait: 1 * time.Millisecond,
|
||||
fetch: fetchSubsByTrackerIDUnsafe(r.Context()),
|
||||
},
|
||||
})
|
||||
r = r.WithContext(ctx)
|
||||
next.ServeHTTP(w, r)
|
||||
|
|
|
@ -0,0 +1,224 @@
|
|||
// Code generated by github.com/vektah/dataloaden, DO NOT EDIT.
|
||||
|
||||
package loaders
|
||||
|
||||
import (
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"git.sr.ht/~sircmpwn/todo.sr.ht/api/graph/model"
|
||||
)
|
||||
|
||||
// SubsByTrackerIDLoaderConfig captures the config to create a new SubsByTrackerIDLoader
|
||||
type SubsByTrackerIDLoaderConfig struct {
|
||||
// Fetch is a method that provides the data for the loader
|
||||
Fetch func(keys []int) ([]*model.TrackerSubscription, []error)
|
||||
|
||||
// Wait is how long wait before sending a batch
|
||||
Wait time.Duration
|
||||
|
||||
// MaxBatch will limit the maximum number of keys to send in one batch, 0 = not limit
|
||||
MaxBatch int
|
||||
}
|
||||
|
||||
// NewSubsByTrackerIDLoader creates a new SubsByTrackerIDLoader given a fetch, wait, and maxBatch
|
||||
func NewSubsByTrackerIDLoader(config SubsByTrackerIDLoaderConfig) *SubsByTrackerIDLoader {
|
||||
return &SubsByTrackerIDLoader{
|
||||
fetch: config.Fetch,
|
||||
wait: config.Wait,
|
||||
maxBatch: config.MaxBatch,
|
||||
}
|
||||
}
|
||||
|
||||
// SubsByTrackerIDLoader batches and caches requests
|
||||
type SubsByTrackerIDLoader struct {
|
||||
// this method provides the data for the loader
|
||||
fetch func(keys []int) ([]*model.TrackerSubscription, []error)
|
||||
|
||||
// how long to done before sending a batch
|
||||
wait time.Duration
|
||||
|
||||
// this will limit the maximum number of keys to send in one batch, 0 = no limit
|
||||
maxBatch int
|
||||
|
||||
// INTERNAL
|
||||
|
||||
// lazily created cache
|
||||
cache map[int]*model.TrackerSubscription
|
||||
|
||||
// the current batch. keys will continue to be collected until timeout is hit,
|
||||
// then everything will be sent to the fetch method and out to the listeners
|
||||
batch *subsByTrackerIDLoaderBatch
|
||||
|
||||
// mutex to prevent races
|
||||
mu sync.Mutex
|
||||
}
|
||||
|
||||
type subsByTrackerIDLoaderBatch struct {
|
||||
keys []int
|
||||
data []*model.TrackerSubscription
|
||||
error []error
|
||||
closing bool
|
||||
done chan struct{}
|
||||
}
|
||||
|
||||
// Load a TrackerSubscription by key, batching and caching will be applied automatically
|
||||
func (l *SubsByTrackerIDLoader) Load(key int) (*model.TrackerSubscription, error) {
|
||||
return l.LoadThunk(key)()
|
||||
}
|
||||
|
||||
// LoadThunk returns a function that when called will block waiting for a TrackerSubscription.
|
||||
// This method should be used if you want one goroutine to make requests to many
|
||||
// different data loaders without blocking until the thunk is called.
|
||||
func (l *SubsByTrackerIDLoader) LoadThunk(key int) func() (*model.TrackerSubscription, error) {
|
||||
l.mu.Lock()
|
||||
if it, ok := l.cache[key]; ok {
|
||||
l.mu.Unlock()
|
||||
return func() (*model.TrackerSubscription, error) {
|
||||
return it, nil
|
||||
}
|
||||
}
|
||||
if l.batch == nil {
|
||||
l.batch = &subsByTrackerIDLoaderBatch{done: make(chan struct{})}
|
||||
}
|
||||
batch := l.batch
|
||||
pos := batch.keyIndex(l, key)
|
||||
l.mu.Unlock()
|
||||
|
||||
return func() (*model.TrackerSubscription, error) {
|
||||
<-batch.done
|
||||
|
||||
var data *model.TrackerSubscription
|
||||
if pos < len(batch.data) {
|
||||
data = batch.data[pos]
|
||||
}
|
||||
|
||||
var err error
|
||||
// its convenient to be able to return a single error for everything
|
||||
if len(batch.error) == 1 {
|
||||
err = batch.error[0]
|
||||
} else if batch.error != nil {
|
||||
err = batch.error[pos]
|
||||
}
|
||||
|
||||
if err == nil {
|
||||
l.mu.Lock()
|
||||
l.unsafeSet(key, data)
|
||||
l.mu.Unlock()
|
||||
}
|
||||
|
||||
return data, err
|
||||
}
|
||||
}
|
||||
|
||||
// LoadAll fetches many keys at once. It will be broken into appropriate sized
|
||||
// sub batches depending on how the loader is configured
|
||||
func (l *SubsByTrackerIDLoader) LoadAll(keys []int) ([]*model.TrackerSubscription, []error) {
|
||||
results := make([]func() (*model.TrackerSubscription, error), len(keys))
|
||||
|
||||
for i, key := range keys {
|
||||
results[i] = l.LoadThunk(key)
|
||||
}
|
||||
|
||||
trackerSubscriptions := make([]*model.TrackerSubscription, len(keys))
|
||||
errors := make([]error, len(keys))
|
||||
for i, thunk := range results {
|
||||
trackerSubscriptions[i], errors[i] = thunk()
|
||||
}
|
||||
return trackerSubscriptions, errors
|
||||
}
|
||||
|
||||
// LoadAllThunk returns a function that when called will block waiting for a TrackerSubscriptions.
|
||||
// This method should be used if you want one goroutine to make requests to many
|
||||
// different data loaders without blocking until the thunk is called.
|
||||
func (l *SubsByTrackerIDLoader) LoadAllThunk(keys []int) func() ([]*model.TrackerSubscription, []error) {
|
||||
results := make([]func() (*model.TrackerSubscription, error), len(keys))
|
||||
for i, key := range keys {
|
||||
results[i] = l.LoadThunk(key)
|
||||
}
|
||||
return func() ([]*model.TrackerSubscription, []error) {
|
||||
trackerSubscriptions := make([]*model.TrackerSubscription, len(keys))
|
||||
errors := make([]error, len(keys))
|
||||
for i, thunk := range results {
|
||||
trackerSubscriptions[i], errors[i] = thunk()
|
||||
}
|
||||
return trackerSubscriptions, errors
|
||||
}
|
||||
}
|
||||
|
||||
// Prime the cache with the provided key and value. If the key already exists, no change is made
|
||||
// and false is returned.
|
||||
// (To forcefully prime the cache, clear the key first with loader.clear(key).prime(key, value).)
|
||||
func (l *SubsByTrackerIDLoader) Prime(key int, value *model.TrackerSubscription) bool {
|
||||
l.mu.Lock()
|
||||
var found bool
|
||||
if _, found = l.cache[key]; !found {
|
||||
// make a copy when writing to the cache, its easy to pass a pointer in from a loop var
|
||||
// and end up with the whole cache pointing to the same value.
|
||||
cpy := *value
|
||||
l.unsafeSet(key, &cpy)
|
||||
}
|
||||
l.mu.Unlock()
|
||||
return !found
|
||||
}
|
||||
|
||||
// Clear the value at key from the cache, if it exists
|
||||
func (l *SubsByTrackerIDLoader) Clear(key int) {
|
||||
l.mu.Lock()
|
||||
delete(l.cache, key)
|
||||
l.mu.Unlock()
|
||||
}
|
||||
|
||||
func (l *SubsByTrackerIDLoader) unsafeSet(key int, value *model.TrackerSubscription) {
|
||||
if l.cache == nil {
|
||||
l.cache = map[int]*model.TrackerSubscription{}
|
||||
}
|
||||
l.cache[key] = value
|
||||
}
|
||||
|
||||
// keyIndex will return the location of the key in the batch, if its not found
|
||||
// it will add the key to the batch
|
||||
func (b *subsByTrackerIDLoaderBatch) keyIndex(l *SubsByTrackerIDLoader, key int) int {
|
||||
for i, existingKey := range b.keys {
|
||||
if key == existingKey {
|
||||
return i
|
||||
}
|
||||
}
|
||||
|
||||
pos := len(b.keys)
|
||||
b.keys = append(b.keys, key)
|
||||
if pos == 0 {
|
||||
go b.startTimer(l)
|
||||
}
|
||||
|
||||
if l.maxBatch != 0 && pos >= l.maxBatch-1 {
|
||||
if !b.closing {
|
||||
b.closing = true
|
||||
l.batch = nil
|
||||
go b.end(l)
|
||||
}
|
||||
}
|
||||
|
||||
return pos
|
||||
}
|
||||
|
||||
func (b *subsByTrackerIDLoaderBatch) startTimer(l *SubsByTrackerIDLoader) {
|
||||
time.Sleep(l.wait)
|
||||
l.mu.Lock()
|
||||
|
||||
// we must have hit a batch limit and are already finalizing this batch
|
||||
if b.closing {
|
||||
l.mu.Unlock()
|
||||
return
|
||||
}
|
||||
|
||||
l.batch = nil
|
||||
l.mu.Unlock()
|
||||
|
||||
b.end(l)
|
||||
}
|
||||
|
||||
func (b *subsByTrackerIDLoaderBatch) end(l *SubsByTrackerIDLoader) {
|
||||
b.data, b.error = l.fetch(b.keys)
|
||||
close(b.done)
|
||||
}
|
Loading…
Reference in New Issue