opensourcemirror
/
vue
mirror of https://github.com/vuejs/vue.git
1
0
Fork 0
Code Issues Releases Wiki Activity

refactor: remove useless parameter to the function removeVnodes (#9914) 

close #9910
This commit is contained in:
子迟 2019-04-25 10:34:55 +08:00 committed by Evan You
parent ea113d2618
commit 43b98fe251
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/weex-vue-framework/factory.js
View File

@ -5797,7 +5797,7 @@ function createPatchFunction (backend) {
} }
} }
function removeVnodes (parentElm, vnodes, startIdx, endIdx) { function removeVnodes (vnodes, startIdx, endIdx) {
for (; startIdx <= endIdx; ++startIdx) { for (; startIdx <= endIdx; ++startIdx) {
var ch = vnodes[startIdx]; var ch = vnodes[startIdx];
if (isDef(ch)) { if (isDef(ch)) {
@ -5908,7 +5908,7 @@ function createPatchFunction (backend) {
refElm = isUndef(newCh[newEndIdx + 1]) ? null : newCh[newEndIdx + 1].elm; refElm = isUndef(newCh[newEndIdx + 1]) ? null : newCh[newEndIdx + 1].elm;
addVnodes(parentElm, refElm, newCh, newStartIdx, newEndIdx, insertedVnodeQueue); addVnodes(parentElm, refElm, newCh, newStartIdx, newEndIdx, insertedVnodeQueue);
} else if (newStartIdx > newEndIdx) { } else if (newStartIdx > newEndIdx) {
removeVnodes(parentElm, oldCh, oldStartIdx, oldEndIdx); removeVnodes(oldCh, oldStartIdx, oldEndIdx);
} }
} }
@ -5985,7 +5985,7 @@ function createPatchFunction (backend) {
if (isDef(oldVnode.text)) { nodeOps.setTextContent(elm, ''); } if (isDef(oldVnode.text)) { nodeOps.setTextContent(elm, ''); }
addVnodes(elm, null, ch, 0, ch.length - 1, insertedVnodeQueue); addVnodes(elm, null, ch, 0, ch.length - 1, insertedVnodeQueue);
} else if (isDef(oldCh)) { } else if (isDef(oldCh)) {
removeVnodes(elm, oldCh, 0, oldCh.length - 1); removeVnodes(oldCh, 0, oldCh.length - 1);
} else if (isDef(oldVnode.text)) { } else if (isDef(oldVnode.text)) {
nodeOps.setTextContent(elm, ''); nodeOps.setTextContent(elm, '');
} }
@ -6216,7 +6216,7 @@ function createPatchFunction (backend) {
// destroy old node // destroy old node
if (isDef(parentElm$1)) { if (isDef(parentElm$1)) {
removeVnodes(parentElm$1, [oldVnode], 0, 0); removeVnodes([oldVnode], 0, 0);
} else if (isDef(oldVnode.tag)) { } else if (isDef(oldVnode.tag)) {
invokeDestroyHook(oldVnode); invokeDestroyHook(oldVnode);
} }

8
src/core/vdom/patch.js
View File

@ -358,7 +358,7 @@ export function createPatchFunction (backend) {
} }
} }
function removeVnodes (parentElm, vnodes, startIdx, endIdx) { function removeVnodes (vnodes, startIdx, endIdx) {
for (; startIdx <= endIdx; ++startIdx) { for (; startIdx <= endIdx; ++startIdx) {
const ch = vnodes[startIdx] const ch = vnodes[startIdx]
if (isDef(ch)) { if (isDef(ch)) {
@ -469,7 +469,7 @@ export function createPatchFunction (backend) {
refElm = isUndef(newCh[newEndIdx + 1]) ? null : newCh[newEndIdx + 1].elm refElm = isUndef(newCh[newEndIdx + 1]) ? null : newCh[newEndIdx + 1].elm
addVnodes(parentElm, refElm, newCh, newStartIdx, newEndIdx, insertedVnodeQueue) addVnodes(parentElm, refElm, newCh, newStartIdx, newEndIdx, insertedVnodeQueue)
} else if (newStartIdx > newEndIdx) { } else if (newStartIdx > newEndIdx) {
removeVnodes(parentElm, oldCh, oldStartIdx, oldEndIdx) removeVnodes(oldCh, oldStartIdx, oldEndIdx)
} }
} }
@ -561,7 +561,7 @@ export function createPatchFunction (backend) {
if (isDef(oldVnode.text)) nodeOps.setTextContent(elm, '') if (isDef(oldVnode.text)) nodeOps.setTextContent(elm, '')
addVnodes(elm, null, ch, 0, ch.length - 1, insertedVnodeQueue) addVnodes(elm, null, ch, 0, ch.length - 1, insertedVnodeQueue)
} else if (isDef(oldCh)) { } else if (isDef(oldCh)) {
removeVnodes(elm, oldCh, 0, oldCh.length - 1) removeVnodes(oldCh, 0, oldCh.length - 1)
} else if (isDef(oldVnode.text)) { } else if (isDef(oldVnode.text)) {
nodeOps.setTextContent(elm, '') nodeOps.setTextContent(elm, '')
} }
@ -790,7 +790,7 @@ export function createPatchFunction (backend) {
// destroy old node // destroy old node
if (isDef(parentElm)) { if (isDef(parentElm)) {
removeVnodes(parentElm, [oldVnode], 0, 0) removeVnodes([oldVnode], 0, 0)
} else if (isDef(oldVnode.tag)) { } else if (isDef(oldVnode.tag)) {
invokeDestroyHook(oldVnode) invokeDestroyHook(oldVnode)
} }