Clean up YAML files in the repository. (#11570)

* Assorted yamllint config updates.

* Extended line length limit to 150. This is still a reasonable limit
  but cuts down on warnings a bit.
* Added explicit ignore directives for external repo paths. This makes
  using yamllint locally nicer.
* Enabled the rule to require null values to be explicit. This rule
  helps prevent accidental bogus mapping problems resulting from
  implicit null values combined with incorrect indentation.

This only results in new errors in a couple of GHA workflows, which will
be fixed in the next commit.

* Fix all yamllint warnings in yaml file sin the repo.

Most are indentation or spurious empty lines.

* Fix invalid null value.

.codeclimate.yml

@@ -43,11 +43,11 @@ plugins:
     enabled: false
     config:
       languages:
-      - javascript:
+        - javascript:
-          mass_threshold: 100
+            mass_threshold: 100
-      - python:
+        - python:
-          python_version: 3
+            python_version: 3
-          mass_threshold: 100
+            mass_threshold: 100
     checks:
       Similar code:
         enabled: false
@@ -96,4 +96,3 @@ exclude_patterns:
   - "collectors/node.d.plugin/node_modules/extend.js"
   - "collectors/node.d.plugin/node_modules/pixl-xml.js"
   - "collectors/node.d.plugin/node_modules/net-snmp.js"
-

.github/workflows/build-and-install.yml

@@ -4,7 +4,7 @@ on:
   push:
     branches:
       - master
-  pull_request:
+  pull_request: null
 env:
   DO_NOT_TRACK: 1
 jobs:

.github/workflows/checks.yml

@@ -4,7 +4,7 @@ on:
   push:
     branches:
       - master
-  pull_request:
+  pull_request: null
 env:
   DO_NOT_TRACK: 1
 jobs:

.github/workflows/coverity.yml

@@ -40,7 +40,7 @@ jobs:
         uses: rtCamp/action-slack-notify@v2
         env:
           SLACK_COLOR: 'danger'
-          SLACK_FOOTER:
+          SLACK_FOOTER: ''
           SLACK_ICON_EMOJI: ':github-actions:'
           SLACK_TITLE: 'Coverity run failed:'
           SLACK_USERNAME: 'GitHub Actions'

.github/workflows/docker.yml

@@ -4,7 +4,7 @@ on:
   push:
     branches:
       - master
-  pull_request:
+  pull_request: null
   workflow_dispatch:
     inputs:
       version:
@@ -99,7 +99,7 @@ jobs:
         uses: rtCamp/action-slack-notify@v2
         env:
           SLACK_COLOR: 'danger'
-          SLACK_FOOTER:
+          SLACK_FOOTER: ''
           SLACK_ICON_EMOJI: ':github-actions:'
           SLACK_TITLE: 'Docker Build failed:'
           SLACK_USERNAME: 'GitHub Actions'

.github/workflows/packaging.yml

@@ -133,7 +133,6 @@ jobs:
         uses: rtCamp/action-slack-notify@v2
         env:
           SLACK_COLOR: 'danger'
-          SLACK_FOOTER:
           SLACK_ICON_EMOJI: ':github-actions:'
           SLACK_TITLE: 'Package Build failed:'
           SLACK_USERNAME: 'GitHub Actions'

.github/workflows/repoconfig-packages.yml

@@ -2,7 +2,7 @@
 # Handles building of binary packages for the agent.
 name: Repository Packages
 on:
-  workflow_dispatch:
+  workflow_dispatch: null
 env:
   DO_NOT_TRACK: 1
 jobs:
@@ -60,7 +60,7 @@ jobs:
         uses: rtCamp/action-slack-notify@v2
         env:
           SLACK_COLOR: 'danger'
-          SLACK_FOOTER:
+          SLACK_FOOTER: ''
           SLACK_ICON_EMOJI: ':github-actions:'
           SLACK_TITLE: 'Repository Package Build failed:'
           SLACK_USERNAME: 'GitHub Actions'

.github/workflows/review.yml

@@ -2,7 +2,7 @@
 # Runs various ReviewDog based checks against PR with suggested changes to improve quality
 name: Review
 on:
-  pull_request:
+  pull_request: null
 env:
   run_eslint: 0
   run_hadolint: 0

.yamllint.yml

@@ -6,10 +6,11 @@ yaml-files:
   - 'collectors/python.d.plugin/*.conf'
   - 'collectors/python.d.plugin/*/*.conf'
 
+ignore: |
+  mqtt_websockets/
+  packaging/makeself/tmp/
+
 rules:
-  line-length:
-    max: 120
-    level: warning
   braces: enable
   brackets: enable
   colons: enable
@@ -19,9 +20,14 @@ rules:
   document-end: disable
   document-start: disable
   empty-lines: enable
-  empty-values: disable
+  empty-values: enable
   hyphens: enable
   indentation: enable
+  line-length:
+    max: 150
+    level: warning
+    allow-non-breakable-words: true
+    allow-non-breakable-inline-mappings: true
   key-duplicates: enable
   key-ordering: disable
   new-line-at-end-of-file: enable

build_external/scenarios/aclk-testing/agent-compose.yml

@@ -5,8 +5,8 @@ services:
       context: ../../..
       dockerfile: build_external/make-install.Dockerfile
       args:
-      - DISTRO=arch
+        - DISTRO=arch
-      - VERSION=current
+        - VERSION=current
     image: arch_current_dev:latest
     command: >
       sh -c "echo -n 00000000-0000-0000-0000-000000000000 >/var/lib/netdata/cloud.d/claimed_id &&
@@ -15,5 +15,4 @@ services:
              echo '  agent cloud link port = 9002' >>/etc/netdata/netdata.conf &&
              /usr/sbin/netdata -D"
     ports:
-    - 20000:19999
+      - 20000:19999
-

build_external/scenarios/aclk-testing/agent-valgrind-compose.yml

@@ -5,8 +5,8 @@ services:
       context: ../../..
       dockerfile: build_external/make-install.Dockerfile
       args:
-      - DISTRO=arch
+        - DISTRO=arch
-      - VERSION=extras
+        - VERSION=extras
     image: arch_extras_dev:latest
     command: >
       sh -c "echo -n 00000000-0000-0000-0000-000000000000 >/var/lib/netdata/cloud.d/claimed_id &&
@@ -15,5 +15,4 @@ services:
              echo '  agent cloud link port = 9002' >>/etc/netdata/netdata.conf &&
              /usr/sbin/valgrind --leak-check=full /usr/sbin/netdata -D -W debug_flags=0x200000000"
     ports:
-    - 20000:19999
+      - 20000:19999
-

build_external/scenarios/aclk-testing/paho-compose.yml

@@ -3,4 +3,4 @@ services:
   paho_inspect:
     build:
       context: .
-      dockerfile: paho.Dockerfile
+      dockerfile: paho.Dockerfile

build_external/scenarios/aclk-testing/vernemq-compose.yml

@@ -4,4 +4,3 @@ services:
     build:
       dockerfile: configureVerneMQ.Dockerfile
       context: .
-

build_external/scenarios/gaps_hi/child-compose.yml

@@ -10,5 +10,4 @@ services:
       #- ./child_guid:/var/lib/netdata/registry/netdata.public.unique.id:ro
       - ./min.conf:/etc/netdata/netdata.conf:ro
     cap_add:
-    - SYS_PTRACE
+      - SYS_PTRACE
-

build_external/scenarios/gaps_hi/middle-compose.yml

@@ -10,4 +10,4 @@ services:
       - ./middle_guid:/var/lib/netdata/registry/netdata.public.unique.id:ro
       - ./min.conf:/etc/netdata/netdata.conf:ro
     cap_add:
-    - SYS_PTRACE
+      - SYS_PTRACE

build_external/scenarios/gaps_lo/child-compose.yml

@@ -12,4 +12,3 @@ services:
       - ./mostly_off.conf:/etc/netdata/netdata.conf:ro
     cap_add:
       - SYS_PTRACE
-

build_external/scenarios/only-agent/docker-compose.yml

@@ -4,5 +4,5 @@ services:
     image: ${Distro}_${Version}_dev
     command: /usr/sbin/netdata -D
     ports:
-    - 80
+      - 80
-    - 443
+      - 443

web/api/netdata-swagger.yaml

@@ -456,7 +456,7 @@ paths:
           required: false
           allowEmptyValue: true
           schema:
-           oneOf:
+            oneOf:
               - type: string
                 enum:
                   - green
@@ -478,7 +478,7 @@ paths:
           required: false
           allowEmptyValue: true
           schema:
-           oneOf:
+            oneOf:
               - type: string
                 enum:
                   - green