Add test for when apk icon src could not be found

An APK (Netflix) was found to have the following icon filename:

    \u2003\u2009\n.xml

This breaks the aapt dump parsing because it iterates line by line and
this filename goes across two lines. Consequently, icon_src will be
None (default value) when it is passed to the icons parser.
This commit is contained in:
Jonas Kalderstam 2018-03-27 18:39:59 +02:00
parent 1f706283ce
commit 9e4459d7d1
1 changed files with 10 additions and 0 deletions

View File

@ -647,6 +647,16 @@ class UpdateTest(unittest.TestCase):
with self.assertRaises(fdroidserver.exception.FDroidException):
fdroidserver.update.has_known_vulnerability('janus.apk')
def test_get_apk_icon_when_src_is_none(self):
config = dict()
fdroidserver.common.fill_config_defaults(config)
fdroidserver.common.config = config
fdroidserver.update.config = config
# pylint: disable=protected-access
icons_src = fdroidserver.update._get_apk_icons_src('urzip-release.apk', None)
assert icons_src == {}
if __name__ == "__main__":
parser = optparse.OptionParser()