opensourcemirror
/
fdroid-server
mirror of https://gitlab.com/fdroid/fdroidserver.git
1
0
Fork 0
Code Issues Releases Wiki Activity

test that get_apk_id throws exceptions (issuebot#60)

This commit is contained in:
Hans-Christoph Steiner 2022-10-05 16:46:26 +02:00
parent 828eb938c3
commit 353ee84a6f
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/common.TestCase
View File

@ -975,6 +975,17 @@ class CommonTest(unittest.TestCase):
self.assertEqual(versionCode, vc, 'aapt versionCode parsing failed for ' + apkfilename)
self.assertEqual(versionName, vn, 'aapt versionName parsing failed for ' + apkfilename)
def test_get_apk_id_bad_apk(self):
"""get_apk_id should never return None on error, only raise exceptions"""
with self.assertRaises(KeyError):
fdroidserver.common.get_apk_id('Norway_bouvet_europe_2.obf.zip')
shutil.copy('Norway_bouvet_europe_2.obf.zip', self.tmpdir)
os.chdir(self.tmpdir)
with ZipFile('Norway_bouvet_europe_2.obf.zip', 'a') as zipfp:
zipfp.writestr('AndroidManifest.xml', 'not a manifest')
with self.assertRaises(KeyError):
fdroidserver.common.get_apk_id('Norway_bouvet_europe_2.obf.zip')
def test_get_apk_id_bad_path(self):
with self.assertRaises(FDroidException):
fdroidserver.common.get_apk_id('nope')