Set all list defaults to an actual list

Iterating over the defaults will crash otherwise. Update pickle files.

fdroidserver/metadata.py

@@ -278,7 +278,7 @@ class Build():
         self.submodules = False
         self.init = ''
         self.patch = []
-        self.gradle = False
+        self.gradle = []
         self.maven = False
         self.kivy = False
         self.output = None
@@ -290,7 +290,7 @@ class Build():
         self.rm = []
         self.extlibs = []
         self.prebuild = ''
-        self.update = None
+        self.update = []
         self.target = None
         self.scanignore = []
         self.scandelete = []
@@ -299,7 +299,7 @@ class Build():
         self.ndk = None
         self.preassemble = []
         self.gradleprops = []
-        self.antcommands = None
+        self.antcommands = []
         self.novcheck = False
 
         self._modified = set()

tests/metadata/net.osmand.plus.pickle

@@ -110,316 +110,324 @@ p53
 S'submodules'
 p56
 I01
-sS'kivy'
+sS'vercode'
 p57
-I00
-sS'forceversion'
+S'182'
 p58
-I00
-sS'oldsdkloc'
+sS'forceversion'
 p59
 I00
-sS'antcommands'
+sS'oldsdkloc'
 p60
-NsS'scanignore'
+I00
+sS'gradleprops'
 p61
 (lp62
-sS'gradle'
+sS'kivy'
 p63
 I00
-sS'srclibs'
+sS'patch'
 p64
 (lp65
-sS'encoding'
+sS'scanignore'
 p66
+(lp67
+sS'srclibs'
+p68
+(lp69
+sS'encoding'
+p70
 NsS'extlibs'
-p67
-(lp68
+p71
+(lp72
 sS'init'
-p69
+p73
 g25
 sS'version'
-p70
-S'1.8.2'
-p71
-sS'subdir'
-p72
-S'android/OsmAnd'
-p73
-sS'rm'
 p74
-(lp75
+S'1.8.2'
+p75
 sS'build'
 p76
 S'./old-ndk-build.sh && ant -Dsdk.dir="$ANDROID_SDK" -Dndk.dir="$ANDROID_NDK" -DBLACKBERRY_BUILD=false -DBUILD_SUFFIX= -DAPK_NUMBER_VERSION=182 "-DFEATURES=+play_market +gps_status -parking_plugin -blackberry -amazon -route_nav" -DCLEAN_CPP=false -DPACKAGE_TO_BUILT=net.osmand.plus -DAPK_VERSION=1.8.2 -Dnet.osmand.plus= -Dbuild.version=1.8.2 -Dbuild.version.code=182 -Dnativeoff=false "-DversionFeatures=+play_market +gps_status -parking_plugin -blackberry -amazon -route_nav" clean release'
 p77
-sS'vercode'
+sS'rm'
 p78
-S'182'
-p79
-sS'forcevercode'
+(lp79
+sS'subdir'
 p80
+S'android/OsmAnd'
+p81
+sS'forcevercode'
+p82
 I00
 sS'preassemble'
-p81
-(lp82
-sS'update'
 p83
-NsS'maven'
-p84
+(lp84
+sS'update'
+p85
+(lp86
+sS'maven'
+p87
 I00
 sS'disable'
-p85
-I00
-sS'commit'
-p86
-S'76ada6c8a08afe69acb755503373ac36328ef665'
-p87
-sS'scandelete'
 p88
-(lp89
-sS'buildjni'
-p90
-S'no'
-p91
-sS'ndk'
-p92
-NsS'target'
-p93
-NsS'gradleprops'
-p94
-(lp95
-sS'patch'
-p96
-(lp97
-sS'prebuild'
-p98
-S'sed -i \'s/"OsmAnd+"/"OsmAnd~"/g\' build.xml'
-p99
-sS'novcheck'
-p100
 I00
 sS'output'
-p101
+p89
 S'bin/OsmAnd-release-unsigned.apk'
+p90
+sS'scandelete'
+p91
+(lp92
+sS'buildjni'
+p93
+S'no'
+p94
+sS'ndk'
+p95
+NsS'target'
+p96
+NsS'antcommands'
+p97
+(lp98
+sS'gradle'
+p99
+(lp100
+sS'prebuild'
+p101
+S'sed -i \'s/"OsmAnd+"/"OsmAnd~"/g\' build.xml'
 p102
-sa(dp103
+sS'novcheck'
+p103
+I00
+sS'commit'
+p104
+S'76ada6c8a08afe69acb755503373ac36328ef665'
+p105
+sa(dp106
 g56
 I01
 sg57
-I00
-sg58
-I00
+S'183'
+p107
 sg59
 I00
 sg60
-Nsg61
-(lp104
+I00
+sg61
+(lp108
 sg63
 I00
 sg64
-(lp105
-sg66
-Nsg67
-(lp106
-sg69
-g25
-sg70
-S'1.8.3'
-p107
-sg72
-S'android/OsmAnd'
-p108
-sg74
 (lp109
-sg76
-S'../../build'
-p110
-sg78
-S'183'
-p111
-sg80
-I00
-sg81
+sg66
+(lp110
+sg68
+(lp111
+sg70
+Nsg71
 (lp112
-sg83
-Nsg84
-I00
-sg85
-I00
-sg86
+sg73
+g25
+sg74
 S'1.8.3'
 p113
-sg88
-(lp114
-sg90
-S'no'
-p115
-sg92
-Nsg93
-Nsg94
-(lp116
-sg96
+sg76
+S'../../build'
+p114
+sg78
+(lp115
+sg80
+S'android/OsmAnd'
+p116
+sg82
+I00
+sg83
 (lp117
-sg98
-g25
-sg100
+sg85
+(lp118
+sg87
 I00
-sg101
+sg88
+I00
+sg89
 S'bin/OsmAnd-release-unsigned.apk'
-p118
-sa(dp119
-g56
-I01
-sg57
-I00
-sg58
-I00
-sg59
-I00
-sg60
-Nsg61
+p119
+sg91
 (lp120
-sg63
-I00
-sg64
-(lp121
-sg66
-Nsg67
-(lp122
-sg69
-g25
-sg70
-S'1.9.4'
-p123
-sg72
-S'android/OsmAnd'
-p124
-sg74
-(lp125
-sg76
-S'../../build'
-p126
-sg78
-S'196'
-p127
-sg80
-I00
-sg81
-(lp128
-sg83
-Nsg84
-I00
-sg85
-I00
-sg86
-S'1.9.4'
-p129
-sg88
-(lp130
-sg90
-S'no'
-p131
-sg92
-S'r10d'
-p132
 sg93
-Nsg94
-(lp133
-sg96
-(lp134
-sg98
-g25
-sg100
-I00
+S'no'
+p121
+sg95
+Nsg96
+Nsg97
+(lp122
+sg99
+(lp123
 sg101
-S'bin/OsmAnd-release-unsigned.apk'
-p135
-sa(dp136
+g25
+sg103
+I00
+sg104
+S'1.8.3'
+p124
+sa(dp125
 g56
 I01
 sg57
-I00
-sg58
-I00
+S'196'
+p126
 sg59
 I00
 sg60
-Nsg61
-(lp137
+I00
+sg61
+(lp127
 sg63
 I00
 sg64
-(lp138
+(lp128
 sg66
-Nsg67
-(lp139
-sg69
-g25
+(lp129
+sg68
+(lp130
 sg70
-S'1.9.5'
-p140
-sg72
-S'android/OsmAnd'
-p141
+Nsg71
+(lp131
+sg73
+g25
 sg74
-(lp142
+S'1.9.4'
+p132
 sg76
 S'../../build'
-p143
+p133
 sg78
-S'197'
-p144
+(lp134
 sg80
+S'android/OsmAnd'
+p135
+sg82
 I00
-sg81
-(lp145
 sg83
-Nsg84
-I00
+(lp136
 sg85
+(lp137
+sg87
 I00
-sg86
-S'1.9.5'
-p146
 sg88
-(lp147
-sg90
-S'no'
-p148
-sg92
-S'r10d'
-p149
-sg93
-Nsg94
-(lp150
-sg96
-(lp151
-sg98
-g25
-sg100
 I00
-sg101
+sg89
 S'bin/OsmAnd-release-unsigned.apk'
+p138
+sg91
+(lp139
+sg93
+S'no'
+p140
+sg95
+S'r10d'
+p141
+sg96
+Nsg97
+(lp142
+sg99
+(lp143
+sg101
+g25
+sg103
+I00
+sg104
+S'1.9.4'
+p144
+sa(dp145
+g56
+I01
+sg57
+S'197'
+p146
+sg59
+I00
+sg60
+I00
+sg61
+(lp147
+sg63
+I00
+sg64
+(lp148
+sg66
+(lp149
+sg68
+(lp150
+sg70
+Nsg71
+(lp151
+sg73
+g25
+sg74
+S'1.9.5'
 p152
-sasS'FlattrID'
+sg76
+S'../../build'
 p153
-NsS'metadatapath'
-p154
-S'metadata/net.osmand.plus.xml'
+sg78
+(lp154
+sg80
+S'android/OsmAnd'
 p155
-sS'Disabled'
-p156
-NsS'Web Site'
-p157
-S'http://osmand.net'
+sg82
+I00
+sg83
+(lp156
+sg85
+(lp157
+sg87
+I00
+sg88
+I00
+sg89
+S'bin/OsmAnd-release-unsigned.apk'
 p158
-sS'Update Check Name'
-p159
-NsS'Vercode Operation'
+sg91
+(lp159
+sg93
+S'no'
 p160
-NsS'Auto Update Mode'
+sg95
+S'r10d'
 p161
+sg96
+Nsg97
+(lp162
+sg99
+(lp163
+sg101
+g25
+sg103
+I00
+sg104
+S'1.9.5'
+p164
+sasS'FlattrID'
+p165
+NsS'metadatapath'
+p166
+S'metadata/net.osmand.plus.xml'
+p167
+sS'Disabled'
+p168
+NsS'Web Site'
+p169
+S'http://osmand.net'
+p170
+sS'Update Check Name'
+p171
+NsS'Vercode Operation'
+p172
+NsS'Auto Update Mode'
+p173
 S'None'
-p162
+p174
 s.