As described in
https://github.com/dwp-forge/columns/issues/5#issuecomment-638467603
sometime the Lexer constants have not been (auto)loaded when a syntax plugin
is invoked (I'm not sure why).
In general PSR2 discourages a mix of main code and function/class setup
with the call to define() being considered main code.
This patch moves these the define calls to a separate new file, solving
both of the above problems.
These are not all our defines. Instead I focused on the ones that are
ENUM-like.
In the future we should think about what defines can be replaced by
class constants and what other define() calls should be moved.
* master: (492 commits)
Avoid flaky tests by waiting full seconds
translation update
translation update
translation update
translation update
Check for null JS object on form field.
translation update
Rename _acl_add to _acl_addOrUpdate
Fix#1115
translation update
translation update
translation update
Update config.class.php
translation update
translation update
use inline template instead of .dist file to populate users.auth.php
authpdo: fix _query return type issue per Scrutinizer inspection
Update lang.php
Add ugc hint to nofollow
add UGC hint
...
This is based on #2506 but with a different approach to deal with unknown read error: If file function doesn't return an array, set it to an empty array. Somewhat pythonic?
This fixes a bug where the creator of a new page was not saved to metadata.
That could happen if a plugin calls pageinfo() in the IO_WIKIPAGE_WRITE
event AFTER handler. This creates a new .meta file for the page with the
page's mtime as the creation timestamp. That caused the if clause
changed in this commit to evaluate as false and thus the creator key was
not saved.
This commit now also treats the page as newly created if the created
date in the metadata to the file's current mtime.
In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.
This introduces a new dbg_deprecated() function which allows for easy
marking of deprecated functions. Each call is logged to the debuglog
when debuggin is enabled.
* master: (103 commits)
Add a basic test case for the cache
Events: Trigger a warning if the default action is not callable
Fix caching (make the event callback public again)
translation update
translation update
translation update
translation update
translation update
translation update
translation update
avoid HTTP image screenshot urls. closes#595
translation update
Extension manager: Fix cache extension to be .repo
adjusted the office type color again
another instance of empty() where an array key might not exist
remove placeholder van denied.txt
updated file icons once more
removed 'not logged in' text, loginform is shown already
Revert "added stripped bit to language file"
fixed index file
...
Conflicts:
inc/html.php
When page is removed, and diff can be requested between a revision and
current situation. This results in right revision is 0.
Similar case just after creating a page. A diff between the first
version and nothing before, result in left revision is 0.
In these cases a empty dummy revision is placed as selected value in
dropdown. Otherwise user got distracted by the revisions details shown
in select field, which are not related to the diff below.
With unit tests
One case is not yet fixed:
when rev1 is first rev from changelog, only $max/2 revisions are
retrieved, but it should retrieve $max revisions.
Andreas Gohr