When a non existing auth backend was configured, the action router ran
into an infinie loop exception. The reason was that the denied action
required a configured auth system, but denying access should always
work.
Interestingly the problem did not occur when the auth backend signalled
a failure to load. This was because the auth backend was not properly
deinitialized. This is now done.
To aid debugging similar problems, fatal errors are now logged through
the logging mechanism in the action router
This fixes plugins that expect that they can change the global $ACT
instead of $event->data in the ACTION_ACT_PREPROCESS event.
This make the whole route a little bit uncleaner but would increase
backwards compatibility.
I'm not sure how widespread the problem is and if adding this is a good
idea.
This should recreate the behaviour prior to #1933, where the event was
triggered for all ACT values. Some plugins, like edittable, depend on
the functionality.
Action can now abort to 'redirect' to explicitly trigger a redirect
back to showing the current page. Automatic triggering for post->show is
now only done when a 'show' action was not explicitly requested.
loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent that. In
addition, actionOK is also used to check for things that aren't Actions
(yet) like 'rss' and 'top'.
Now underscores can be used to have sub actions. The loader will try to
find an exact match first, then begin removing parts from the end until
a matching action is found.
This is not how integration of plugins would ideally be done in this new
system. Ideally an action plugin would actually implement an instance of
AbstractAction and would just fall into the normal flow of actions here.
However to not break a gazillion of existing plugins, this is just add
the existing two events into the new system through the use of a Plugin
action.
Maybe we could add "new" action plugins later.
Andreas Gohr