opensourcemirror
/
dokuwiki
mirror of https://github.com/splitbrain/dokuwiki.git
1
0
Fork 0
Code Issues Releases Wiki Activity

fix security problems in draft handling. fixes #3565

This commit is contained in:
Andreas Gohr 2021-12-17 23:22:25 +01:00
parent ecad51dd49
commit 2420159423
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
inc/Ajax.php
View File

@ -168,8 +168,10 @@ class Ajax {
$client = $_SERVER['REMOTE_USER'];
if(!$client) $client = clientIP(true);
$cname = getCacheName($client . $id, '.draft');
@unlink($cname);
$draft = new Draft($id, $client);
if ($draft->isDraftAvailable() && checkSecurityToken()) {
$draft->deleteDraft();
}
}
/**

2
inc/Draft.php
View File

@ -25,7 +25,7 @@ class Draft
{
$this->id = $ID;
$this->client = $client;
$this->cname = getCacheName($client.$ID, '.draft');
$this->cname = getCacheName("$client\n$ID", '.draft');
if(file_exists($this->cname) && file_exists(wikiFN($ID))) {
if (filemtime($this->cname) < filemtime(wikiFN($ID))) {
// remove stale draft

3
lib/scripts/edit.js
View File

@ -210,7 +210,8 @@ function deleteDraft() {
jQuery.post(DOKU_BASE + 'lib/exe/ajax.php',
{
call: 'draftdel',
id: $dwform.find('input[name=id]').val()
id: $dwform.find('input[name=id]').val(),
sectok: $dwform.find('input[name=sectok]').val()
}
);
}