web - added padding to bottom of sidebar

also changed fixed-header z-index

concourse/concourse#3872

Signed-off-by: James Thomson <jthomson@pivotal.io>

web/assets/css/layout.less

@@ -15,7 +15,6 @@ body,
 @pagination-header-height: 64px;
 
 @user-menu-z-index: 100;
-@fixed-header-z-index: @user-menu-z-index - 1;
 
 .content-frame {
   display: flex;
@@ -33,7 +32,7 @@ body,
 
 .with-fixed-header {
   .fixed-header {
-    z-index: @fixed-header-z-index;
+    z-index: 0;
     background: @base01;
   }
 

web/elm/src/SideBar/Styles.elm

@@ -38,6 +38,7 @@ sideBar =
     , style "flex-shrink" "0"
     , style "padding-right" "10px"
     , style "box-sizing" "border-box"
+    , style "padding-bottom" "10px"
     ]
 
 

web/elm/tests/SideBarFeature.elm

@@ -234,6 +234,10 @@ hasSideBar iAmLookingAtThePage =
             given iHaveAnOpenSideBar_
                 >> when iAmLookingAtTheSideBar
                 >> then_ iSeeItHasRightPadding
+        , test "sidebar has bottom padding" <|
+            given iHaveAnOpenSideBar_
+                >> when iAmLookingAtTheSideBar
+                >> then_ iSeeItHasBottomPadding
         , test "toggles away" <|
             given iHaveAnOpenSideBar_
                 >> given iClickedTheHamburgerIcon
@@ -966,6 +970,10 @@ iSeeItHasRightPadding =
     Query.has [ style "padding-right" "10px" ]
 
 
+iSeeItHasBottomPadding =
+    Query.has [ style "padding-bottom" "10px" ]
+
+
 iClickedThePipelineGroup =
     Tuple.first
         >> Application.update