opensourcemirror
/
concourse
mirror of https://github.com/concourse/concourse.git
1
0
Fork 0
Code Issues Releases Wiki Activity

chore: unnecessary use of fmt.Sprintf or fmt.Sprint 

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
This commit is contained in:
guoguangwu 2023-07-06 16:10:49 +08:00
parent ff74e1a97c
commit 11bfe400a9
9 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
atc/db/check_factory_test.go
View File

@ -489,7 +489,7 @@ var _ = Describe("CheckFactory", func() {
})
Context("when a put-only resource", func() {
Context(fmt.Sprintf("has failed to check last time"), func() {
Context("has failed to check last time", func() {
BeforeEach(func() {
found, err := putOnlyResourceConfigScope.UpdateLastCheckStartTime(99, nil)
Expect(err).NotTo(HaveOccurred())

2
fly/integration/clear_versions_test.go
View File

@ -295,7 +295,7 @@ and the following resource types:
})
It("errors", func() {
Eventually(sess.Err).Should(gbytes.Say(fmt.Sprintf("can specify only one of --resource or --resource-type\n")))
Eventually(sess.Err).Should(gbytes.Say("can specify only one of --resource or --resource-type\n"))
Expect(sess.ExitCode()).ToNot(Equal(0))
})
})

2
fly/integration/disable_resource_version_test.go
View File

@ -129,7 +129,7 @@ var _ = Describe("Fly CLI", func() {
sess, err := gexec.Start(flyCmd, GinkgoWriter, GinkgoWriter)
Expect(err).NotTo(HaveOccurred())
Eventually(sess.Err).Should(gbytes.Say(fmt.Sprintf("could not find version matching {\"some\":\"value\"}\n")))
Eventually(sess.Err).Should(gbytes.Say("could not find version matching {\"some\":\"value\"}\n"))
<-sess.Exited
Expect(sess.ExitCode()).To(Equal(1))

2
fly/integration/enable_resource_version_test.go
View File

@ -128,7 +128,7 @@ var _ = Describe("Fly CLI", func() {
sess, err := gexec.Start(flyCmd, GinkgoWriter, GinkgoWriter)
Expect(err).NotTo(HaveOccurred())
Eventually(sess.Err).Should(gbytes.Say(fmt.Sprintf("could not find version matching {\"some\":\"value\"}\n")))
Eventually(sess.Err).Should(gbytes.Say("could not find version matching {\"some\":\"value\"}\n"))
<-sess.Exited
Expect(sess.ExitCode()).To(Equal(1))

6
fly/integration/pin_resource_test.go
View File

@ -128,7 +128,7 @@ var _ = Describe("Fly CLI", func() {
sess, err := gexec.Start(flyCmd, GinkgoWriter, GinkgoWriter)
Expect(err).NotTo(HaveOccurred())
Eventually(sess.Err).Should(gbytes.Say(fmt.Sprintf("could not find version matching {\"some\":\"value\"}\n")))
Eventually(sess.Err).Should(gbytes.Say("could not find version matching {\"some\":\"value\"}\n"))
<-sess.Exited
Expect(sess.ExitCode()).To(Equal(1))
@ -188,7 +188,7 @@ var _ = Describe("Fly CLI", func() {
})
It("saves the pin comment", func() {
Eventually(sess.Out).Should(gbytes.Say(fmt.Sprintf("pin comment 'some pin message' is saved\n")))
Eventually(sess.Out).Should(gbytes.Say("pin comment 'some pin message' is saved\n"))
<-sess.Exited
Expect(sess.ExitCode()).To(Equal(0))
})
@ -202,7 +202,7 @@ var _ = Describe("Fly CLI", func() {
})
It("errors", func() {
Eventually(sess.Err).Should(gbytes.Say(fmt.Sprintf("could not find version matching")))
Eventually(sess.Err).Should(gbytes.Say("could not find version matching"))
<-sess.Exited
Expect(sess.ExitCode()).To(Equal(1))
})

5
go-concourse/concourse/builds_test.go
View File

@ -1,7 +1,6 @@
package concourse_test
import (
"fmt"
"net/http"
"github.com/concourse/concourse/atc"
@ -403,7 +402,7 @@ var _ = Describe("ATC Handler Builds", func() {
Context("pagination data", func() {
Context("with a link header", func() {
BeforeEach(func() {
expectedURL = fmt.Sprint("/api/v1/builds")
expectedURL = "/api/v1/builds"
atcServer.AppendHandlers(
ghttp.CombineHandlers(
@ -428,7 +427,7 @@ var _ = Describe("ATC Handler Builds", func() {
Context("without a link header", func() {
BeforeEach(func() {
expectedURL = fmt.Sprint("/api/v1/builds")
expectedURL = "/api/v1/builds"
atcServer.AppendHandlers(
ghttp.CombineHandlers(

4
go-concourse/concourse/jobs_test.go
View File

@ -565,7 +565,7 @@ var _ = Describe("ATC Handler Jobs", func() {
Context("when job step exists", func() {
JustBeforeEach(func() {
expectedURL = fmt.Sprint("/api/v1/teams/some-team/pipelines/mypipeline/jobs/myjob/tasks/mystep/cache")
expectedURL = "/api/v1/teams/some-team/pipelines/mypipeline/jobs/myjob/tasks/mystep/cache"
atcServer.AppendHandlers(
ghttp.CombineHandlers(
ghttp.VerifyRequest(requestMethod, expectedURL, strings.Join(expectedQuery, "&")),
@ -608,7 +608,7 @@ var _ = Describe("ATC Handler Jobs", func() {
Context("when job step does not exist", func() {
BeforeEach(func() {
expectedURL = fmt.Sprint("/api/v1/teams/some-team/pipelines/mypipeline/jobs/myjob/tasks/my-nonexistent-step/cache")
expectedURL = "/api/v1/teams/some-team/pipelines/mypipeline/jobs/myjob/tasks/my-nonexistent-step/cache"
expectedQuery = append(expectedQuery, "cache_path=mycachepath")
atcServer.AppendHandlers(
ghttp.CombineHandlers(

13
go-concourse/concourse/pipelines_test.go
View File

@ -1,7 +1,6 @@
package concourse_test
import (
"fmt"
"net/http"
"strings"
@ -647,7 +646,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
},
}
expectedURL = fmt.Sprint("/api/v1/teams/some-team/pipelines/mypipeline/builds")
expectedURL = "/api/v1/teams/some-team/pipelines/mypipeline/builds"
expectedQuery = []string{"vars.branch=%22master%22"}
pipelineRef = atc.PipelineRef{Name: "mypipeline", InstanceVars: atc.InstanceVars{"branch": "master"}}
})
@ -675,7 +674,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
Context("when from is specified", func() {
BeforeEach(func() {
expectedQuery = append(expectedQuery, fmt.Sprint("from=24"))
expectedQuery = append(expectedQuery, "from=24")
})
It("calls to get all builds from that id", func() {
@ -687,7 +686,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
Context("and limit is specified", func() {
BeforeEach(func() {
expectedQuery = append(expectedQuery, fmt.Sprint("limit=5"))
expectedQuery = append(expectedQuery, "limit=5")
})
It("appends limit to the url", func() {
@ -701,7 +700,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
Context("when to is specified", func() {
BeforeEach(func() {
expectedQuery = append(expectedQuery, fmt.Sprint("to=26"))
expectedQuery = append(expectedQuery, "to=26")
})
It("calls to get all builds to that id", func() {
@ -713,7 +712,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
Context("and limit is specified", func() {
BeforeEach(func() {
expectedQuery = append(expectedQuery, fmt.Sprint("limit=15"))
expectedQuery = append(expectedQuery, "limit=15")
})
It("appends limit to the url", func() {
@ -727,7 +726,7 @@ var _ = Describe("ATC Handler Pipelines", func() {
Context("when from and to are both specified", func() {
BeforeEach(func() {
expectedQuery = append(expectedQuery, fmt.Sprint("to=26"), fmt.Sprint("from=24"))
expectedQuery = append(expectedQuery, "to=26", "from=24")
})
It("sends both from and to", func() {

2
topgun/both/volume_gc_test.go
View File

@ -158,7 +158,7 @@ var _ = Describe("Garbage-collecting volumes", func() {
Expect(err).ToNot(HaveOccurred())
if resourceCacheNum == 1 {
By(fmt.Sprintf("not expiring volume so long as its resource cache is there"))
By("not expiring volume so long as its resource cache is there")
Expect(volumeNum).To(Equal(1))
}