coreboot-mirror
/
coreboot
mirror of https://review.coreboot.org/coreboot.git
1
0
Fork 0
Code Issues Releases Wiki Activity

soc/amd/picasso/uart: move uart_inject_ssdt to common code 

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic033fc2817d44ff873f93a45e069c0e8aa0be99f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50780
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-02-16 01:34:55 +01:00 committed by Patrick Georgi
parent 0bc878db19
commit b1b0294e6f
4 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/block/include/amdblocks/uart.h
View File

@ -3,8 +3,10 @@
#ifndef AMD_BLOCK_UART_H
#define AMD_BLOCK_UART_H
#include <device/device.h>
#include <types.h>
uintptr_t get_uart_base(unsigned int idx); /* get MMIO base address of FCH UART */
void uart_inject_ssdt(const struct device *dev);
#endif /* AMD_BLOCK_UART_H */

2
src/soc/amd/common/block/uart/Makefile.inc
View File

@ -6,4 +6,6 @@ ifeq ($(CONFIG_DEBUG_SMI),y)
smm-$(CONFIG_AMD_SOC_CONSOLE_UART) += uart_console.c
endif
ramstage-$(CONFIG_HAVE_ACPI_TABLES) += uart_acpi.c
endif # CONFIG_SOC_AMD_COMMON_BLOCK_UART

15
src/soc/amd/common/block/uart/uart_acpi.c Normal file
View File

@ -0,0 +1,15 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpigen.h>
#include <amdblocks/uart.h>
#include <device/device.h>
/* This gets called for both enabled and disabled devices. */
void uart_inject_ssdt(const struct device *dev)
{
acpigen_write_scope(acpi_device_path(dev));
acpigen_write_STA(acpi_device_status(dev));
acpigen_pop_len(); /* Scope */
}

11
src/soc/amd/picasso/uart.c
View File

@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpigen.h>
#include <console/console.h>
#include <commonlib/helpers.h>
#include <device/device.h>
@ -103,16 +102,6 @@ static void uart_enable(struct device *dev)
}
}
/* This gets called for both enabled and disabled devices. */
static void uart_inject_ssdt(const struct device *dev)
{
acpigen_write_scope(acpi_device_path(dev));
acpigen_write_STA(acpi_device_status(dev));
acpigen_pop_len(); /* Scope */
}
struct device_operations picasso_uart_mmio_ops = {
.read_resources = noop_read_resources,
.set_resources = noop_set_resources,