From 71055c869990308509c2c431d1a733358ed53e53 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Fri, 9 Aug 2019 23:22:26 +0530 Subject: [PATCH 1/5] fix: typo within pushChunk --- lib/ChunkGroup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js index 336d21a04..bf17b95cb 100644 --- a/lib/ChunkGroup.js +++ b/lib/ChunkGroup.js @@ -174,7 +174,7 @@ class ChunkGroup { /** * add a chunk into ChunkGroup. Is pushed on or prepended * @param {Chunk} chunk chunk being pushed into ChunkGroupS - * @returns {boolean} returns true if chunk addition was ssuccesful. + * @returns {boolean} returns true if chunk addition was successful. */ pushChunk(chunk) { const oldIdx = this.chunks.indexOf(chunk); From e0089223a026b0ffe03ce71c6da629ad23c6bbbe Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Fri, 9 Aug 2019 23:23:49 +0530 Subject: [PATCH 2/5] fix: tweaks within replaceChunk --- lib/ChunkGroup.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js index bf17b95cb..57f95d1d5 100644 --- a/lib/ChunkGroup.js +++ b/lib/ChunkGroup.js @@ -187,8 +187,8 @@ class ChunkGroup { /** * @param {Chunk} oldChunk chunk to be replaced - * @param {Chunk} newChunk New chunkt that will be replaced - * @returns {boolean} rerturns true for + * @param {Chunk} newChunk New chunk that will be replaced with + * @returns {boolean} returns true if the replacement was successful */ replaceChunk(oldChunk, newChunk) { const oldIdx = this.chunks.indexOf(oldChunk); From 936a0dc24a4b75220f91aeee74cf857201f51ee9 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Fri, 9 Aug 2019 23:27:28 +0530 Subject: [PATCH 3/5] fix: grammar --- lib/ChunkGroup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js index 57f95d1d5..4a5996696 100644 --- a/lib/ChunkGroup.js +++ b/lib/ChunkGroup.js @@ -369,7 +369,7 @@ class ChunkGroup { /** * we need to iterate again over the children - * to remove this from the childs parents. + * to remove this from the child's parents. * This can not be done in the above loop * as it is not guaranteed that `this._parents` contains anything. */ From af8906df11821f9857a24a13c8e4666910ae51af Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Fri, 9 Aug 2019 23:36:23 +0530 Subject: [PATCH 4/5] fix: refactor correct spelling --- lib/ChunkGroup.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js index 4a5996696..6f0ad97ac 100644 --- a/lib/ChunkGroup.js +++ b/lib/ChunkGroup.js @@ -70,12 +70,12 @@ class ChunkGroup { this.chunks = []; /** @type {OriginRecord[]} */ this.origins = []; - /** Indicies in top-down order */ + /** Indices in top-down order */ /** @private @type {Map} */ - this._moduleIndicies = new Map(); - /** Indicies in bottom-up order */ + this._moduleIndices = new Map(); + /** Indices in bottom-up order */ /** @private @type {Map} */ - this._moduleIndicies2 = new Map(); + this._moduleIndices2 = new Map(); } /** @@ -460,7 +460,7 @@ class ChunkGroup { * @returns {void} */ setModuleIndex(module, index) { - this._moduleIndicies.set(module, index); + this._moduleIndices.set(module, index); } /** @@ -469,7 +469,7 @@ class ChunkGroup { * @returns {number} index */ getModuleIndex(module) { - return this._moduleIndicies.get(module); + return this._moduleIndices.get(module); } /** @@ -479,7 +479,7 @@ class ChunkGroup { * @returns {void} */ setModuleIndex2(module, index) { - this._moduleIndicies2.set(module, index); + this._moduleIndices2.set(module, index); } /** @@ -488,7 +488,7 @@ class ChunkGroup { * @returns {number} index */ getModuleIndex2(module) { - return this._moduleIndicies2.get(module); + return this._moduleIndices2.get(module); } checkConstraints() { From 72ee5a3579f15de277af590a30985c216d02d0fc Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 10 Aug 2019 13:57:56 +0530 Subject: [PATCH 5/5] fix: lint --- lib/Entrypoint.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Entrypoint.js b/lib/Entrypoint.js index c1389a4f7..d82158a49 100644 --- a/lib/Entrypoint.js +++ b/lib/Entrypoint.js @@ -52,8 +52,8 @@ class Entrypoint extends ChunkGroup { /** * @param {Chunk} oldChunk chunk to be replaced - * @param {Chunk} newChunk New chunkt that will be replaced - * @returns {boolean} rerturns true for + * @param {Chunk} newChunk New chunk that will be replaced with + * @returns {boolean} returns true if the replacement was successful */ replaceChunk(oldChunk, newChunk) { if (this.runtimeChunk === oldChunk) this.runtimeChunk = newChunk;