Merge pull request #9176 from webpack/bugfix/issue-9159

fix concatenated version of reexport dependency for sideEffects

lib/optimize/ConcatenatedModule.js

@@ -521,7 +521,7 @@ class ConcatenatedModule extends Module {
 							dep instanceof HarmonyExportImportedSpecifierDependency
 						) {
 							const exportName = dep.name;
-							const importName = dep.id;
+							const importName = dep._id;
 							const importedModule = dep._module;
 							if (exportName && importName) {
 								if (!reexportMap.has(exportName)) {
@@ -1390,12 +1390,12 @@ class HarmonyExportImportedSpecifierDependencyConcatenatedTemplate {
 
 	getExports(dep) {
 		const importModule = dep._module;
-		if (dep.id) {
+		if (dep._id) {
 			// export { named } from "module"
 			return [
 				{
 					name: dep.name,
-					id: dep.id,
+					id: dep._id,
 					module: importModule
 				}
 			];

test/cases/scope-hoisting/side-effects-9159/index.js

@@ -0,0 +1,5 @@
+it("should reexport from side-effect-free scope-hoisted module", () => {
+	const m = require("./reexport");
+	expect(m.value).toBe(42);
+	expect(m.ns.default).toBe(42);
+});

test/cases/scope-hoisting/side-effects-9159/package/index.js

@@ -0,0 +1,4 @@
+export { default as value } from "./module";
+
+import * as ns from "./module";
+export { ns };

test/cases/scope-hoisting/side-effects-9159/package/module.js

@@ -0,0 +1 @@
+export default 42;

test/cases/scope-hoisting/side-effects-9159/package/package.json

@@ -0,0 +1,3 @@
+{
+    "sideEffects": false
+}

test/cases/scope-hoisting/side-effects-9159/reexport.js

@@ -0,0 +1 @@
+export { value, ns } from "./package";