opensourcemirror
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Align 'Cannot find module' message with native NodeJS

This commit is contained in:
Oded Niv 2018-05-15 09:16:39 +03:00
parent c39c963978
commit 17fd4d8b48
19 changed files with 36 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/code-splitted-require.context-amd/README.md
View File

@ -259,7 +259,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}

2
examples/code-splitted-require.context/README.md
View File

@ -259,7 +259,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}

2
examples/code-splitting-harmony/README.md
View File

@ -248,7 +248,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
examples/code-splitting-native-import-context-filter/README.md
View File

@ -275,7 +275,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
examples/code-splitting-native-import-context/README.md
View File

@ -264,7 +264,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
examples/code-splitting-specify-chunk-name/README.md
View File

@ -256,7 +256,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
examples/hybrid-routing/README.md
View File

@ -153,7 +153,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
examples/mixed/README.md
View File

@ -357,7 +357,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}

2
examples/require.context/README.md
View File

@ -143,7 +143,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}

2
examples/web-worker/README.md
View File

@ -284,7 +284,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}

16
lib/ContextModule.js
View File

@ -330,7 +330,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -365,7 +365,7 @@ function webpackContext(req) {
function webpackContextResolve(req) {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -404,7 +404,7 @@ function webpackAsyncContextResolve(req) {
return Promise.resolve().then(function() {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -441,7 +441,7 @@ function webpackAsyncContextResolve(req) {
return Promise.resolve().then(function() {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -481,7 +481,7 @@ function webpackAsyncContextResolve(req) {
return ${promise}.then(function() {
var id = map[req];
if(!(id + 1)) { // check for number or string
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -540,7 +540,7 @@ function webpackAsyncContext(req) {
var ids = map[req];
if(!ids) {
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});
@ -559,7 +559,7 @@ module.exports = webpackAsyncContext;`;
getSourceForEmptyContext(id) {
return `function webpackEmptyContext(req) {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
}
@ -574,7 +574,7 @@ webpackEmptyContext.id = ${JSON.stringify(id)};`;
// Here Promise.resolve().then() is used instead of new Promise() to prevent
// uncaught exception popping up in devtools
return Promise.resolve().then(function() {
var e = new Error('Cannot find module "' + req + '".');
var e = new Error("Cannot find module '" + req + "'");
e.code = 'MODULE_NOT_FOUND';
throw e;
});

2
lib/RuntimeTemplate.js
View File

@ -44,7 +44,7 @@ module.exports = class RuntimeTemplate {
}
throwMissingModuleErrorFunction({ request }) {
const err = `Cannot find module "${request}"`;
const err = `Cannot find module '${request}'`;
return `function webpackMissingModule() { var e = new Error(${JSON.stringify(
err
)}); e.code = 'MODULE_NOT_FOUND'; throw e; }`;

4
lib/dependencies/WebpackMissingModule.js
View File

@ -10,11 +10,11 @@ exports.module = request =>
`!(function webpackMissingModule() { ${exports.moduleCode(request)} }())`;
exports.promise = request => {
const errorCode = toErrorCode(`Cannot find module "${request}"`);
const errorCode = toErrorCode(`Cannot find module '${request}'`);
return `Promise.reject(function webpackMissingModule() { ${errorCode} return e; }())`;
};
exports.moduleCode = request => {
const errorCode = toErrorCode(`Cannot find module "${request}"`);
const errorCode = toErrorCode(`Cannot find module '${request}'`);
return `${errorCode} throw e;`;
};

6
test/ExternalModule.unittest.js
View File

@ -171,7 +171,7 @@ describe("ExternalModule", () => {
// set up
const variableToCheck = "foo";
const request = "bar";
const expected = `if(typeof foo === 'undefined') {var e = new Error("Cannot find module \\"bar\\""); e.code = 'MODULE_NOT_FOUND'; throw e;}
const expected = `if(typeof foo === 'undefined') {var e = new Error("Cannot find module 'bar'"); e.code = 'MODULE_NOT_FOUND'; throw e;}
`;
// invoke
@ -207,7 +207,7 @@ describe("ExternalModule", () => {
// set up
const id = "someId";
const optional = true;
const expected = `if(typeof __WEBPACK_EXTERNAL_MODULE_someId__ === 'undefined') {var e = new Error("Cannot find module \\"some/request\\""); e.code = 'MODULE_NOT_FOUND'; throw e;}
const expected = `if(typeof __WEBPACK_EXTERNAL_MODULE_someId__ === 'undefined') {var e = new Error("Cannot find module 'some/request'"); e.code = 'MODULE_NOT_FOUND'; throw e;}
module.exports = __WEBPACK_EXTERNAL_MODULE_someId__;`;
// invoke
@ -239,7 +239,7 @@ module.exports = __WEBPACK_EXTERNAL_MODULE_someId__;`;
it("checks for the existence of the request setting it", () => {
// set up
const optional = true;
const expected = `if(typeof some/request === 'undefined') {var e = new Error("Cannot find module \\"some/request\\""); e.code = 'MODULE_NOT_FOUND'; throw e;}
const expected = `if(typeof some/request === 'undefined') {var e = new Error("Cannot find module 'some/request'"); e.code = 'MODULE_NOT_FOUND'; throw e;}
module.exports = some/request;`;
// invoke

6
test/WebpackMissingModule.unittest.js
View File

@ -8,7 +8,7 @@ describe("WebpackMissingModule", () => {
it("returns an error message based on given error message", () => {
const errorMessage = WebpackMissingModule.moduleCode("mock message");
expect(errorMessage).toBe(
'var e = new Error("Cannot find module \\"mock message\\""); e.code = \'MODULE_NOT_FOUND\'; throw e;'
"var e = new Error(\"Cannot find module 'mock message'\"); e.code = 'MODULE_NOT_FOUND'; throw e;"
);
});
});
@ -17,7 +17,7 @@ describe("WebpackMissingModule", () => {
it("returns an error message based on given error message", () => {
const errorMessage = WebpackMissingModule.promise("mock message");
expect(errorMessage).toBe(
'Promise.reject(function webpackMissingModule() { var e = new Error("Cannot find module \\"mock message\\""); e.code = \'MODULE_NOT_FOUND\'; return e; }())'
"Promise.reject(function webpackMissingModule() { var e = new Error(\"Cannot find module 'mock message'\"); e.code = 'MODULE_NOT_FOUND'; return e; }())"
);
});
});
@ -26,7 +26,7 @@ describe("WebpackMissingModule", () => {
it("returns an error message based on given error message", () => {
const errorMessage = WebpackMissingModule.module("mock message");
expect(errorMessage).toBe(
'!(function webpackMissingModule() { var e = new Error("Cannot find module \\"mock message\\""); e.code = \'MODULE_NOT_FOUND\'; throw e; }())'
"!(function webpackMissingModule() { var e = new Error(\"Cannot find module 'mock message'\"); e.code = 'MODULE_NOT_FOUND'; throw e; }())"
);
});
});

4
test/cases/parsing/issue-2641/index.js
View File

@ -11,7 +11,7 @@ it("should call error callback on missing module", function(done) {
require(['./file', './missingModule'], function(file){}, function(error) {
try {
expect(error).toBeInstanceOf(Error);
expect(error.message).toBe('Cannot find module "./missingModule"');
expect(error.message).toBe("Cannot find module './missingModule'");
done();
} catch(e) {
done(e);
@ -24,7 +24,7 @@ it("should call error callback on missing module in context", function(done) {
require(['./' + module], function(file){}, function(error) {
try {
expect(error).toBeInstanceOf(Error);
expect(error.message).toBe("Cannot find module \"./missingModule\".");
expect(error.message).toBe("Cannot find module './missingModule'");
done();
} catch(e) { done(e); }
});

4
test/cases/parsing/issue-758/index.js
View File

@ -13,7 +13,7 @@ it("should call error callback on missing module", function(done) {
require('./missingModule');
}, function(error) {
expect(error).toBeInstanceOf(Error);
expect(error.message).toBe('Cannot find module "./missingModule"');
expect(error.message).toBe("Cannot find module './missingModule'");
done();
});
});
@ -24,7 +24,7 @@ it("should call error callback on missing module in context", function(done) {
require('./' + module);
}, function(error) {
expect(error).toBeInstanceOf(Error);
expect(error.message).toBe("Cannot find module \"./missingModule\".");
expect(error.message).toBe("Cannot find module './missingModule'");
done();
});
})('missingModule');

6
test/configCases/context-exclusion/simple/index.js
View File

@ -9,9 +9,9 @@ it("should not exclude paths not matching the exclusion pattern", function() {
});
it("should exclude paths/files matching the exclusion pattern", function() {
expect(() => requireInContext("dont")).toThrowError(/Cannot find module ".\/dont"/);
expect(() => requireInContext("dont")).toThrowError(/Cannot find module '.\/dont'/);
expect(() => requireInContext("dont-check-here/file")).toThrowError(/Cannot find module ".\/dont-check-here\/file"/);
expect(() => requireInContext("dont-check-here/file")).toThrowError(/Cannot find module '.\/dont-check-here\/file'/);
expect(() => requireInContext("check-here/dont-check-here/file")).toThrowError(/Cannot find module ".\/check-here\/dont-check-here\/file"/);
expect(() => requireInContext("check-here/dont-check-here/file")).toThrowError(/Cannot find module '.\/check-here\/dont-check-here\/file'/);
});

4
test/configCases/errors/multi-entry-missing-module/index.js
View File

@ -2,9 +2,9 @@ it("Should use WebpackMissingModule when module is missing with multiple entry s
var fs = require("fs");
var path = require("path");
var source = fs.readFileSync(path.join(__dirname, "b.js"), "utf-8");
expect(source).toMatch("!(function webpackMissingModule() { var e = new Error(\"Cannot find module \\\"./intentionally-missing-module.js\\\"\"); e.code = 'MODULE_NOT_FOUND'; throw e; }());");
expect(source).toMatch("!(function webpackMissingModule() { var e = new Error(\"Cannot find module './intentionally-missing-module.js'\"); e.code = 'MODULE_NOT_FOUND'; throw e; }());");
expect(function() {
require("./intentionally-missing-module");
}).toThrowError("Cannot find module \"./intentionally-missing-module\"");
}).toThrowError("Cannot find module './intentionally-missing-module'");
});