Commit Graph

19163 Commits

Author SHA1 Message Date
Carson Sievert 4b5eb3ca51
Backport #33634 (#33649)
Dropdown: support `.dropdown-item` wrapped in `<li>` tags
2021-04-28 07:02:22 +03:00
Patrick H. Lauke d967553913
Remove aria-haspopup from dropdowns (#33624)
`aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA).
In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present.
This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01
2021-04-15 06:35:54 +03:00
Stefano Bartoletti 016f8fff11
fix typo in docs (#33562) 2021-04-06 17:55:29 +03:00
XhmikosR 67f873f41a Update devDependencies
* @babel/cli                    ^7.13.0  →  ^7.13.14
* @babel/core                   ^7.13.8  →  ^7.13.14
* @babel/preset-env             ^7.13.9  →  ^7.13.12
* @rollup/plugin-commonjs       ^17.1.0  →   ^18.0.0
* @rollup/plugin-node-resolve   ^11.2.0  →   ^11.2.1
* autoprefixer                  ^10.2.4  →   ^10.2.5
* clean-css-cli                 ^5.2.0  →    ^5.2.2
* eslint                        ^7.21.0  →   ^7.23.0
* eslint-plugin-unicorn         ^28.0.2  →   ^29.0.0
* globby                        ^11.0.2  →   ^11.0.3
* hugo-bin                      ^0.69.0  →   ^0.70.0
* karma                         ^6.1.1  →    ^6.3.2
* postcss                       ^8.2.6  →    ^8.2.9
* qunit                         ^2.14.0  →   ^2.14.1
* rollup                        ^2.40.0  →   ^2.44.0
* stylelint                     ^13.11.0  →  ^13.12.0

Also lock jQuery to v3.5.1 since 3.6.0 has a bug that affects at least our tests
2021-04-05 07:44:39 +03:00
XhmikosR a06c2b6706 BrowserStack: test on iPhone 12 (#33398) 2021-04-05 07:44:39 +03:00
XhmikosR b58ea4a42e README.md: use shields.io for the tests badge too (#33401) 2021-04-05 07:44:39 +03:00
XhmikosR 459cc246b9 Improve change-version.js (#33148)
* switch to async/await
* remove shelljs
* switch to globby; supports .gitignore out of the box
* don't write any files to the disk if they are indentical
* add two more cmd switches: --dry and --verbose
* strip leading "v" from version arguments so that we don't end up with duplicate `v`s
2021-04-05 07:44:39 +03:00
XhmikosR 90228a4743 Delete the unused build/ship.sh (#33326) 2021-04-05 07:44:39 +03:00
Mark Otto 51c8b91d91 Manually backport #33386 to v4 to properly document Sass default variables 2021-03-18 18:57:12 -07:00
Patrick H. Lauke e16b06929a
Manual backport of #32627 (#33165)
Carousel: use buttons, not links, for prev/next controls
2021-03-11 09:23:46 +02:00
XhmikosR 7365592fbe Update .bundlewatch.config.json 2021-03-10 22:38:38 -08:00
Mark Otto 40da702f80 Adjust feedback icon position and padding for select.form-control 2021-03-10 22:38:38 -08:00
XhmikosR a59d436518 Update devDependencies
* @babel/cli             ^7.12.16  →   ^7.13.0
* @babel/core            ^7.12.16  →   ^7.13.8
* @babel/preset-env      ^7.12.16  →   ^7.13.9
* eslint                  ^7.20.0  →   ^7.21.0
* eslint-config-xo        ^0.34.0  →   ^0.35.0
* eslint-plugin-unicorn   ^28.0.1  →   ^28.0.2
* hugo-bin                ^0.68.0  →   ^0.69.0
* linkinator              ^2.13.4  →   ^2.13.6
* lockfile-lint            ^4.3.7  →    ^4.6.2
* rollup                  ^2.39.0  →   ^2.40.0
* stylelint              ^13.10.0  →  ^13.11.0
2021-03-02 17:53:37 +02:00
XhmikosR cce467616f CodeQL: skip dependabot PRs too (#33130) 2021-03-02 17:53:37 +02:00
XhmikosR 58192b3cac Bundlewatch: stop ignoring dependabot branches (#33192) 2021-03-02 17:53:37 +02:00
XhmikosR cf70a58149 Rename _gh_pages to _site. (#33129) 2021-03-02 17:53:37 +02:00
XhmikosR 6692d1ed47 linkinator: replace `--silent` with `--verbosity` (#33100) 2021-03-02 17:53:37 +02:00
Nikon the Third 7ad0625b8d
Adjust `SAFE_URL_PATTERN` regex for use with `test` method. (#33153)
The `test` method on regexes does not behave like `match` on strings
for checks if the regex matches when the global modifier (g) is present.

Also adds a unit test on tooltips for sanitizing the same template twice.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-02 17:16:09 +02:00
XhmikosR 8ec32eec44
Update clean-css-cli to v5.2.0 (#33144)
* Update clean-css-cli to v5.2.0

* Enable clean-css's batch flag
2021-02-18 20:59:05 +02:00
XhmikosR c341721439 Partially backport #33045
Simplify karma.conf.js

`customLaunchers` does not seem to be needed.
2021-02-17 06:54:38 +02:00
XhmikosR 23a26e12ff Update devDependencies
* @babel/cli                   ^7.12.13  →  ^7.12.16
* @babel/core                  ^7.12.13  →  ^7.12.16
* @babel/preset-env            ^7.12.13  →  ^7.12.16
* @rollup/plugin-babel           ^5.2.3  →    ^5.3.0
* @rollup/plugin-node-resolve   ^11.1.1  →   ^11.2.0
* eslint                        ^7.19.0  →   ^7.20.0
* eslint-plugin-unicorn         ^27.0.0  →   ^28.0.1
* karma                          ^6.0.4  →    ^6.1.1
* postcss                        ^8.2.5  →    ^8.2.6
* rollup                        ^2.38.5  →   ^2.39.0
* stylelint                     ^13.9.0  →  ^13.10.0

Kept clean-css-cli to 4.x for the time being.
2021-02-17 06:54:38 +02:00
XhmikosR bb5b5891da Backport #32940
* Update the default value for $enable-deprecation-messages

As seen in the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss,
the `$enable-deprecation-messages` variable is set to `true` by default.
2021-02-17 06:54:38 +02:00
Patrick H. Lauke 210cb72872 Add a callout for the sanitizer in popovers and tooltips (#32272)
* Add a callout for the sanitizer in popovers and tooltips

* Add second reference to sanitizer in the options

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-17 06:54:38 +02:00
XhmikosR 6487ba72f5 vnu-jar.js: quote vnu path (#33016)
Should work now with folders with spaces
2021-02-17 06:54:38 +02:00
XhmikosR 9c264dbea5 CI: remove the cache fallback and shorten cache key (#33012) 2021-02-17 06:54:38 +02:00
XhmikosR 254de4cb42 CI: switch to the coverallsapp/github-action tag (#32919)
Unfortunately, they don't offer a `v1` tag
2021-02-17 06:54:38 +02:00
XhmikosR a824d09ecd change-version: remove vendor, add resources (#32917) 2021-02-17 06:54:38 +02:00
Wesley Haines 9722106781
Fix minor visual bug in FF caused by moz-focusring (v4) (#32821)
Avoid bug in Firefox where text appears "noisy" due to text-shadow applying to focused form fields.
2021-02-17 06:00:37 +02:00
Gaël Poupard 030af97fad
fix(forms): input-group and validation icons (#32968)
Fixes #30131

Issue mentions `form-control` but it impacts `.custom-select` — but not `textarea` since it has a qualifying type selector that increases its specificty.

So another way could be to set `select.custom-select` and `input.form-control`. Would there be any other tag concerned by those classes?

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-15 21:13:43 +02:00
XhmikosR 29674b8426
Simplify bugify.html (#33063)
* use `in` instead of `strings.Contains` since the latter is not documented
* use `cond`
2021-02-15 21:08:44 +02:00
XhmikosR ce8af15ad1
Update devDependencies (#32967)
* @babel/cli                  ^7.12.10  →  ^7.12.13
* @babel/core                 ^7.12.10  →  ^7.12.13
* @babel/preset-env           ^7.12.11  →  ^7.12.13
* @rollup/plugin-babel          ^5.2.2  →    ^5.2.3
* @rollup/plugin-commonjs      ^17.0.0  →   ^17.1.0
* @rollup/plugin-node-resolve  ^11.1.0  →   ^11.1.1
* autoprefixer                 ^10.2.3  →   ^10.2.4
* eslint                       ^7.18.0  →   ^7.19.0
* karma                         ^5.2.3  →    ^6.0.4
* karma-qunit                   ^4.1.1  →    ^4.1.2
* linkinator                    2.11.2  →   ^2.13.4
* postcss                       ^8.2.4  →    ^8.2.5
* rollup                       ^2.38.0  →   ^2.38.5
* vnu-jar                      20.6.30  →    21.2.5
2021-02-09 07:50:00 +02:00
pricop 72a9fb4624
_variables.scss: add missing newline before new section (#32868) 2021-02-08 17:19:46 +02:00
XhmikosR 2267193d8f Switch to jsDelivr for jQuery too. (#32918) 2021-01-28 23:26:39 +02:00
XhmikosR 17d8fba548
Update devDependencies (#32852)
Pin karma and linkinator due to failures
2021-01-27 18:37:18 +02:00
XhmikosR 6ffb0b48e4
Release v4.6.0. (#32726)
* Bump version to v4.6.0.

* Dist
2021-01-19 18:16:38 +02:00
XhmikosR 9d87bd7a30
Backport #32037 (#32833)
* Backport #32037

Add `.navbar-nav-scroll` for vertical scrolling of navbar content

* drop the css var for a Sass css

Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-01-19 08:18:19 +02:00
Mark Otto 9c4abcc6a1
Backport #32759 (#32832)
Mention CSP and embedded SVGs in v4 docs
2021-01-19 07:22:27 +02:00
XhmikosR d2477abecd
Backport #32760 (#32827)
Add a live toast example to the docs
2021-01-18 20:59:59 +02:00
voltaek ee282aff27
Docs: Sass implementation and rounding precision (#32791)
* Backport of changes to v5 docs that updated and clarified information about the Sass compiler used and the minimum rounding precision we recommend with it.

Co-authored-by: Mark Otto <otto@github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-17 20:59:11 +02:00
Mark Otto 87e42ce7c5 Lighten disabled dropdown text to $gray-500
Fixes #32474
2021-01-15 09:22:27 +02:00
XhmikosR 5a17956e5e Backport #32469 and #32799
Improve zip-examples.js by only including the assets we need
2021-01-15 09:22:27 +02:00
Mark Otto 05a108b3d5 Document some basic code conventions for us (#32778)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-15 09:22:27 +02:00
XhmikosR ec1d745c10 CI: change Node.js to `14` (#32796)
This is so that it's consistent with the JS workflow thus the cache should match.
2021-01-15 09:22:27 +02:00
Mark Otto d674c33a04
Backport #32795 (#32809)
* Clarify Sass import and customize docs for how to modify variable defaults

* Add an npm starter project callout to a few pages
2021-01-15 09:16:32 +02:00
Patrick H. Lauke 80aefd862c
Remove role="button" from CTA links in carousel example (#32789)
They're links, acting as links. Just because they're styled as buttons visually (as is often the case for "Call to action" (CTA) links) doesn't mean they need/get `role="button"`
2021-01-14 12:19:19 +02:00
XhmikosR 2ed7504783 Update devDependencies 2021-01-13 11:03:32 +02:00
XhmikosR aeccf0e270 Stylelint: disallow some property values (#32756)
* `border: none`
* `outline: none`
2021-01-13 11:03:32 +02:00
Mark Otto 17521ed43a Mention stretched-link constraints with table elements (#32761)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 11:03:32 +02:00
XhmikosR da458176f3 GitHub Actions cleanup (#32755)
* lowercase `runner.os`
* remove `CI` environment variable since it's already set by the runner
2021-01-13 11:03:32 +02:00
Patrick H. Lauke 67c2f2c965 Darken dropdown item hover style
Backport of https://github.com/twbs/bootstrap/pull/32754
2021-01-13 11:03:32 +02:00