From b4287a2e986f409044baf2ce9965f20cff3a7986 Mon Sep 17 00:00:00 2001
From: lllusion3418 <lllusion3418@gmail.com>
Date: Thu, 12 Mar 2020 11:08:24 +0100
Subject: [PATCH 1/3] fix url rewriting for videos with poster and src

if a poster attribute was present only that would have been rewritten
and the (arguably more important) src attribute would be left as-is
---
 classes/diskcache.php | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/classes/diskcache.php b/classes/diskcache.php
index 7e4a8335d..ad775ac11 100644
--- a/classes/diskcache.php
+++ b/classes/diskcache.php
@@ -95,24 +95,21 @@ class DiskCache {
 
 			foreach ($entries as $entry) {
 
-				if ($entry->hasAttribute('src') || $entry->hasAttribute('poster')) {
+				foreach (array('src', 'poster') as $attr) {
+					if ($entry->hasAttribute($attr)) {
+						// should be already absolutized because this is called after sanitize()
+						$src = $entry->getAttribute($attr);
+						$cached_filename = sha1($src);
 
-					// should be already absolutized because this is called after sanitize()
-					$src = $entry->hasAttribute('poster') ? $entry->getAttribute('poster') : $entry->getAttribute('src');
-					$cached_filename = sha1($src);
+						if ($cache->exists($cached_filename)) {
 
-					if ($cache->exists($cached_filename)) {
+							$src = $cache->getUrl(sha1($src));
 
-						$src = $cache->getUrl(sha1($src));
-
-						if ($entry->hasAttribute('poster'))
-							$entry->setAttribute('poster', $src);
-						else {
-							$entry->setAttribute('src', $src);
+							$entry->setAttribute($attr, $src);
 							$entry->removeAttribute("srcset");
-						}
 
-						$need_saving = true;
+							$need_saving = true;
+						}
 					}
 				}
 			}

From cdde23b4dc948bdc2af659802ec1f53e351d7dae Mon Sep 17 00:00:00 2001
From: lllusion3418 <lllusion3418@gmail.com>
Date: Thu, 12 Mar 2020 11:08:33 +0100
Subject: [PATCH 2/3] actually download <video> posters to media cache

video[@poster] is already supported in the rewriting logic but never
actually downloaded
---
 classes/rssutils.php | 38 ++++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/classes/rssutils.php b/classes/rssutils.php
index 87e194603..be79dc27b 100755
--- a/classes/rssutils.php
+++ b/classes/rssutils.php
@@ -1229,33 +1229,35 @@ class RSSUtils {
 			if ($doc->loadHTML($html)) {
 				$xpath = new DOMXPath($doc);
 
-				$entries = $xpath->query('(//img[@src])|(//video/source[@src])|(//audio/source[@src])');
+				$entries = $xpath->query('(//img[@src])|(//video/source[@src])|(//audio/source[@src])|(//video[@poster])');
 
 				foreach ($entries as $entry) {
-					if ($entry->hasAttribute('src') && strpos($entry->getAttribute('src'), "data:") !== 0) {
-						$src = rewrite_relative_url($site_url, $entry->getAttribute('src'));
+					foreach (array('src', 'poster') as $attr) {
+						if ($entry->hasAttribute($attr) && strpos($entry->getAttribute($attr), "data:") !== 0) {
+							$src = rewrite_relative_url($site_url, $entry->getAttribute($attr));
 
-						$local_filename = sha1($src);
+							$local_filename = sha1($src);
 
-						Debug::log("cache_media: checking $src", Debug::$LOG_VERBOSE);
+							Debug::log("cache_media: checking $src", Debug::$LOG_VERBOSE);
 
-						if (!$cache->exists($local_filename)) {
-							Debug::log("cache_media: downloading: $src to $local_filename", Debug::$LOG_VERBOSE);
+							if (!$cache->exists($local_filename)) {
+								Debug::log("cache_media: downloading: $src to $local_filename", Debug::$LOG_VERBOSE);
 
-							global $fetch_last_error_code;
-							global $fetch_last_error;
+								global $fetch_last_error_code;
+								global $fetch_last_error;
 
-							$file_content = fetch_file_contents(array("url" => $src,
-								"http_referrer" => $src,
-								"max_size" => MAX_CACHE_FILE_SIZE));
+								$file_content = fetch_file_contents(array("url" => $src,
+									"http_referrer" => $src,
+									"max_size" => MAX_CACHE_FILE_SIZE));
 
-							if ($file_content) {
-								$cache->put($local_filename, $file_content);
-							} else {
-								Debug::log("cache_media: failed with $fetch_last_error_code: $fetch_last_error");
+								if ($file_content) {
+									$cache->put($local_filename, $file_content);
+								} else {
+									Debug::log("cache_media: failed with $fetch_last_error_code: $fetch_last_error");
+								}
+							} else if ($cache->isWritable($local_filename)) {
+								$cache->touch($local_filename);
 							}
-						} else if ($cache->isWritable($local_filename)) {
-							$cache->touch($local_filename);
 						}
 					}
 				}

From ec1b0befc7664683ca0a7df48e65b16b72058cd1 Mon Sep 17 00:00:00 2001
From: lllusion3418 <lllusion3418@gmail.com>
Date: Thu, 12 Mar 2020 11:08:39 +0100
Subject: [PATCH 3/3] add support for video[@src] in media cache

it's a valid alternative to a source[@src] child element:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
---
 classes/diskcache.php | 2 +-
 classes/rssutils.php  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/diskcache.php b/classes/diskcache.php
index ad775ac11..ba6aef858 100644
--- a/classes/diskcache.php
+++ b/classes/diskcache.php
@@ -89,7 +89,7 @@ class DiskCache {
 			$xpath = new DOMXPath($doc);
 			$cache = new DiskCache("images");
 
-			$entries = $xpath->query('(//img[@src]|//picture/source[@src]|//video[@poster]|//video/source[@src]|//audio/source[@src])');
+			$entries = $xpath->query('(//img[@src]|//picture/source[@src]|//video[@poster]|//video[@src]|//video/source[@src]|//audio/source[@src])');
 
 			$need_saving = false;
 
diff --git a/classes/rssutils.php b/classes/rssutils.php
index be79dc27b..68523ba8a 100755
--- a/classes/rssutils.php
+++ b/classes/rssutils.php
@@ -1229,7 +1229,7 @@ class RSSUtils {
 			if ($doc->loadHTML($html)) {
 				$xpath = new DOMXPath($doc);
 
-				$entries = $xpath->query('(//img[@src])|(//video/source[@src])|(//audio/source[@src])|(//video[@poster])');
+				$entries = $xpath->query('(//img[@src])|(//video/source[@src])|(//audio/source[@src])|(//video[@poster])|(//video[@src])');
 
 				foreach ($entries as $entry) {
 					foreach (array('src', 'poster') as $attr) {