Commit Graph

3635 Commits

Author SHA1 Message Date
Dirk Wetter 30c0359bdd
Merge pull request #2471 from Tazmaniac/mongodb-detection-fix-backport
MongoDB identification fix
2024-02-13 18:42:33 +01:00
Emmanuel Fusté c98c780ded MongoDB identification fix
The actual code grep for "MongoDB" keyword in the head of the HTTP
session.
In case of "compressed" HTML, a big page is on one line.
On a IT page, we could encounter the "MongoDB" keyword and
miss-identify the application protocol.

Fixed by matching on a longuer string taken from a live MogoDB
server.
2024-02-13 17:48:40 +01:00
Dirk Wetter 208efdc68a
Merge pull request #2452 from drwetter/update_hashes_3.0
Update hashes for HPKP
2023-12-24 15:33:28 +01:00
Dirk 0de86283e9 Update hashes for HPKP 2023-12-24 13:57:48 +01:00
Dirk Wetter 0de609da8c
Merge pull request #2451 from drwetter/fix_stupid_umaskerror_3.0
Bail out if user error bc of umask (3.0 branch)
2023-12-24 11:12:29 +01:00
Dirk Wetter 02220d2fc4 Bail out if user error bc of umask (3.0 branch)
Implemnation for 3.0, 3.2 see #2450

If a user chose a broken umask testssl.sh will start but emits subsequent errors.
This patch adds two sanity checks whether it is allowed to create and read files in the temp directory.

Fixes #2449
2023-12-24 10:21:11 +01:00
Dirk Wetter 68dec54cc5
Merge pull request #2435 from drwetter/fix_2431_grepProb
Amend fix for newer grep versions
2023-10-30 20:29:59 +01:00
Dirk a0c0c73b66 Amend fix for newer grep versions
See also PR #2243, issue #2241

Removes unneeded escape for exclamation mark. This is for 3.0.
3.2 has the fix already.
2023-10-30 19:07:06 +01:00
Dirk Wetter 40c6be790b
Merge pull request #2434 from drwetter/fix_2429_3.0
Fix weird bash globbing (3.0)
2023-10-30 17:53:19 +01:00
Dirk 41c697f232 put the redirection in the right spot 2023-10-30 15:25:38 +01:00
Dirk 775ed60437 Fix weird bash globbing (3.0)
What was problematic was the error message when the certificate stores were missing. This fixes it by redirecting the error message to /dev/null so that if the sub function detects the missing file it returns with an error by the program and not by executing "basename"

As for 3.2 this is for the 3.0 branch.
2023-10-30 15:20:37 +01:00
Dirk Wetter 7df05511da
Merge pull request #2426 from drwetter/drwetter-patch-2
Sync GHCR with Dockerfile
2023-10-30 14:41:12 +01:00
Dirk Wetter 382c1530cb
Sync GHCR with Dockerfile 2023-10-13 17:38:09 +02:00
Dirk Wetter 3eb3994d39
Merge pull request #2421 from drwetter/alpine_3.18
Update Dockerfile to Alpine 3.18
2023-10-13 10:43:56 +02:00
Dirk Wetter cd6659c7ad
Update Dockerfile to Alpine 3.18
for an extension of life time:

https://endoflife.date/alpine
2023-10-12 09:59:25 +02:00
Dirk Wetter ece9447ac4
Merge pull request #2412 from drwetter/fix_extended_regexp3.0
Fix regexp in STARTTLS detection
2023-10-07 17:21:25 +02:00
Dirk c09e1587b7 fix spell errors 2023-10-07 15:15:04 +02:00
Dirk c31b9492ce Fix regexp in STARTTLS detection
see also #2411, kudo to Geert!
2023-10-07 15:06:36 +02:00
Dirk Wetter e9cd8c3afd
Merge pull request #2391 from Tazmaniac/Renego-backport-patch
Backport pull request #2360 to fix #2389
2023-09-08 19:20:38 +02:00
Tazmaniac eb006e4173
Backport pull request #2360 to fix #2389
Not exactly for the same reason, but we need SNI too for secure renego tests.
2023-09-08 16:31:38 +02:00
Dirk Wetter 5cb30aa510
Merge pull request #2342 from drwetter/openssl_link_docker_3.0
make openssl 1.1 available via /usr/bin/openssl
2023-03-20 14:29:14 +01:00
Dirk f65b81837c make openssl 1.1 available via /usr/bin/openssl 2023-03-20 14:19:35 +01:00
Dirk Wetter 4c54464ab8
Merge pull request #2341 from drwetter/fix_nss_dns_3.0
Modify Dockerfile.git also, amending #2340
2023-03-20 13:42:59 +01:00
Dirk Wetter bf88b8b443 Modify Dockerfile.git also, amending #2340 2023-03-19 22:57:58 +01:00
Dirk Wetter 6454f656db
Merge pull request #2340 from drwetter/fix_nss_dns_3.0
Add openssl, offer to query OCSP responder (3.0)
2023-03-19 22:52:33 +01:00
Dirk Wetter 8759ac61af Add openssl, offer to query OCSP responder
This PR includes two tweaks:

* it helps avoiding the bug querying OCSP responder #2329 by adding
  openssl. The openssl supplied has a mimor DNS lookup problem due
  to glibc / musl libc compatibilty issues
* by adding openssl also it helps a bit for some performance problems
  related to other projects, see #2314

Also the git binary is removed (#2315).

Thanks to @polarathene for the discussions
2023-03-19 22:41:17 +01:00
Dirk Wetter 30022ea697
Merge pull request #2339 from drwetter/CAstores_update_3.0
Update CA root stores
2023-03-19 22:27:36 +01:00
Dirk Wetter ad44f7d53e Update CA root stores 2023-03-18 22:57:52 +01:00
Dirk Wetter e9c0beb3f7
Merge pull request #2335 from drwetter/sanitize_fileout_3.0
Backport: Make sure control chars from HTTP header don't end up in …
2023-03-12 18:19:09 +01:00
Dirk Wetter 828af39053 Backporting Make sure control chars from HTTP header don't end up in html,csv,json
This is for 3.0. For 3.1dev, see #2332 .

This PR addresses the bug #2330 by implementing a function which removes control characters from the file output format html,csv,json in the output.
In every instance called there's a check before whether the string contains control chars, hoping it'll save a few milli seconds.

A tr function is used, omitting LF.
It doesn't filter the terminal output and the log file output, yet. It provides a function though which is not being called.
2023-03-12 17:40:02 +01:00
Dirk Wetter 34453664a1
Merge pull request #2334 from drwetter/drwetter-patch-5
Update .gitignore
2023-03-12 16:13:21 +01:00
Dirk Wetter d662b7bfec add .git dir
see https://github.com/codespell-project/actions-codespell/issues/56
2023-03-12 16:10:56 +01:00
Dirk Wetter 16450e3d4f add codespell corrections (aNULL) 2023-03-12 16:06:02 +01:00
Dirk Wetter d6c0b33736
Update .gitignore
sync with 3.1dev
2023-03-12 15:59:47 +01:00
Dirk Wetter b8bb3ef747
Merge pull request #2327 from drwetter/fix_mime-type-3.0
Fix Accept Header (3.0)
2023-02-20 20:29:46 +01:00
Dirk 96a4eb99ad Fix Accept Header (3.0)
see #2325. This is for the 3.0 branch (for 3.1dev see #2326)

"whenever HTTP/1.1 is used then the Accept header uses "text/*" as a MIME type.
This causes some minor issues with some of the checks we are doing"
2023-02-20 15:14:34 +01:00
Dirk Wetter bd310489d1
Merge pull request #2322 from dcooper16/30_no_grade
Remove set_grade_cap() from 3.0
2023-02-07 08:59:09 +01:00
David Cooper 404d40cf68
Remove set_grade_cap() from 3.0
Grading is a new feature in 3.1dev,, so set_grade_cap() is not defined in the 3.0 branch.

This commit removes the call to set_grade_cap() in certificate_info().
2023-02-06 06:40:22 -08:00
Dirk Wetter 3bacce4770
Merge pull request #2319 from SSLbrain/3.0
Feature request Trustcor certificate #2293 for 3.0
2023-02-05 19:21:15 +01:00
Sole f7acaa8272 Change exception for removed root certificates into easy edit multi-value regular expression for Organization name and making it clear that CA's are actively removed from 1+ root stores. 2023-02-05 03:22:24 +00:00
Dirk Wetter 4a2b258425
Merge pull request #2318 from dcooper16/fix_html_30
Fix HTML output in Bash 5.2 and newer
2023-02-04 09:24:07 +01:00
David Cooper 5c0b8314d0 Fix HTML output in Bash 5.2 and newer
As noted in #2304, the way that the '&' character is treated in the string part of a pattern substitution changed in Bash 5.2. As a result, the change that was made in #1481 to accommodate older versions of Bash (e.g., on MacOS) now causes testssl.sh to produce incorrect HTML output when run on Bash 5.2.

This commit encodes the '&' characters in the substitution strings in a way that produces correct results on multiple versions of Bash (3.2 on MacOS, 5.2 on Ubuntu 23.10, 5.0 on Ubuntu 20.04).
2023-02-03 14:31:08 -08:00
Dirk Wetter cd2eef30ea
Merge pull request #2307 from drwetter/upgrade_alpine_perf-fix-3.0
Upgrade Alpine version for both Dockerfiles (3.0)
2023-02-01 19:49:12 +01:00
Dirk Wetter cd66c90054 Upgrade Alpine version for both Dockerfiles (3.0)
... to improve/mitigate performance problems, see #2299. (musl libc vs. glibc)

Same PR as for 3.1dev branch: #2306
2023-02-01 19:47:38 +01:00
Dirk Wetter d01ded1fd0
Merge pull request #2283 from drwetter/drwetter-patch-3
Reflect past update for Dockerfile (3.0) for ghcr
2022-11-28 17:09:37 +01:00
Dirk Wetter 801930736f
Reflect past update for Dockerfile (3.0) for ghcr
... using alpine 3.15
2022-11-28 14:13:56 +01:00
Dirk Wetter 6b91a60a7a
Merge pull request #2274 from dcooper16/fix2249
Fix #2249
2022-11-11 16:30:12 +01:00
Dirk Wetter 3261e6e7a9
Merge pull request #2273 from dcooper16/fix2271_30
Fix #2271
2022-11-11 16:28:48 +01:00
David Cooper 8593cbbb14
Fix #2249
OpenSSL uses "sha1WithRSAEncryption" to represent 1.2.840.113549.1.1.5 and "sha1WithRSA" to represent 1.3.14.3.2.29. While 1.2.840.113549.1.1.5 is generally recognized as the "standard" OID for RSA with SHA-1 (see, for example, RFC 3279), 1.3.14.3.2.29 has been used in some places as well (https://codereview.chromium.org/1223763002, https://bugzilla.mozilla.org/show_bug.cgi?id=1042479, pyca/cryptography#3160)
2022-11-10 11:37:58 -08:00
David Cooper f929e39db0
Fix #2271
This commit fixes #2271 by adding the `-no_ssl2` option to the call to get_host_cert() in run_drown(). There is at least one server that causes OpenSSL to hang if this call to get_host_cert() results in an SSLv2 ClientHello being sent. Since this call to get_host_cert() only needs to find the server's certificate in cases in which the server does not support SSLv2, there is no need to send an SSLv2 ClientHello.
2022-11-10 11:33:30 -08:00