opensourcemirror
/
redis
mirror of https://github.com/antirez/redis.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix unexpected resize causing test failure (#12960) 

Before #12850, we will only try to shrink the dict in serverCron,
which we can control by using a child process, but now every time
we delete a key, the shrink check will be called.

In these test (added in #12802), we meant to disable the resizing,
but druing the delete, the dict will meet the force shrink, like
2 / 128 = 0.015 < 0.2, the delete will trigger a force resize and
will cause the test to fail.

In this commit, we try to keep the load factor at 3 / 128 = 0.023,
that is, do not meet the force shrink.
This commit is contained in:
Binbin 2024-01-18 17:19:29 +08:00 committed by GitHub
parent 14b1edfd99
commit 29e6245a05
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/other.tcl
View File

@ -439,8 +439,8 @@ start_cluster 1 0 {tags {"other external:skip cluster slow"}} {
r config set rdb-key-save-delay 10000000
r bgsave
# delete data to have lot's (99%) of empty buckets
for {set j 1} {$j <= 127} {incr j} {
# delete data to have lot's (98%) of empty buckets
for {set j 1} {$j <= 125} {incr j} {
r del "{foo}$j"
}
assert_match "*table size: 128*" [r debug HTSTATS 0]
@ -470,7 +470,7 @@ start_cluster 1 0 {tags {"other external:skip cluster slow"}} {
r config set rdb-key-save-delay 10000000
r bgsave
for {set j 1} {$j <= 127} {incr j} {
for {set j 1} {$j <= 125} {incr j} {
r del "{alice}$j"
}