Tomas Vondra 41d2c6f952 Add missing index_insert_cleanup calls ... The optimization for inserts into BRIN indexes added by c1ec02be1d relies on a cache that needs to be explicitly released after calling index_insert(). The commit however failed to invoke the cleanup in validate_index(), which calls index_insert() indirectly through table_index_validate_scan(). After inspecting index_insert() callers, it seems unique_key_recheck() is missing the call too. Fixed by adding the two missing index_insert_cleanup() calls. The commit does two additional improvements. The aminsertcleanup() signature is modified to have the index as the first argument, to make it more like the other AM callbacks. And the aminsertcleanup() callback is invoked even if the ii_AmCache is NULL, so that it can decide if the cleanup is necessary. Author: Alvaro Herrera, Tomas Vondra Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/202401091043.e3nrqiad6gb7@alvherre.pgsql		2024-04-19 16:08:34 +02:00
..
src	Add missing index_insert_cleanup calls	2024-04-19 16:08:34 +02:00
KNOWN_BUGS	…
MISSING_FEATURES	…
Makefile	Remove distprep	2023-11-06 15:18:04 +01:00
TODO	…