Disable tests using injection points in installcheck

The 'gin' test injections faults to GIN index build. If another test
running concurrently in the same cluster also tries to create a GIN
index, it will hit the fault, too.

To fix, disable tests using injection points when running against an
existing cluster. A better long-term solution would be to make the
injection points scoped to the database or process, but this will do
for now.

Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8yamQ@mail.gmail.com
Discussion: https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi
This commit is contained in:
Heikki Linnakangas 2024-03-15 13:06:57 +02:00
parent 071e3ad59d
commit e2e3b8ae9e
4 changed files with 10 additions and 0 deletions

View File

@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
REGRESS = gin_incomplete_splits
# The injection points are cluster-wide, so disable installcheck
NO_INSTALLCHECK = 1
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)

View File

@ -12,5 +12,7 @@ tests += {
'sql': [
'gin_incomplete_splits',
],
# The injection points are cluster-wide, so disable installcheck
'runningcheck': false,
},
}

View File

@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
REGRESS = injection_points
# The injection points are cluster-wide, so disable installcheck
NO_INSTALLCHECK = 1
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)

View File

@ -33,5 +33,7 @@ tests += {
'sql': [
'injection_points',
],
# The injection points are cluster-wide, so disable installcheck
'runningcheck': false,
},
}