Plug hole in dike: planner would coredump if query_planner

returned NULL, which it will do in some cases where an elog(ERROR) would
probably be more appropriate.  For the moment, generate a not-very-
informative error message rather than proceeding to certain coredump.
Probably ought to think about making query_planner elog instead of
returning NULL, but this is at least a safe change for now.
This commit is contained in:
Tom Lane 1999-06-12 19:27:41 +00:00
parent 1918a1d191
commit acf242da97
1 changed files with 5 additions and 1 deletions

View File

@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.55 1999/06/06 17:38:10 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.56 1999/06/12 19:27:41 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -223,6 +223,10 @@ union_planner(Query *parse)
pfree(vpm);
}
/* query_planner returns NULL if it thinks plan is bogus */
if (! result_plan)
elog(ERROR, "union_planner: failed to create plan");
/*
* If we have a GROUP BY clause, insert a group node (with the
* appropriate sort node.)