opensourcemirror
/
postgresql
mirror of git://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove useless pg_strdup() operations. 

split_to_stringlist() doesn't modify its first argument nor expect it
to remain valid after exit, so there's no need to duplicate the optarg
string at the call sites.  Per Coverity.  (This has been wrong all along,
but commit 052cc223d changed the useless calls from "strdup" to
"pg_strdup", which apparently made Coverity think it's a new bug.
It's not, but it's also not worth back-patching.)
This commit is contained in:
Tom Lane 2016-09-04 12:33:58 -04:00
parent e21db14b8a
commit a2d75b67bc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/regress/pg_regress.c
View File

@ -2064,7 +2064,7 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc
* before we add the specified one.
*/
free_stringlist(&dblist);
split_to_stringlist(pg_strdup(optarg), ", ", &dblist);
split_to_stringlist(optarg, ", ", &dblist);
break;
case 2:
debug = true;
@ -2114,7 +2114,7 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc
dlpath = pg_strdup(optarg);
break;
case 18:
split_to_stringlist(pg_strdup(optarg), ", ", &extraroles);
split_to_stringlist(optarg, ", ", &extraroles);
break;
case 19:
add_stringlist_item(&temp_configs, optarg);