Use perl warnings pragma consistently

We've had a mixture of the warnings pragma, the -w switch on the shebang
line, and no warnings at all. This patch removes the -w swicth and add
the warnings pragma to all perl sources missing it. It raises the
severity of the TestingAndDebugging::RequireUseWarnings  perlcritic
policy to level 5, so that we catch any future violations.

Discussion: https://postgr.es/m/20200412074245.GB623763@rfd.leadboat.com
This commit is contained in:
Andrew Dunstan 2020-04-13 11:55:45 -04:00
parent 8930e43ecd
commit 7be5d8df1f
35 changed files with 59 additions and 10 deletions

View File

@ -1,6 +1,7 @@
#!/usr/bin/perl
use strict;
use warnings;
# make sure we are in a sane environment.
use DBI();

View File

@ -3,6 +3,8 @@
# contrib/intarray/bench/create_test.pl
use strict;
use warnings;
print <<EOT;
create table message (
mid int not null,

View File

@ -1,6 +1,7 @@
#!/usr/bin/perl
use strict;
use warnings;
my $integer = '[+-]?[0-9]+';
my $real = '[+-]?[0-9]+\.[0-9]+';

View File

@ -3,6 +3,7 @@
# this script will sort any table with the segment data type in its last column
use strict;
use warnings;
my @rows;

View File

@ -1,8 +1,9 @@
# /usr/bin/perl -w
# /usr/bin/perl
# doc/src/sgml/mk_feature_tables.pl
use strict;
use warnings;
my $yesno = $ARGV[0];

View File

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#----------------------------------------------------------------------
#
# genbki.pl

View File

@ -1,4 +1,4 @@
#! /usr/bin/perl -w
#! /usr/bin/perl
#-------------------------------------------------------------------------
#
# Gen_fmgrtab.pl

View File

@ -25,6 +25,8 @@
# # and Unicode name (not used in this script)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_BIG5.pl';

View File

@ -14,6 +14,8 @@
# and the "b" field is the hex byte sequence for GB18030
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_EUC_CN.pl';

View File

@ -8,6 +8,8 @@
# "euc-jis-2004-std.txt" (http://x0213.org)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl';

View File

@ -12,6 +12,8 @@
# organization's ftp site.
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl';

View File

@ -17,6 +17,8 @@
# # and Unicode name (not used in this script)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_EUC_KR.pl';

View File

@ -18,6 +18,8 @@
# # and Unicode name (not used in this script)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_EUC_TW.pl';

View File

@ -14,6 +14,8 @@
# and the "b" field is the hex byte sequence for GB18030
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_GB18030.pl';

View File

@ -16,6 +16,8 @@
# # and Unicode name (not used in this script)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl';

View File

@ -8,6 +8,8 @@
# "sjis-0213-2004-std.txt" (http://x0213.org)
use strict;
use warnings;
use convutils;
# first generate UTF-8 --> SHIFT_JIS_2004 table

View File

@ -11,6 +11,8 @@
# ftp site.
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_SJIS.pl';

View File

@ -14,6 +14,8 @@
# and the "b" field is the hex byte sequence for UHC
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_UHC.pl';

View File

@ -16,6 +16,8 @@
# # and Unicode name (not used in this script)
use strict;
use warnings;
use convutils;
my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_most.pl';

View File

@ -6,6 +6,7 @@
package convutils;
use strict;
use warnings;
use Carp;
use Exporter 'import';

View File

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#
# gen_qsort_tuple.pl
@ -26,6 +26,7 @@
#
use strict;
use warnings;
my $SUFFIX;
my $EXTRAARGS;

View File

@ -1,4 +1,4 @@
#! /usr/bin/perl -w
#! /usr/bin/perl
#################################################################
# create_help.pl -- converts SGML docs to internal psql help
@ -20,6 +20,7 @@
#
use strict;
use warnings;
my $docdir = $ARGV[0] or die "$0: missing required argument: docdir\n";
my $hfile = $ARGV[1] . '.h'

View File

@ -1,6 +1,7 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
use strict;
use warnings;
# use of SRCDIR/SUBDIR is required for supporting VPath builds
my $srcdir = $ENV{'SRCDIR'} or die 'SRCDIR environment variable is not set';

View File

@ -1,6 +1,7 @@
# src/pl/plperl/plc_perlboot.pl
use strict;
use warnings;
use 5.008001;
use vars qw(%_SHARED $_TD);

View File

@ -1,4 +1,4 @@
#!perl -w
#!perl
use strict;
use warnings;

View File

@ -1,6 +1,7 @@
#! /usr/bin/perl
use strict;
use warnings;
use locale;
open(my $in_fh, '<', $ARGV[0]) || die;

View File

@ -9,6 +9,7 @@
package SimpleTee;
use strict;
use warnings;
sub TIEHANDLE
{

View File

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#----------------------------------------------------------------------
#
# fix-old-flex-code.pl

View File

@ -3,6 +3,7 @@
# src/tools/msvc/build.pl
use strict;
use warnings;
use File::Basename;
use File::Spec;

View File

@ -3,6 +3,8 @@
# src/tools/msvc/pgbison.pl
use strict;
use warnings;
use File::Basename;
# assume we are in the postgres source root

View File

@ -3,6 +3,8 @@
# src/tools/msvc/pgflex.pl
use strict;
use warnings;
use File::Basename;
# silence flex bleatings about file path style

View File

@ -3,6 +3,7 @@
# src/tools/msvc/vcregress.pl
use strict;
use warnings;
our $config;

View File

@ -19,6 +19,10 @@ verbose = %f: %m at line %l, column %c. %e. ([%p] Severity: %s)\n
# allow octal constants with leading zeros
[-ValuesAndExpressions::ProhibitLeadingZeros]
# insist on use of the warnings pragma
[TestingAndDebugging::RequireUseWarnings]
severity = 5
# for now raise severity of this to level 5
[Subroutines::RequireFinalReturn]
severity = 5

View File

@ -1,4 +1,4 @@
#! /usr/bin/perl -w
#! /usr/bin/perl
#
# This script looks for symbols that are referenced in #ifdef or defined()
@ -21,6 +21,7 @@
#
use strict;
use warnings;
use Cwd;
use File::Basename;

View File

@ -1,4 +1,4 @@
#! /usr/bin/perl -w
#! /usr/bin/perl
#################################################################
# version_stamp.pl -- update version stamps throughout the source tree
@ -21,6 +21,7 @@
#
use strict;
use warnings;
# Major version is hard-wired into the script. We update it when we branch
# a new development version.