opensourcemirror
/
postgresql
mirror of git://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Handle EACCES errors from kevent() better. 

While registering for postmaster exit events, we have to handle a couple
of edge cases where the postmaster is already gone.  Commit 815c2f09
missed one: EACCES must surely imply that PostmasterPid no longer
belongs to our postmaster process (or alternatively an unexpected
permissions model has been imposed on us).  Like ESRCH, this should be
treated as a WL_POSTMASTER_DEATH event, rather than being raised with
ereport().

No known problems reported in the wild.  Per code review from Tom Lane.
Back-patch to 13.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/3624029.1602701929%40sss.pgh.pa.us
This commit is contained in:
Thomas Munro 2020-10-15 18:23:30 +13:00
parent d7eb52d718
commit 70516a178a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/storage/ipc/latch.c
View File

@ -1148,7 +1148,8 @@ WaitEventAdjustKqueue(WaitEventSet *set, WaitEvent *event, int old_events)
if (rc < 0)
{
if (event->events == WL_POSTMASTER_DEATH && errno == ESRCH)
if (event->events == WL_POSTMASTER_DEATH &&
(errno == ESRCH || errno == EACCES))
set->report_postmaster_not_running = true;
else
ereport(ERROR,