Follow the rule that regression-test-created roles are named "regress_xxx".

contrib/amcheck didn't get the memo either.
This commit is contained in:
Tom Lane 2019-06-25 23:06:17 -04:00
parent c360477d2e
commit 65e6d42140
2 changed files with 18 additions and 18 deletions

View File

@ -14,9 +14,9 @@ CREATE INDEX bttest_a_idx ON bttest_a USING btree (id);
CREATE INDEX bttest_b_idx ON bttest_b USING btree (id); CREATE INDEX bttest_b_idx ON bttest_b USING btree (id);
CREATE UNIQUE INDEX bttest_multi_idx ON bttest_multi CREATE UNIQUE INDEX bttest_multi_idx ON bttest_multi
USING btree (id) INCLUDE (data); USING btree (id) INCLUDE (data);
CREATE ROLE bttest_role; CREATE ROLE regress_bttest_role;
-- verify permissions are checked (error due to function not callable) -- verify permissions are checked (error due to function not callable)
SET ROLE bttest_role; SET ROLE regress_bttest_role;
SELECT bt_index_check('bttest_a_idx'::regclass); SELECT bt_index_check('bttest_a_idx'::regclass);
ERROR: permission denied for function bt_index_check ERROR: permission denied for function bt_index_check
SELECT bt_index_parent_check('bttest_a_idx'::regclass); SELECT bt_index_parent_check('bttest_a_idx'::regclass);
@ -25,11 +25,11 @@ RESET ROLE;
-- we, intentionally, don't check relation permissions - it's useful -- we, intentionally, don't check relation permissions - it's useful
-- to run this cluster-wide with a restricted account, and as tested -- to run this cluster-wide with a restricted account, and as tested
-- above explicit permission has to be granted for that. -- above explicit permission has to be granted for that.
GRANT EXECUTE ON FUNCTION bt_index_check(regclass) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_check(regclass) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_check(regclass, boolean) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_check(regclass, boolean) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass, boolean) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass, boolean) TO regress_bttest_role;
SET ROLE bttest_role; SET ROLE regress_bttest_role;
SELECT bt_index_check('bttest_a_idx'); SELECT bt_index_check('bttest_a_idx');
bt_index_check bt_index_check
---------------- ----------------
@ -166,5 +166,5 @@ DROP TABLE bttest_b;
DROP TABLE bttest_multi; DROP TABLE bttest_multi;
DROP TABLE delete_test_table; DROP TABLE delete_test_table;
DROP TABLE toast_bug; DROP TABLE toast_bug;
DROP OWNED BY bttest_role; -- permissions DROP OWNED BY regress_bttest_role; -- permissions
DROP ROLE bttest_role; DROP ROLE regress_bttest_role;

View File

@ -18,10 +18,10 @@ CREATE INDEX bttest_b_idx ON bttest_b USING btree (id);
CREATE UNIQUE INDEX bttest_multi_idx ON bttest_multi CREATE UNIQUE INDEX bttest_multi_idx ON bttest_multi
USING btree (id) INCLUDE (data); USING btree (id) INCLUDE (data);
CREATE ROLE bttest_role; CREATE ROLE regress_bttest_role;
-- verify permissions are checked (error due to function not callable) -- verify permissions are checked (error due to function not callable)
SET ROLE bttest_role; SET ROLE regress_bttest_role;
SELECT bt_index_check('bttest_a_idx'::regclass); SELECT bt_index_check('bttest_a_idx'::regclass);
SELECT bt_index_parent_check('bttest_a_idx'::regclass); SELECT bt_index_parent_check('bttest_a_idx'::regclass);
RESET ROLE; RESET ROLE;
@ -29,11 +29,11 @@ RESET ROLE;
-- we, intentionally, don't check relation permissions - it's useful -- we, intentionally, don't check relation permissions - it's useful
-- to run this cluster-wide with a restricted account, and as tested -- to run this cluster-wide with a restricted account, and as tested
-- above explicit permission has to be granted for that. -- above explicit permission has to be granted for that.
GRANT EXECUTE ON FUNCTION bt_index_check(regclass) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_check(regclass) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_check(regclass, boolean) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_check(regclass, boolean) TO regress_bttest_role;
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass, boolean) TO bttest_role; GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass, boolean) TO regress_bttest_role;
SET ROLE bttest_role; SET ROLE regress_bttest_role;
SELECT bt_index_check('bttest_a_idx'); SELECT bt_index_check('bttest_a_idx');
SELECT bt_index_parent_check('bttest_a_idx'); SELECT bt_index_parent_check('bttest_a_idx');
RESET ROLE; RESET ROLE;
@ -110,5 +110,5 @@ DROP TABLE bttest_b;
DROP TABLE bttest_multi; DROP TABLE bttest_multi;
DROP TABLE delete_test_table; DROP TABLE delete_test_table;
DROP TABLE toast_bug; DROP TABLE toast_bug;
DROP OWNED BY bttest_role; -- permissions DROP OWNED BY regress_bttest_role; -- permissions
DROP ROLE bttest_role; DROP ROLE regress_bttest_role;