Avoid edge case in pg_visibility test with small shared_buffers

Since 82a4edabd2 we can bulk extend relations. The bulk relation extension
logic has a heuristic component. Normally the heurstic does not trigger in the
occasionally-failing test case, as the relation is only extended once. But
with very small shared_buffers the limits for the number of buffers pinned at
once prevent the extension from happening at once. With the second "bulk"
extension, the heuristic kicks in, and the relation ends up one block bigger.
That's ok from a correctness perspective, but changes the results of the test
query due to one additional block.

We discussed a few more expansive fixes, but for now have decided to avoid
this by making the table a bit smaller.

Author: Heikki Linnakangas <hlinnaka@iki.fi>
Reported-by:
Discussion: https://postgr.es/m/29c74104-210b-ef39-2522-27a6aa7a704f@iki.fi
Discussion: https://postgr.es/m/20230916000011.2ugpkkkp7bpp4cfh@awork3.anarazel.de
Backpatch: 16-, where the new relation extension logic was added
This commit is contained in:
Andres Freund 2024-03-25 19:58:10 -07:00
parent 41d3780d3d
commit 3a4837fc80
2 changed files with 1 additions and 8 deletions

View File

@ -217,8 +217,7 @@ select * from pg_visibility_map('copyfreeze');
-------+-------------+------------
0 | t | t
1 | t | t
2 | t | t
(3 rows)
(2 rows)
select * from pg_check_frozen('copyfreeze');
t_ctid

View File

@ -108,12 +108,6 @@ copy copyfreeze from stdin freeze;
4 '4'
5 '5'
6 '6'
7 '7'
8 '8'
9 '9'
10 '10'
11 '11'
12 '12'
\.
commit;
select * from pg_visibility_map('copyfreeze');