2003-06-18 14:19:11 +02:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* clusterdb
|
|
|
|
*
|
2020-01-01 18:21:45 +01:00
|
|
|
* Portions Copyright (c) 2002-2020, PostgreSQL Global Development Group
|
2003-06-18 14:19:11 +02:00
|
|
|
*
|
2010-09-20 22:08:53 +02:00
|
|
|
* src/bin/scripts/clusterdb.c
|
2003-06-18 14:19:11 +02:00
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "postgres_fe.h"
|
|
|
|
#include "common.h"
|
2019-05-14 20:19:49 +02:00
|
|
|
#include "common/logging.h"
|
2019-12-04 02:06:45 +01:00
|
|
|
#include "fe_utils/cancel.h"
|
2016-03-24 20:55:44 +01:00
|
|
|
#include "fe_utils/simple_list.h"
|
2016-08-08 16:07:46 +02:00
|
|
|
#include "fe_utils/string_utils.h"
|
2003-06-18 14:19:11 +02:00
|
|
|
|
|
|
|
|
2008-11-24 09:46:04 +01:00
|
|
|
static void cluster_one_database(const char *dbname, bool verbose, const char *table,
|
2019-05-22 19:04:48 +02:00
|
|
|
const char *host, const char *port,
|
|
|
|
const char *username, enum trivalue prompt_password,
|
|
|
|
const char *progname, bool echo);
|
2011-12-06 14:48:15 +01:00
|
|
|
static void cluster_all_databases(bool verbose, const char *maintenance_db,
|
2019-05-22 19:04:48 +02:00
|
|
|
const char *host, const char *port,
|
|
|
|
const char *username, enum trivalue prompt_password,
|
|
|
|
const char *progname, bool echo, bool quiet);
|
2003-06-18 14:19:11 +02:00
|
|
|
|
|
|
|
static void help(const char *progname);
|
|
|
|
|
|
|
|
|
|
|
|
int
|
|
|
|
main(int argc, char *argv[])
|
|
|
|
{
|
|
|
|
static struct option long_options[] = {
|
|
|
|
{"host", required_argument, NULL, 'h'},
|
|
|
|
{"port", required_argument, NULL, 'p'},
|
|
|
|
{"username", required_argument, NULL, 'U'},
|
2009-02-26 17:02:39 +01:00
|
|
|
{"no-password", no_argument, NULL, 'w'},
|
2003-06-18 14:19:11 +02:00
|
|
|
{"password", no_argument, NULL, 'W'},
|
|
|
|
{"echo", no_argument, NULL, 'e'},
|
|
|
|
{"quiet", no_argument, NULL, 'q'},
|
|
|
|
{"dbname", required_argument, NULL, 'd'},
|
|
|
|
{"all", no_argument, NULL, 'a'},
|
|
|
|
{"table", required_argument, NULL, 't'},
|
2008-11-24 09:46:04 +01:00
|
|
|
{"verbose", no_argument, NULL, 'v'},
|
2011-12-06 14:48:15 +01:00
|
|
|
{"maintenance-db", required_argument, NULL, 2},
|
2003-06-18 14:19:11 +02:00
|
|
|
{NULL, 0, NULL, 0}
|
|
|
|
};
|
|
|
|
|
2004-05-12 15:38:49 +02:00
|
|
|
const char *progname;
|
2003-06-18 14:19:11 +02:00
|
|
|
int optindex;
|
|
|
|
int c;
|
|
|
|
|
|
|
|
const char *dbname = NULL;
|
2011-12-06 14:48:15 +01:00
|
|
|
const char *maintenance_db = NULL;
|
2003-06-18 14:19:11 +02:00
|
|
|
char *host = NULL;
|
|
|
|
char *port = NULL;
|
|
|
|
char *username = NULL;
|
2009-02-26 17:02:39 +01:00
|
|
|
enum trivalue prompt_password = TRI_DEFAULT;
|
2003-06-18 14:19:11 +02:00
|
|
|
bool echo = false;
|
|
|
|
bool quiet = false;
|
|
|
|
bool alldb = false;
|
2008-11-24 09:46:04 +01:00
|
|
|
bool verbose = false;
|
2013-01-17 11:24:47 +01:00
|
|
|
SimpleStringList tables = {NULL, NULL};
|
2003-06-18 14:19:11 +02:00
|
|
|
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_logging_init(argv[0]);
|
2003-06-18 14:19:11 +02:00
|
|
|
progname = get_progname(argv[0]);
|
2008-12-11 08:34:09 +01:00
|
|
|
set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pgscripts"));
|
2004-06-01 04:54:09 +02:00
|
|
|
|
2003-06-18 14:19:11 +02:00
|
|
|
handle_help_version_opts(argc, argv, "clusterdb", help);
|
|
|
|
|
2009-02-26 17:02:39 +01:00
|
|
|
while ((c = getopt_long(argc, argv, "h:p:U:wWeqd:at:v", long_options, &optindex)) != -1)
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
|
|
|
switch (c)
|
|
|
|
{
|
|
|
|
case 'h':
|
2012-10-12 19:35:40 +02:00
|
|
|
host = pg_strdup(optarg);
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
|
|
|
case 'p':
|
2012-10-12 19:35:40 +02:00
|
|
|
port = pg_strdup(optarg);
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
|
|
|
case 'U':
|
2012-10-12 19:35:40 +02:00
|
|
|
username = pg_strdup(optarg);
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
2009-02-26 17:02:39 +01:00
|
|
|
case 'w':
|
|
|
|
prompt_password = TRI_NO;
|
|
|
|
break;
|
2003-06-18 14:19:11 +02:00
|
|
|
case 'W':
|
2009-02-26 17:02:39 +01:00
|
|
|
prompt_password = TRI_YES;
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
|
|
|
case 'e':
|
|
|
|
echo = true;
|
|
|
|
break;
|
|
|
|
case 'q':
|
|
|
|
quiet = true;
|
|
|
|
break;
|
|
|
|
case 'd':
|
2012-10-12 19:35:40 +02:00
|
|
|
dbname = pg_strdup(optarg);
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
|
|
|
case 'a':
|
|
|
|
alldb = true;
|
|
|
|
break;
|
|
|
|
case 't':
|
2013-01-17 11:24:47 +01:00
|
|
|
simple_string_list_append(&tables, optarg);
|
2003-06-18 14:19:11 +02:00
|
|
|
break;
|
2008-11-24 09:46:04 +01:00
|
|
|
case 'v':
|
|
|
|
verbose = true;
|
|
|
|
break;
|
2011-12-06 14:48:15 +01:00
|
|
|
case 2:
|
2012-10-12 19:35:40 +02:00
|
|
|
maintenance_db = pg_strdup(optarg);
|
2011-12-06 14:48:15 +01:00
|
|
|
break;
|
2003-06-18 14:19:11 +02:00
|
|
|
default:
|
2003-07-23 10:47:41 +02:00
|
|
|
fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
|
2003-06-18 14:19:11 +02:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-06-10 21:20:04 +02:00
|
|
|
/*
|
|
|
|
* Non-option argument specifies database name as long as it wasn't
|
|
|
|
* already specified with -d / --dbname
|
2012-04-18 00:30:34 +02:00
|
|
|
*/
|
|
|
|
if (optind < argc && dbname == NULL)
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
2012-04-18 00:30:34 +02:00
|
|
|
dbname = argv[optind];
|
|
|
|
optind++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (optind < argc)
|
|
|
|
{
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_log_error("too many command-line arguments (first is \"%s\")",
|
|
|
|
argv[optind]);
|
2012-04-18 00:30:34 +02:00
|
|
|
fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
|
|
|
|
exit(1);
|
2003-06-18 14:19:11 +02:00
|
|
|
}
|
|
|
|
|
2019-12-02 03:18:56 +01:00
|
|
|
setup_cancel_handler(NULL);
|
2007-04-09 20:21:22 +02:00
|
|
|
|
2003-06-18 14:19:11 +02:00
|
|
|
if (alldb)
|
|
|
|
{
|
|
|
|
if (dbname)
|
|
|
|
{
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_log_error("cannot cluster all databases and a specific one at the same time");
|
2003-06-18 14:19:11 +02:00
|
|
|
exit(1);
|
|
|
|
}
|
2013-01-17 11:24:47 +01:00
|
|
|
|
|
|
|
if (tables.head != NULL)
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_log_error("cannot cluster specific table(s) in all databases");
|
2003-06-18 14:19:11 +02:00
|
|
|
exit(1);
|
|
|
|
}
|
2003-08-04 02:43:34 +02:00
|
|
|
|
2011-12-06 14:48:15 +01:00
|
|
|
cluster_all_databases(verbose, maintenance_db, host, port, username, prompt_password,
|
2003-06-18 14:19:11 +02:00
|
|
|
progname, echo, quiet);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
if (dbname == NULL)
|
|
|
|
{
|
|
|
|
if (getenv("PGDATABASE"))
|
|
|
|
dbname = getenv("PGDATABASE");
|
|
|
|
else if (getenv("PGUSER"))
|
|
|
|
dbname = getenv("PGUSER");
|
|
|
|
else
|
2013-12-18 18:16:16 +01:00
|
|
|
dbname = get_user_name_or_exit(progname);
|
2003-06-18 14:19:11 +02:00
|
|
|
}
|
|
|
|
|
2013-01-17 11:24:47 +01:00
|
|
|
if (tables.head != NULL)
|
|
|
|
{
|
|
|
|
SimpleStringListCell *cell;
|
|
|
|
|
|
|
|
for (cell = tables.head; cell; cell = cell->next)
|
|
|
|
{
|
|
|
|
cluster_one_database(dbname, verbose, cell->val,
|
|
|
|
host, port, username, prompt_password,
|
|
|
|
progname, echo);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
cluster_one_database(dbname, verbose, NULL,
|
|
|
|
host, port, username, prompt_password,
|
|
|
|
progname, echo);
|
2003-06-18 14:19:11 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
exit(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2004-01-01 20:27:15 +01:00
|
|
|
static void
|
2008-11-24 09:46:04 +01:00
|
|
|
cluster_one_database(const char *dbname, bool verbose, const char *table,
|
2004-01-01 20:27:15 +01:00
|
|
|
const char *host, const char *port,
|
2009-02-26 17:02:39 +01:00
|
|
|
const char *username, enum trivalue prompt_password,
|
2007-06-04 12:02:40 +02:00
|
|
|
const char *progname, bool echo)
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
|
|
|
PQExpBufferData sql;
|
|
|
|
|
|
|
|
PGconn *conn;
|
|
|
|
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
2018-02-26 16:39:44 +01:00
|
|
|
conn = connectDatabase(dbname, host, port, username, prompt_password,
|
|
|
|
progname, echo, false, false);
|
|
|
|
|
2003-06-18 14:19:11 +02:00
|
|
|
initPQExpBuffer(&sql);
|
|
|
|
|
2013-11-18 17:29:01 +01:00
|
|
|
appendPQExpBufferStr(&sql, "CLUSTER");
|
2008-11-24 09:46:04 +01:00
|
|
|
if (verbose)
|
2013-11-18 17:29:01 +01:00
|
|
|
appendPQExpBufferStr(&sql, " VERBOSE");
|
2003-06-18 14:19:11 +02:00
|
|
|
if (table)
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
2018-02-26 16:39:44 +01:00
|
|
|
{
|
|
|
|
appendPQExpBufferChar(&sql, ' ');
|
2019-07-19 02:31:58 +02:00
|
|
|
appendQualifiedRelation(&sql, table, conn, echo);
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
2018-02-26 16:39:44 +01:00
|
|
|
}
|
2015-07-02 11:32:48 +02:00
|
|
|
appendPQExpBufferChar(&sql, ';');
|
2003-06-18 14:19:11 +02:00
|
|
|
|
2007-04-09 20:21:22 +02:00
|
|
|
if (!executeMaintenanceCommand(conn, sql.data, echo))
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
|
|
|
if (table)
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_log_error("clustering of table \"%s\" in database \"%s\" failed: %s",
|
|
|
|
table, PQdb(conn), PQerrorMessage(conn));
|
2003-06-18 14:19:11 +02:00
|
|
|
else
|
Unified logging system for command-line programs
This unifies the various ad hoc logging (message printing, error
printing) systems used throughout the command-line programs.
Features:
- Program name is automatically prefixed.
- Message string does not end with newline. This removes a common
source of inconsistencies and omissions.
- Additionally, a final newline is automatically stripped, simplifying
use of PQerrorMessage() etc., another common source of mistakes.
- I converted error message strings to use %m where possible.
- As a result of the above several points, more translatable message
strings can be shared between different components and between
frontends and backend, without gratuitous punctuation or whitespace
differences.
- There is support for setting a "log level". This is not meant to be
user-facing, but can be used internally to implement debug or
verbose modes.
- Lazy argument evaluation, so no significant overhead if logging at
some level is disabled.
- Some color in the messages, similar to gcc and clang. Set
PG_COLOR=auto to try it out. Some colors are predefined, but can be
customized by setting PG_COLORS.
- Common files (common/, fe_utils/, etc.) can handle logging much more
simply by just using one API without worrying too much about the
context of the calling program, requiring callbacks, or having to
pass "progname" around everywhere.
- Some programs called setvbuf() to make sure that stderr is
unbuffered, even on Windows. But not all programs did that. This
is now done centrally.
Soft goals:
- Reduces vertical space use and visual complexity of error reporting
in the source code.
- Encourages more deliberate classification of messages. For example,
in some cases it wasn't clear without analyzing the surrounding code
whether a message was meant as an error or just an info.
- Concepts and terms are vaguely aligned with popular logging
frameworks such as log4j and Python logging.
This is all just about printing stuff out. Nothing affects program
flow (e.g., fatal exits). The uses are just too varied to do that.
Some existing code had wrappers that do some kind of print-and-exit,
and I adapted those.
I tried to keep the output mostly the same, but there is a lot of
historical baggage to unwind and special cases to consider, and I
might not always have succeeded. One significant change is that
pg_rewind used to write all error messages to stdout. That is now
changed to stderr.
Reviewed-by: Donald Dong <xdong@csumb.edu>
Reviewed-by: Arthur Zakirov <a.zakirov@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/flat/6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com
2019-04-01 14:24:37 +02:00
|
|
|
pg_log_error("clustering of database \"%s\" failed: %s",
|
|
|
|
PQdb(conn), PQerrorMessage(conn));
|
2003-06-18 14:19:11 +02:00
|
|
|
PQfinish(conn);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
PQfinish(conn);
|
|
|
|
termPQExpBuffer(&sql);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2004-01-01 20:27:15 +01:00
|
|
|
static void
|
2011-12-06 14:48:15 +01:00
|
|
|
cluster_all_databases(bool verbose, const char *maintenance_db,
|
|
|
|
const char *host, const char *port,
|
2009-02-26 17:02:39 +01:00
|
|
|
const char *username, enum trivalue prompt_password,
|
2003-08-04 02:43:34 +02:00
|
|
|
const char *progname, bool echo, bool quiet)
|
2003-06-18 14:19:11 +02:00
|
|
|
{
|
|
|
|
PGconn *conn;
|
|
|
|
PGresult *result;
|
2016-08-08 16:07:46 +02:00
|
|
|
PQExpBufferData connstr;
|
2003-06-18 14:19:11 +02:00
|
|
|
int i;
|
|
|
|
|
2011-12-06 14:48:15 +01:00
|
|
|
conn = connectMaintenanceDatabase(maintenance_db, host, port, username,
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
2018-02-26 16:39:44 +01:00
|
|
|
prompt_password, progname, echo);
|
2019-07-19 02:31:58 +02:00
|
|
|
result = executeQuery(conn, "SELECT datname FROM pg_database WHERE datallowconn ORDER BY 1;", echo);
|
2003-06-18 14:19:11 +02:00
|
|
|
PQfinish(conn);
|
|
|
|
|
2016-08-08 16:07:46 +02:00
|
|
|
initPQExpBuffer(&connstr);
|
2003-06-18 14:19:11 +02:00
|
|
|
for (i = 0; i < PQntuples(result); i++)
|
|
|
|
{
|
|
|
|
char *dbname = PQgetvalue(result, i, 0);
|
|
|
|
|
|
|
|
if (!quiet)
|
2007-06-04 12:02:40 +02:00
|
|
|
{
|
|
|
|
printf(_("%s: clustering database \"%s\"\n"), progname, dbname);
|
|
|
|
fflush(stdout);
|
|
|
|
}
|
2003-06-18 14:19:11 +02:00
|
|
|
|
2016-08-08 16:07:46 +02:00
|
|
|
resetPQExpBuffer(&connstr);
|
2019-07-04 03:01:13 +02:00
|
|
|
appendPQExpBufferStr(&connstr, "dbname=");
|
2016-08-08 16:07:46 +02:00
|
|
|
appendConnStrVal(&connstr, dbname);
|
|
|
|
|
|
|
|
cluster_one_database(connstr.data, verbose, NULL,
|
2009-02-26 17:02:39 +01:00
|
|
|
host, port, username, prompt_password,
|
2007-06-04 12:02:40 +02:00
|
|
|
progname, echo);
|
2003-06-18 14:19:11 +02:00
|
|
|
}
|
2016-08-08 16:07:46 +02:00
|
|
|
termPQExpBuffer(&connstr);
|
2003-06-18 14:19:11 +02:00
|
|
|
|
|
|
|
PQclear(result);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
help(const char *progname)
|
|
|
|
{
|
2003-07-23 10:47:41 +02:00
|
|
|
printf(_("%s clusters all previously clustered tables in a database.\n\n"), progname);
|
2003-06-18 14:19:11 +02:00
|
|
|
printf(_("Usage:\n"));
|
|
|
|
printf(_(" %s [OPTION]... [DBNAME]\n"), progname);
|
|
|
|
printf(_("\nOptions:\n"));
|
|
|
|
printf(_(" -a, --all cluster all databases\n"));
|
|
|
|
printf(_(" -d, --dbname=DBNAME database to cluster\n"));
|
|
|
|
printf(_(" -e, --echo show the commands being sent to the server\n"));
|
|
|
|
printf(_(" -q, --quiet don't write any messages\n"));
|
2013-01-17 11:24:47 +01:00
|
|
|
printf(_(" -t, --table=TABLE cluster specific table(s) only\n"));
|
2008-11-24 09:46:04 +01:00
|
|
|
printf(_(" -v, --verbose write a lot of output\n"));
|
2012-06-18 01:44:00 +02:00
|
|
|
printf(_(" -V, --version output version information, then exit\n"));
|
|
|
|
printf(_(" -?, --help show this help, then exit\n"));
|
2003-06-18 14:19:11 +02:00
|
|
|
printf(_("\nConnection options:\n"));
|
|
|
|
printf(_(" -h, --host=HOSTNAME database server host or socket directory\n"));
|
|
|
|
printf(_(" -p, --port=PORT database server port\n"));
|
|
|
|
printf(_(" -U, --username=USERNAME user name to connect as\n"));
|
2009-02-26 17:02:39 +01:00
|
|
|
printf(_(" -w, --no-password never prompt for password\n"));
|
2007-12-11 20:57:32 +01:00
|
|
|
printf(_(" -W, --password force password prompt\n"));
|
2011-12-06 14:48:15 +01:00
|
|
|
printf(_(" --maintenance-db=DBNAME alternate maintenance database\n"));
|
2003-06-18 14:19:11 +02:00
|
|
|
printf(_("\nRead the description of the SQL command CLUSTER for details.\n"));
|
2020-02-28 08:54:49 +01:00
|
|
|
printf(_("\nReport bugs to <%s>.\n"), PACKAGE_BUGREPORT);
|
2020-02-28 08:54:49 +01:00
|
|
|
printf(_("%s home page: <%s>\n"), PACKAGE_NAME, PACKAGE_URL);
|
2003-06-18 14:19:11 +02:00
|
|
|
}
|