Commit Graph

16663 Commits

Author SHA1 Message Date
Ryan Winter 81676259d3
misquelling of address in wireguard peer generator (#7398) 2024-04-19 19:43:51 +02:00
Ad Schellevis f0e62a3902 System: Trust: Authorities - missing return on "add" action, problem described in https://github.com/opnsense/core/issues/7390 2024-04-19 17:59:54 +02:00
Franco Fichtner 917cfdc2cb system: make log rotate action available to cron 2024-04-19 15:01:53 +02:00
Stephan de Wit be5ad0f5fc dashboard: memory widget: missing endpoint declaration and title change 2024-04-19 12:37:19 +02:00
Stephan de Wit a2e14b2b8c dashboard: memory widget
Also some minor performance improvements as suggested by https://www.chartjs.org/docs/latest/general/performance.html.

in contrast to the old dashboard memory calculation, this widget does not consider ARC to be part of used memory anymore.
2024-04-19 12:21:54 +02:00
Ad Schellevis 6d770f2751 mvc/bootgrid edit dialog - lock save button while in progress to prevent duplicate input. closes https://github.com/opnsense/core/issues/7390 2024-04-18 20:57:17 +02:00
Ad Schellevis 4b93d59fd1 System: Access: Users - change user certificate handling to align with the new MVC module.
Remove the previous link from the user to the certificate as this suggest some relation between the two that doesn't exist (other than the name).
In the userview, the certificate list contains all client certs with the same commonname and verifies if the logged in user is able to access the trust module to prevent data leakage.

closes https://github.com/opnsense/core/issues/7387
2024-04-17 21:40:06 +02:00
Ad Schellevis 8071c8700f VPN: OpenVPN: Connection Status - fix "attempt to read property...", closes https://github.com/opnsense/core/issues/7388 2024-04-17 20:32:59 +02:00
Ad Schellevis 80b65b0d5d Services: Kea DHCP [new]: Kea DHCPv4 - move json file generation to a plugin hook, process feedback from d241cfda90
(ref: https://github.com/opnsense/core/pull/7361)
2024-04-17 20:21:45 +02:00
Ad Schellevis 08ee9c0175 jquery-bootgrid - sync with https://github.com/opnsense/jquery-bootgrid/pull/7 2024-04-17 16:36:20 +02:00
Franco Fichtner 353c89f5c0 mvc: style update 2024-04-17 10:51:59 +02:00
Franco Fichtner 981ac3ddee system: whitespace nitpicking 2024-04-17 10:47:07 +02:00
Franco Fichtner dc80b7a019 src: style sweep 2024-04-17 07:23:02 +02:00
Ad Schellevis d241cfda90 Services: Kea DHCP [new]: Kea DHCPv4 - move json file generation to a plugin configure hook, keep empty templates to inform people.
(ref; https://github.com/opnsense/core/pull/7361)
2024-04-16 20:15:21 +02:00
Ad Schellevis 597b65a2e5 Services: Unbound DNS: Blocklist - change blocklist processing in _blocklist_reader()
When downloading files, throw errors and handle them in _blocklist_reader() so ew can decide to use the original cached one if still available. Move error handling to the same spot.

closes https://github.com/opnsense/core/issues/7371
2024-04-16 17:50:13 +02:00
Ad Schellevis b551927c89 Services: Kea DHCP [new]: Kea DHCPv4 - fix missing default domain in 29e87aa3e4
(ref; https://github.com/opnsense/core/pull/7361)
2024-04-16 12:31:07 +02:00
Ad Schellevis c4b64a417d mvc: further improve 10c81a4eea to allow sorting on descriptive values and unify usage in ModelRelationField, closes https://github.com/opnsense/core/issues/7383 2024-04-16 12:27:37 +02:00
Ad Schellevis fad8cfdf84 Services: ISC DHCPv4: Log File - fix location in ACL, closes https://github.com/opnsense/core/issues/7382 2024-04-16 08:46:35 +02:00
Franco Fichtner ac1d9d71f6 src: style updates 2024-04-16 08:04:16 +02:00
Ad Schellevis 29e87aa3e4 Services: Kea DHCP [new]: Kea DHCPv4 - generate json payload from model, work in progress for https://github.com/opnsense/core/pull/7361 2024-04-15 21:30:37 +02:00
Franco Fichtner 1afe0405bc unbound: missing a mute
PR: https://forum.opnsense.org/index.php?topic=39982.0
2024-04-15 09:59:04 +02:00
Franco Fichtner 1dc4e06693 firmware: avoid calculating + 0 in previous
fetch(1) appears to return "Unknown" when not being able to
get the size of the file from the mirror.  It's a bit odd
considering the code in question didn't change for years on
all ends and so far nobody reported a similar issue.

The calculation isn't strictly necessary as we try to fill
the gap between pkg integration and extra sets that should
be handled by pkg-base eventually.
2024-04-15 09:09:33 +02:00
Franco Fichtner 4390deb8c3 src: style sweep 2024-04-15 08:01:36 +02:00
Ad Schellevis 8f9ee84579 System: Firmware - check type before calculating, in some cases pkg seems to communicate "Unknown" if it doesn't know the size, which will break the output and prevents further updates via the gui.
Example output collected:
            {
                "name": "base",
                "size": "Unknown",
                "repository": "OPNsense",
                "current_version": "23.7.4",
                "new_version": "23.7.10"
            },
2024-04-12 15:43:50 +02:00
Stephan de Wit 5b33068833 dashboard: traffic graph: render graph on first data load
This is a bit of a chicken and egg situation, the streaming plugin
requires knowledge of the datasets (even if the actual datapoints
are empty) as soon as the chart is rendered, but the metadata is
only known after the first server response.
2024-04-11 14:50:29 +02:00
Stephan de Wit b9a8edfc79 dashboard: trigger initial resize after loading dynamic content 2024-04-11 11:34:50 +02:00
Stephan de Wit 257cd0696b dashboard: interfaces widget should be left-aligned in collapsed state 2024-04-11 11:11:56 +02:00
Stephan de Wit e9f2270ffd dashboard: traffic graph should be relatively positioned to prevent automatic height scaling, which subsequently cannot be adjusted anymore due to widget height constraints 2024-04-11 11:09:51 +02:00
Stephan de Wit 5a21f67030 dashboard: traffic widget 2024-04-11 10:04:29 +02:00
Ad Schellevis 354e964d70 filter: keep permissions to standard (644) for filter.lock file, closes https://github.com/opnsense/core/issues/7373 2024-04-11 09:32:04 +02:00
Ad Schellevis 1d49c82160 Firewall: Diagnostics: States - add gateway to the output so we can identify easier which states do have a next hop set.
Although it doesn't offer a cure for https://github.com/opnsense/core/issues/6803 , it should help making more explicit which states someone wants to kill in which scenario.
2024-04-10 10:08:58 +02:00
Ad Schellevis a86c0de203 Config - fix locking issue when already owning the lock [2], fix regression in ed1d8a6260
When not locked loadFromStream() will unlock the file, effectivly leaving us with an unlocked file (but marked as locked).
2024-04-09 19:51:35 +02:00
Ad Schellevis 231a4d48de VPN: WireGuard: Peer generator - Add "Address" field which auto calculates the next available address in the pool (defined by the instance) for both ipv4 and ipv6.
Extend Firewall/Util to iterate over a cidr range, so we can fetch the first available here.
The address fiels should be the "Allowed IPs" in the peer on this instance end. When using allowed IPs ::/0, 0.0.0.0/0 on both ends, the tunnel should work as well, but may people confuse about the routing part.

When the remote end sends traffic from addresses other than the ones configured on the tunnel, one needs to update the peer manually.
2024-04-09 19:26:14 +02:00
Michael 93e114db93
Update actions_wireguard.conf (#7369) 2024-04-09 16:45:52 +02:00
NOYB c6c823ea84
FW Live View - visible rows qty +1 caused by use of 0 offset (#7368) 2024-04-09 10:14:43 +02:00
Stephan de Wit 558f7f23c4 dashboard: interface statistics: sort legend and add missing integer parsing 2024-04-08 15:07:27 +02:00
Stephan de Wit 832f6f796d dashboard: interface statistics: format traffic counters 2024-04-08 14:24:41 +02:00
Stephan de Wit 70867a40fd dashboard: interface statistics widget 2024-04-08 11:56:50 +02:00
Ad Schellevis ceb51410ba Firewall: Rules: XXX - show automation rules in their own section as they are sorted in the same area as interface rules.
This is a side affect of 1c96851043 , which changed the rule priority to match the manual (legacy) rules.

closes https://github.com/opnsense/core/issues/7367
2024-04-08 11:24:46 +02:00
Ad Schellevis a8e329b905 VPN: WireGuard: Peers - unlink instance on delete 2024-04-07 12:57:03 +02:00
Ad Schellevis ed1d8a6260 Config - fix locking issue when already owning the lock.
In most cases we use config locking, the lock is acquired only once, in which case all works as expected.
When a controller fetches a lock and passes it on to one of the core controller wrappers which then re-acquires the same lock, the default is to load the config again.
Pending data in other models will be flushed in these cases, which is unexpected if we're updating the same config, but a different section.

This change only executes the reload when not yet locked by this process.
2024-04-07 12:56:20 +02:00
Ad Schellevis 3f5d7f0779 VPN: OpenVPN: Instances - only complain about a missing linked CA when none is being offered otherwise, if we're not going to use the attached CA, it should also be safe to ignore it. 2024-04-05 19:05:45 +02:00
Franco Fichtner b53fe7c1d9 dhcpd: make private consumers actually private where it matters 2024-04-05 12:06:31 +02:00
Franco Fichtner 14cc9a1c2f plugins: add globbing for run tasks as well 2024-04-05 11:52:17 +02:00
Stephan de Wit aebd4aa83c dashboard: missing copyright notice 2024-04-05 11:10:30 +02:00
Ad Schellevis 0d7b9fd34f Reporting: Traffic - fix netaddr incompatibility (AttributeError: 'IPAddress' object has no attribute 'is_private') 2024-04-05 10:24:01 +02:00
Franco Fichtner ce71a40b03 interfaces: unused return value 2024-04-05 10:22:41 +02:00
Stephan de Wit 5220c4a1a6 dashboard: widgets are draggable, adjust cursor accordingly 2024-04-05 09:30:47 +02:00
Ad Schellevis 899b41a576 VPN: WireGuard: Peer generator - Add DNS field and store previous used values in Instance. closes https://github.com/opnsense/core/issues/7357 2024-04-04 22:00:07 +02:00
Ad Schellevis 966bda3c96 mvc: minor regression in 10c81a4eea, if getNodeData() does not return an array, just pass the data. 2024-04-04 20:41:24 +02:00