`Array.prototype.some` short-circuits when a value is true which is better for performance and makes the intention more clear. Native `String.prototype.includes` is easier to read.
Now reading it as English, "if some argument includes 'verbose'"...
* Temporary fix for yarn complaining about upath
See this issue for details: https://github.com/anodynos/upath/issues/21
* Fix#2675: cannot open a new file
Made a minor change to browser/src/App.ts to only filter files if they
exists and pass them through otherwise.
* add a quickOpen default mode command and set to edit and fix check against zero in getDefaultOpenMode
* fix typo in comment
* further typo fixes in comment
The `shell env` package has been silently failing meaning that fixes that allow oni to read in a user's env var have regressed. This happened when we upgraded `webpack` because with the new version of webpack, dynamic imports now return objects with the shape `{ default: DefaultFnExport, aVar: var }`
Also upgraded the `shellenv` package as is since been upgraded.
* Remove duplicate completion items. This seems to happen a lot with `cquery` (C++) completions.
* Continue to sort abbreviations below full matches.
* Sort matching `filterText`/`labels` so they appear next to each other.
* Otherwise use `sortText` given by the language server.
* Retry symbol search whilst language server is still initialising
* Langauge servers can take a while to initialise, and this has a
specific error code associated with it when querying.
* So detect that specific error response and retry symbol search every
second until it works, or until the search menu is closed.
* # WARNING: head commit changed in the meantime
Unit test for menu `selectedIndex` reset to zero on filtering
* # WARNING: head commit changed in the meantime
Unit test for menu `selectedIndex` reset to zero on filtering
* Add test assertion on symbol request args
* Fix test for cross-platform paths
* Fix test for cross-platform paths (2)
* initial effort to get syntax highlighting to reapply on colorscheme reload
* remove lint check for whitespace inside template literals
* neaten reducer reset tidy up comment in bufferhighlight
so it appears in documentation dropdown
* Refactor token colors to pass token scopes as an array of strings
update affected tests
* fix imports in token colors
* pass in only visible tokens to the neovim token synchronizer
* fix lint errors
* fix another lint error
* revert token destructuring in reconciler
* notify redraw when tokencolors change in neovim editor
* update redux
* [wip] get token subset in synchronizeTokenColors
* make cache access more readable
* remove subset functionality from token synchronizer
* convert highlight cache to map so it can be cleared and reused easily
* do not split tokens on space char as this changes the way tokens are identified
* revert package json and yarn lock
* move private fields to avoid lint errors
* add onColorsChanged to neovim instance mock
* fix comments for token formatter function in token colors
If the user moves through the menu then resumes typing, the
`selectedIndex` can end up larger than the contents of the menu. This
can cause errors, or at least graphical glitches, and seems odd.
* For languages that allow method overloads, where the same method name
can be defined with different arguments (e.g. C++), the `label` of a
completion may be duplicated in the completions list, but the `detail`
should be different.
* Hence use the `detail` field, if available, to disambiguate between
completion items when updating them with the result of a
`completionItem/resolve`.
* Oni will hang indefinitely if the language server simply chooses to
ignore unsupported requests.
* This can be avoided if the server provides correct capabilities and
we actually check them before making the request.
Upgrade typescript to v3.1 & tslint (was dependent on some deprecated methods of the old version of ts) also fix associated type errors
Next up Im gonna try to use the project references feature of ts 3.0 to see if building all the various oni sub-projects can be simplified
This PR is one of some upcoming which allows specific sections of oni's ui that currently default to other colors in the theme specifically themable, in this case the border bottom of the tab bar default to `tabs.background` meaning it can't be specifically styled or hidden which is less flexible. This PR adds a specific config for this setting but maintains the default of `tabs.background` if no specific key is specified so it is backwards-compatible
This PR adds a call to the `remeasure` function to derive the window top and bottom lines as previously this was obtained from the various events and the buffer update function was passing incorrect
Bryan Phelps