opensourcemirror
/
oni
mirror of https://github.com/onivim/oni.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Feature/ Make tab bar border-bottom theme-able (#2585) 

This PR is one of some upcoming which allows specific sections of oni's ui that currently default to other colors in the theme specifically themable, in this case the border bottom of the tab bar default to `tabs.background` meaning it can't be specifically styled or hidden which is less flexible. This PR adds a specific config for this setting but maintains the default of `tabs.background` if no specific key is specified so it is backwards-compatible
This commit is contained in:
Akin 2018-10-04 14:20:46 +01:00 committed by GitHub
parent d354c2cc1e
commit 15a2ca9c38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/src/Services/Themes/ThemeManager.ts
View File

@ -35,6 +35,7 @@ export interface IThemeColors {
"tabs.background": string
"tabs.foreground": string
"tabs.borderBottom": string
"tabs.active.foreground": string
"tabs.active.background": string
@ -288,6 +289,7 @@ export const DefaultThemeColors: IThemeColors = {
"tabs.background": ColorBlack,
"tabs.foreground": ColorWhite,
"tabs.borderBottom": null,
"tabs.active.background": null,
"tabs.active.foreground": null,

2
browser/src/UI/components/Tabs.tsx
View File

@ -63,7 +63,7 @@ const TabsWrapper = styled<ITabsWrapperProps, "div">("div")`
align-items: flex-end;
width: 100%;
overflow-x: hidden;
border-bottom: 4px solid ${themeGet("tabs.background")};
border-bottom: 4px solid ${themeGet("tabs.borderBottom", "tabs.background")};
font-family: ${props => props.fontFamily};
font-size: ${props => props.fontSize};
transform: translateY(-3px);