chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>
This commit is contained in:
nextcloud-command 2024-04-19 02:20:14 +00:00 committed by GitHub
parent 7fca7ff774
commit 41ce66337a
1 changed files with 35 additions and 202 deletions

View File

@ -1,9 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.9.0@8b9ad1eb9e8b7d3101f949291da2b9f7767cd163">
<file src="3rdparty/sabre/dav/lib/CalDAV/Calendar.php">
<MoreSpecificImplementedParamType>
<code>$calendarData</code>
</MoreSpecificImplementedParamType>
<MoreSpecificImplementedParamType/>
</file>
<file src="3rdparty/sabre/dav/lib/CalDAV/CalendarHome.php">
<MoreSpecificImplementedParamType>
@ -16,9 +14,7 @@
</MoreSpecificImplementedParamType>
</file>
<file src="3rdparty/sabre/dav/lib/CardDAV/AddressBook.php">
<MoreSpecificImplementedParamType>
<code>$vcardData</code>
</MoreSpecificImplementedParamType>
<MoreSpecificImplementedParamType/>
</file>
<file src="3rdparty/sabre/dav/lib/CardDAV/AddressBookHome.php">
<InvalidPropertyAssignmentValue>
@ -105,11 +101,6 @@
<code>$baseuri</code>
</UndefinedGlobalVariable>
</file>
<file src="apps/dav/lib/AppInfo/Application.php">
<InvalidArgument>
<code>CalendarDeletionDefaultUpdaterListener::class</code>
</InvalidArgument>
</file>
<file src="apps/dav/lib/CalDAV/BirthdayService.php">
<UndefinedMethod>
<code>setDateTime</code>
@ -122,11 +113,6 @@
<code><![CDATA[$newCalendarData->VEVENT->SUMMARY]]></code>
</UndefinedPropertyFetch>
</file>
<file src="apps/dav/lib/CalDAV/CachedSubscription.php">
<ParamNameMismatch>
<code>$calendarData</code>
</ParamNameMismatch>
</file>
<file src="apps/dav/lib/CalDAV/CachedSubscriptionObject.php">
<NullableReturnStatement>
<code><![CDATA[$this->objectData['calendardata']]]></code>
@ -153,86 +139,6 @@
<code>VCalendar</code>
</MoreSpecificReturnType>
<NullableReturnStatement>
<code><![CDATA[$this->atomic(function () use ($calendarId, $syncToken, $syncLevel, $limit, $calendarType) {
// Current synctoken
$qb = $this->db->getQueryBuilder();
$qb->select('synctoken')
->from('calendars')
->where(
$qb->expr()->eq('id', $qb->createNamedParameter($calendarId))
);
$stmt = $qb->executeQuery();
$currentToken = $stmt->fetchOne();
if ($currentToken === false) {
return null;
}
$result = [
'syncToken' => $currentToken,
'added' => [],
'modified' => [],
'deleted' => [],
];
if ($syncToken) {
$qb = $this->db->getQueryBuilder();
$qb->select('uri', 'operation')
->from('calendarchanges')
->where(
$qb->expr()->andX(
$qb->expr()->gte('synctoken', $qb->createNamedParameter($syncToken)),
$qb->expr()->lt('synctoken', $qb->createNamedParameter($currentToken)),
$qb->expr()->eq('calendarid', $qb->createNamedParameter($calendarId)),
$qb->expr()->eq('calendartype', $qb->createNamedParameter($calendarType))
)
)->orderBy('synctoken');
if (is_int($limit) && $limit > 0) {
$qb->setMaxResults($limit);
}
// Fetching all changes
$stmt = $qb->executeQuery();
$changes = [];
// This loop ensures that any duplicates are overwritten, only the
// last change on a node is relevant.
while ($row = $stmt->fetch()) {
$changes[$row['uri']] = $row['operation'];
}
$stmt->closeCursor();
foreach ($changes as $uri => $operation) {
switch ($operation) {
case 1:
$result['added'][] = $uri;
break;
case 2:
$result['modified'][] = $uri;
break;
case 3:
$result['deleted'][] = $uri;
break;
}
}
} else {
// No synctoken supplied, this is the initial sync.
$qb = $this->db->getQueryBuilder();
$qb->select('uri')
->from('calendarobjects')
->where(
$qb->expr()->andX(
$qb->expr()->eq('calendarid', $qb->createNamedParameter($calendarId)),
$qb->expr()->eq('calendartype', $qb->createNamedParameter($calendarType))
)
);
$stmt = $qb->executeQuery();
$result['added'] = $stmt->fetchAll(\PDO::FETCH_COLUMN);
$stmt->closeCursor();
}
return $result;
}, $this->db)]]></code>
<code>null</code>
</NullableReturnStatement>
</file>
@ -342,7 +248,7 @@
</RedundantCast>
<RedundantCondition>
<code><![CDATA[!empty($modified['old']) && is_array($modified['old'])]]></code>
<code>is_array($modified['old'])</code>
<code><![CDATA[is_array($modified['old'])]]></code>
</RedundantCondition>
</file>
<file src="apps/dav/lib/CalDAV/Schedule/IMipService.php">
@ -353,8 +259,8 @@
</file>
<file src="apps/dav/lib/CalDAV/Schedule/Plugin.php">
<InvalidArgument>
<code>[$aclPlugin, 'propFind']</code>
<code>[$aclPlugin, 'propFind']</code>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code><![CDATA[$vevent->DTEND]]></code>
@ -389,12 +295,12 @@
</file>
<file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php">
<TypeDoesNotContainType>
<code>!is_array($newProps['filters']['comps'])</code>
<code>!is_array($newProps['filters']['params'])</code>
<code>!is_array($newProps['filters']['props'])</code>
<code>!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])</code>
<code>!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])</code>
<code>!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])</code>
<code><![CDATA[!is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['props'])]]></code>
<code><![CDATA[!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])]]></code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php">
@ -430,7 +336,7 @@
<code>VCard</code>
</MoreSpecificReturnType>
<TypeDoesNotContainType>
<code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code>
<code><![CDATA[$addressBooks[$row['id']][$readOnlyPropertyName] === 0]]></code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php">
@ -439,9 +345,6 @@
</InvalidNullableReturnType>
</file>
<file src="apps/dav/lib/CardDAV/PhotoCache.php">
<InvalidNullableReturnType>
<code>string</code>
</InvalidNullableReturnType>
<LessSpecificReturnStatement>
<code><![CDATA[[
'Content-Type' => $type,
@ -451,23 +354,12 @@
<MoreSpecificReturnType>
<code>false|array{body: string, Content-Type: string}</code>
</MoreSpecificReturnType>
<NullableReturnStatement>
<code>$type</code>
</NullableReturnStatement>
</file>
<file src="apps/dav/lib/CardDAV/Plugin.php">
<ImplementedReturnTypeMismatch>
<code>string|null</code>
</ImplementedReturnTypeMismatch>
</file>
<file src="apps/dav/lib/CardDAV/SystemAddressbook.php">
<InvalidNullableReturnType>
<code>getChanges</code>
</InvalidNullableReturnType>
<NullableReturnStatement>
<code>null</code>
</NullableReturnStatement>
</file>
<file src="apps/dav/lib/CardDAV/UserAddressBooks.php">
<InvalidArgument>
<code><![CDATA[$this->principalUri]]></code>
@ -541,13 +433,12 @@
<file src="apps/dav/lib/Connector/Sabre/FilesReportPlugin.php">
<InvalidArgument>
<code>0</code>
<code>200</code>
</InvalidArgument>
<InvalidNullableReturnType>
<code>bool</code>
</InvalidNullableReturnType>
<TooManyArguments>
<code>new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)</code>
<code><![CDATA[new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)]]></code>
</TooManyArguments>
<UndefinedClass>
<code>\OCA\Circles\Api\v1\Circles</code>
@ -879,7 +770,7 @@
</file>
<file src="apps/encryption/lib/Crypto/Crypt.php">
<TypeDoesNotContainType>
<code>get_class($res) === 'OpenSSLAsymmetricKey'</code>
<code><![CDATA[get_class($res) === 'OpenSSLAsymmetricKey']]></code>
</TypeDoesNotContainType>
</file>
<file src="apps/encryption/lib/Crypto/Encryption.php">
@ -894,7 +785,7 @@
</file>
<file src="apps/encryption/lib/Session.php">
<TooManyArguments>
<code>new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)</code>
<code><![CDATA[new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)]]></code>
</TooManyArguments>
</file>
<file src="apps/encryption/lib/Util.php">
@ -922,7 +813,7 @@
<code>$shareId</code>
<code>$shareId</code>
<code>$shareId</code>
<code>(int)$data['id']</code>
<code><![CDATA[(int)$data['id']]]></code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code>$nodes[0]</code>
@ -957,7 +848,7 @@
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument>
<code>(int)$share['id']</code>
<code><![CDATA[(int)$share['id']]]></code>
</InvalidScalarArgument>
</file>
<file src="apps/federation/lib/DbHandler.php">
@ -1244,7 +1135,7 @@
</file>
<file src="apps/files_sharing/templates/public.php">
<RedundantCondition>
<code>$_['hideFileList'] !== true</code>
<code><![CDATA[$_['hideFileList'] !== true]]></code>
<code><![CDATA[isset($_['hideFileList']) && $_['hideFileList'] !== true]]></code>
</RedundantCondition>
</file>
@ -1379,9 +1270,6 @@
</InvalidReturnType>
</file>
<file src="apps/settings/lib/AppInfo/Application.php">
<InvalidArgument>
<code>AppPasswordCreatedActivityListener::class</code>
</InvalidArgument>
<UndefinedInterfaceMethod>
<code>getSettingsManager</code>
</UndefinedInterfaceMethod>
@ -1424,7 +1312,7 @@
<file src="apps/sharebymail/lib/ShareByMailProvider.php">
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code>(int)$data['id']</code>
<code><![CDATA[(int)$data['id']]]></code>
</InvalidArgument>
</file>
<file src="apps/systemtags/lib/Activity/Listener.php">
@ -1664,9 +1552,6 @@
<InvalidReturnType>
<code>string</code>
</InvalidReturnType>
<ParamNameMismatch>
<code>$uid</code>
</ParamNameMismatch>
</file>
<file src="apps/workflowengine/lib/Listener/LoadAdditionalSettingsScriptsListener.php">
<MissingTemplateParam>
@ -1935,7 +1820,6 @@
</InvalidReturnStatement>
<InvalidReturnType>
<code>\OCP\IServerContainer</code>
<code>mixed</code>
</InvalidReturnType>
<UndefinedInterfaceMethod>
<code>getAppDataDir</code>
@ -2006,7 +1890,7 @@
</file>
<file src="lib/private/AppFramework/Routing/RouteConfig.php">
<InvalidArrayOffset>
<code>$action['url-postfix']</code>
<code><![CDATA[$action['url-postfix']]]></code>
</InvalidArrayOffset>
</file>
<file src="lib/private/AppFramework/Services/AppConfig.php">
@ -2017,39 +1901,6 @@
<file src="lib/private/AppFramework/Utility/SimpleContainer.php">
<LessSpecificReturnStatement>
<code><![CDATA[$class->newInstance()]]></code>
<code><![CDATA[$class->newInstanceArgs(array_map(function (ReflectionParameter $parameter) {
$parameterType = $parameter->getType();
$resolveName = $parameter->getName();
// try to find out if it is a class or a simple parameter
if ($parameterType !== null && ($parameterType instanceof ReflectionNamedType) && !$parameterType->isBuiltin()) {
$resolveName = $parameterType->getName();
}
try {
$builtIn = $parameter->hasType() && ($parameter->getType() instanceof ReflectionNamedType)
&& $parameter->getType()->isBuiltin();
return $this->query($resolveName, !$builtIn);
} catch (QueryException $e) {
// Service not found, use the default value when available
if ($parameter->isDefaultValueAvailable()) {
return $parameter->getDefaultValue();
}
if ($parameterType !== null && ($parameterType instanceof ReflectionNamedType) && !$parameterType->isBuiltin()) {
$resolveName = $parameter->getName();
try {
return $this->query($resolveName);
} catch (QueryException $e2) {
// don't lose the error we got while trying to query by type
throw new QueryException($e->getMessage(), (int) $e->getCode(), $e);
}
}
throw $e;
}
}, $constructor->getParameters()))]]></code>
</LessSpecificReturnStatement>
<MissingTemplateParam>
<code>ArrayAccess</code>
@ -2202,17 +2053,7 @@
</ParamNameMismatch>
</file>
<file src="lib/private/Command/ClosureJob.php">
<InvalidArgument>
<code>[LaravelClosure::class, OpisClosure::class]</code>
</InvalidArgument>
<ParamNameMismatch>
<code>$serializedCallable</code>
</ParamNameMismatch>
</file>
<file src="lib/private/Command/CommandJob.php">
<ParamNameMismatch>
<code>$serializedCommand</code>
</ParamNameMismatch>
<InvalidArgument/>
</file>
<file src="lib/private/Comments/Manager.php">
<RedundantCast>
@ -2244,7 +2085,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code>$params['collation']</code>
<code><![CDATA[$params['collation']]]></code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/Connection.php">
@ -2255,8 +2096,8 @@
<code>$params</code>
</InvalidArgument>
<InvalidArrayOffset>
<code>$params['adapter']</code>
<code>$params['tablePrefix']</code>
<code><![CDATA[$params['adapter']]]></code>
<code><![CDATA[$params['tablePrefix']]]></code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/Exceptions/DbalException.php">
@ -2289,7 +2130,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code>$params['collation']</code>
<code><![CDATA[$params['collation']]]></code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/QueryBuilder/QueryBuilder.php">
@ -2484,10 +2325,10 @@
<code>$user</code>
</InvalidOperand>
<RedundantCondition>
<code>get_class($provider) !== 'OCA\Files_Sharing\MountProvider'</code>
<code><![CDATA[get_class($provider) !== 'OCA\Files_Sharing\MountProvider']]></code>
</RedundantCondition>
<TypeDoesNotContainType>
<code>get_class($provider) === 'OCA\Files_Sharing\MountProvider'</code>
<code><![CDATA[get_class($provider) === 'OCA\Files_Sharing\MountProvider']]></code>
</TypeDoesNotContainType>
</file>
<file src="lib/private/Files/Config/UserMountCache.php">
@ -2662,7 +2503,7 @@
<code>Promise\promise_for(
new Credentials($key, $secret)
)</code>
<code>\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())</code>
<code><![CDATA[\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())]]></code>
</UndefinedFunction>
</file>
<file src="lib/private/Files/ObjectStore/S3ObjectTrait.php">
@ -2868,9 +2709,6 @@
<LessSpecificReturnStatement>
<code>$users</code>
</LessSpecificReturnStatement>
<MoreSpecificImplementedParamType>
<code>$user</code>
</MoreSpecificImplementedParamType>
<MoreSpecificReturnType>
<code>\OC\User\User[]</code>
</MoreSpecificReturnType>
@ -2921,8 +2759,8 @@
<code>false</code>
</InvalidArgument>
<InvalidArrayOffset>
<code>$app['path']</code>
<code>$app['path']</code>
<code><![CDATA[$app['path']]]></code>
<code><![CDATA[$app['path']]]></code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>
@ -3155,11 +2993,6 @@
<code>$out</code>
</ParamNameMismatch>
</file>
<file src="lib/private/Repair/SqliteAutoincrement.php">
<ParamNameMismatch>
<code>$out</code>
</ParamNameMismatch>
</file>
<file src="lib/private/Route/Router.php">
<InvalidClass>
<code>\OC_APP</code>
@ -3275,8 +3108,8 @@
</file>
<file src="lib/private/Setup.php">
<RedundantCondition>
<code>$content !== ''</code>
<code>$type === 'pdo'</code>
<code><![CDATA[$content !== '']]></code>
<code><![CDATA[$type === 'pdo']]></code>
</RedundantCondition>
<UndefinedVariable>
<code>$vendor</code>
@ -3306,7 +3139,7 @@
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[$share->getId()]]></code>
<code>(int)$data['id']</code>
<code><![CDATA[(int)$data['id']]]></code>
</InvalidArgument>
<TooManyArguments>
<code>set</code>
@ -3512,8 +3345,8 @@
<code>$groupsList</code>
</InvalidArgument>
<InvalidArrayOffset>
<code>$dir['path']</code>
<code>$dir['url']</code>
<code><![CDATA[$dir['path']]]></code>
<code><![CDATA[$dir['url']]]></code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>