opensourcemirror
/
nextcloud-notes
mirror of https://github.com/nextcloud/notes.git
1
0
Fork 0
Code Issues Releases Wiki Activity

add test for Nextcloud min-version

This commit is contained in:
korelstar 2019-09-19 08:55:17 +02:00
parent 156769f38b
commit 78ef30cb85
2 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -109,6 +109,8 @@ lint-nextcloud:
# Check info.xml schema validity
wget https://apps.nextcloud.com/schema/apps/info.xsd -P appinfo/ -N --no-verbose || [ -f appinfo/info.xsd ]
xmllint appinfo/info.xml --schema appinfo/info.xsd --noout
# Check min-version consistency
php tests/nextcloud-version.php
# Fix lint
lint-fix: lint-php-fix lint-js-fix lint-css-fix

63
tests/nextcloud-version.php Normal file
View File

@ -0,0 +1,63 @@
<?php
function getNCVersionFromComposer($path) {
if(!file_exists($path)) {
throw new Exception('Composer file does not exists: '.$path);
}
if(!is_readable($path)) {
throw new Exception('Composer file is not readable: '.$path);
}
$content = file_get_contents($path);
$json = json_decode($content);
if(!is_object($json)) {
throw new Exception('Composer file does not contain valid JSON');
}
if(!property_exists($json, 'require-dev')) {
throw new Exception('Composer file has no "require-dev" section');
}
$dev = $json->{'require-dev'};
if(!is_object($dev)) {
throw new Exception('Composer file has no valid "require-dev" section');
}
if(!property_exists($dev, 'christophwurst/nextcloud')) {
throw new Exception('Composer file has no "nextcloud" dependency');
}
$v = $dev->{'christophwurst/nextcloud'};
if(substr($v, 0, 1)=='^') {
$v = substr($v, 1);
}
return $v;
}
function getNCVersionFromAppInfo($path) {
if(!file_exists($path)) {
throw new Exception('AppInfo does not exists: '.$path);
}
if(!is_readable($path)) {
throw new Exception('AppInfo is not readable: '.$path);
}
$content = file_get_contents($path);
$info = new SimpleXMLElement($content);
$nc = $info->dependencies->nextcloud;
$v = (string)$nc->attributes()->{'min-version'};
if(strpos($v, '.') === false) {
$v .= '.0';
}
return $v;
}
echo 'Testing Nextcloud min-version: ';
try {
$vComposer = getNCVersionFromComposer(__DIR__.'/../composer.json');
$vAppInfo = getNCVersionFromAppInfo(__DIR__.'/../appinfo/info.xml');
if($vComposer === $vAppInfo) {
echo $vAppInfo.PHP_EOL;
} else {
echo 'FAILED with '.$vComposer.' (Composer) vs. '.$vAppInfo.' (AppInfo)'.PHP_EOL;
exit(1);
}
} catch(Exception $e) {
echo $e->getMessage().PHP_EOL;
exit(1);
}
?>