From bef5857efa1f368698425706306fc9ba1574c1db Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 5 Apr 2018 21:29:00 +0200
Subject: [PATCH] Fix PageControllerTest
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 lib/Controller/PageController.php            |  2 +-
 tests/unit/Controller/PageControllerTest.php | 59 ++++++++++++++------
 2 files changed, 44 insertions(+), 17 deletions(-)

diff --git a/lib/Controller/PageController.php b/lib/Controller/PageController.php
index c51d374a..8b5e6147 100644
--- a/lib/Controller/PageController.php
+++ b/lib/Controller/PageController.php
@@ -118,7 +118,7 @@ class PageController extends Controller {
 	 * @param string $token
 	 * @param null|string $filename
 	 *
-	 * @return TemplateResponse|ImageResponse|RedirectResponse
+	 * @return PublicTemplateResponse|ImageResponse|RedirectResponse
 	 */
 	public function publicIndex($token, $filename) {
 		$node = $this->environment->getSharedNode();
diff --git a/tests/unit/Controller/PageControllerTest.php b/tests/unit/Controller/PageControllerTest.php
index 9e47ef7e..b7aa243b 100644
--- a/tests/unit/Controller/PageControllerTest.php
+++ b/tests/unit/Controller/PageControllerTest.php
@@ -13,7 +13,11 @@
 
 namespace OCA\Gallery\Tests\Controller;
 
+use OCP\AppFramework\Http\Template\ExternalShareMenuAction;
+use OCP\AppFramework\Http\Template\LinkMenuAction;
+use OCP\AppFramework\Http\Template\SimpleMenuAction;
 use OCP\IConfig;
+use OCP\IL10N;
 use OCP\IRequest;
 use OCP\IURLGenerator;
 
@@ -44,6 +48,8 @@ class PageControllerTest extends \Test\TestCase {
 	protected $controller;
 	/** @var EventDispatcherInterface */
 	protected $dispatcher;
+	/** @var IL10N */
+	private $l10n;
 
 	/**
 	 * Test set up
@@ -51,18 +57,11 @@ class PageControllerTest extends \Test\TestCase {
 	protected function setUp() {
 		parent::setUp();
 
-		$this->request = $this->getMockBuilder('\OCP\IRequest')
-							  ->disableOriginalConstructor()
-							  ->getMock();
-		$this->environment = $this->getMockBuilder('\OCA\Gallery\Environment\Environment')
-								  ->disableOriginalConstructor()
-								  ->getMock();
-		$this->urlGenerator = $this->getMockBuilder('\OCP\IURLGenerator')
-								   ->disableOriginalConstructor()
-								   ->getMock();
-		$this->appConfig = $this->getMockBuilder('\OCP\IConfig')
-								->disableOriginalConstructor()
-								->getMock();
+		$this->request = $this->createMock(IRequest::class);
+		$this->environment = $this->createMock(Environment::class);
+		$this->urlGenerator = $this->createMock(IURLGenerator::class);
+		$this->appConfig = $this->createMock(IConfig::class);
+		$this->l10n = $this->createMock(IL10N::class);
 		$this->dispatcher = $this->createMock(EventDispatcherInterface::class);
 		$this->controller = new PageController(
 			$this->appName,
@@ -70,7 +69,8 @@ class PageControllerTest extends \Test\TestCase {
 			$this->environment,
 			$this->urlGenerator,
 			$this->appConfig,
-			$this->dispatcher
+			$this->dispatcher,
+			$this->l10n
 		);
 	}
 
@@ -154,15 +154,28 @@ class PageControllerTest extends \Test\TestCase {
 		$this->mockGetDisplayName($displayName);
 		$this->mockGetSharePassword($password);
 		$this->mockGetAppValue($server2ServerSharingEnabled);
+		$this->mockGetUserId('user1');
+		$this->mockL10N();
 
-		$template = new TemplateResponse($this->appName, 'public', $params, 'public');
+		$template = new Http\Template\PublicTemplateResponse($this->appName, 'public', $params);
 
-		$response = $this->controller->publicIndex($token, null);
+		$response = $this->controller->publicIndex($token, 'filename.txt');
 
 		$this->assertEquals($params, $response->getParams());
 		$this->assertEquals('public', $response->getTemplateName());
-		$this->assertTrue($response instanceof TemplateResponse);
+		$this->assertTrue($response instanceof Http\Template\PublicTemplateResponse);
 		$this->assertEquals($template->getStatus(), $response->getStatus());
+		$this->assertEquals($albumName, $response->getHeaderTitle());
+		$this->assertEquals('shared by ' . $displayName, $response->getHeaderDetails());
+
+		$actions = [
+			new SimpleMenuAction('download', $this->l10n->t('Download'), 'icon-download-white', '', 0),
+			new SimpleMenuAction('download', $this->l10n->t('Download'), 'icon-download', '', 10),
+			new LinkMenuAction($this->l10n->t('Direct link'), 'icon-public', ''),
+			new ExternalShareMenuAction($this->l10n->t('Add to your Nextcloud'), 'icon-external', 'user1', $displayName, $albumName)
+		];
+		$this->assertEquals($actions[0], $response->getPrimaryAction());
+		$this->assertEquals(array_slice($actions, 1), $response->getOtherActions());
 	}
 
 	public function testPublicIndexWithFileToken() {
@@ -238,6 +251,12 @@ class PageControllerTest extends \Test\TestCase {
 						->willReturn($status);
 	}
 
+	private function mockGetUserId($userId) {
+		$this->environment->expects($this->once())
+			->method('getUserId')
+			->willReturn($userId);
+	}
+
 	private function mockUrlToDownloadPage($token, $fileId, $filename, $url) {
 		$this->urlGenerator->expects($this->once())
 						   ->method('linkToRoute')
@@ -286,4 +305,12 @@ class PageControllerTest extends \Test\TestCase {
 						   ->with('files', 'ajax/upload.php')
 						   ->willReturn($url);
 	}
+
+	private function mockL10N() {
+		$this->l10n->expects($this->any())
+			->method('t')
+			->will($this->returnCallback(function($text, $params) {
+				return vsprintf($text, $params);
+			}));
+	}
 }