From a2f0d81c2179217a5be34d04331795fa4a32a6f4 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 29 Oct 2020 16:23:59 +0100 Subject: [PATCH] add loading shimmer for preview image Signed-off-by: Andy Scherzinger --- drawable_resources/ic_image-outline.svg | 1 + .../ui/preview/PreviewImageFragment.java | 11 ++- src/main/res/drawable/ic_image_outline.xml | 8 ++ .../res/layout/preview_image_fragment.xml | 81 +++++++++++++++++-- 4 files changed, 93 insertions(+), 8 deletions(-) create mode 100644 drawable_resources/ic_image-outline.svg create mode 100644 src/main/res/drawable/ic_image_outline.xml diff --git a/drawable_resources/ic_image-outline.svg b/drawable_resources/ic_image-outline.svg new file mode 100644 index 0000000000..c976834357 --- /dev/null +++ b/drawable_resources/ic_image-outline.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java b/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java index 3a35eef07e..1f82649284 100644 --- a/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java +++ b/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java @@ -46,6 +46,7 @@ import android.view.MenuInflater; import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; +import android.widget.FrameLayout; import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.TextView; @@ -117,6 +118,7 @@ public class PreviewImageFragment extends FileFragment implements Injectable { private TextView mMultiListMessage; private TextView mMultiListHeadline; private ImageView mMultiListIcon; + private FrameLayout mMultiListProgress; private Boolean showResizedImage; @@ -216,6 +218,7 @@ public class PreviewImageFragment extends FileFragment implements Injectable { multiListMessage = binding.emptyList.emptyListViewText; multiListHeadline = binding.emptyList.emptyListViewHeadline; multiListIcon = binding.emptyList.emptyListIcon; + mMultiListProgress = view.findViewById(R.id.empty_list_progress); } /** @@ -699,11 +702,12 @@ public class PreviewImageFragment extends FileFragment implements Injectable { } private void setMultiListLoadingMessage() { - if (multiListContainer != null) { - multiListHeadline.setText(R.string.file_list_loading); - multiListMessage.setText(""); + if (mMultiListContainer != null) { + mMultiListHeadline.setText(""); + mMultiListMessage.setText(""); mMultiListIcon.setVisibility(View.GONE); + mMultiListProgress.setVisibility(View.VISIBLE); } } @@ -719,6 +723,7 @@ public class PreviewImageFragment extends FileFragment implements Injectable { mMultiListMessage.setVisibility(View.VISIBLE); mMultiListIcon.setVisibility(View.VISIBLE); + mMultiListProgress.setVisibility(View.GONE); } } diff --git a/src/main/res/drawable/ic_image_outline.xml b/src/main/res/drawable/ic_image_outline.xml new file mode 100644 index 0000000000..27c42efe1b --- /dev/null +++ b/src/main/res/drawable/ic_image_outline.xml @@ -0,0 +1,8 @@ + + + + \ No newline at end of file diff --git a/src/main/res/layout/preview_image_fragment.xml b/src/main/res/layout/preview_image_fragment.xml index abd1c536c7..cc1b4e3e68 100644 --- a/src/main/res/layout/preview_image_fragment.xml +++ b/src/main/res/layout/preview_image_fragment.xml @@ -1,5 +1,4 @@ - - - + + + + + + + + + + + + + + + + + +