From a1b997f7bcc5dc8de93473abc27d413035c2d47e Mon Sep 17 00:00:00 2001 From: Timotej S <6674623+underhood@users.noreply.github.com> Date: Wed, 16 Sep 2020 09:59:46 +0200 Subject: [PATCH] Fix resource leak in case of malformed cloud request (#9934) --- aclk/aclk_rx_msgs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/aclk/aclk_rx_msgs.c b/aclk/aclk_rx_msgs.c index b166d13449..85b0d74ac9 100644 --- a/aclk/aclk_rx_msgs.c +++ b/aclk/aclk_rx_msgs.c @@ -104,8 +104,11 @@ static int aclk_handle_cloud_request_v2(struct aclk_request *cloud_to_agent, cha return 1; } - if (unlikely(aclk_v2_payload_get_query(data, cloud_to_agent))) + if (unlikely(aclk_v2_payload_get_query(data, cloud_to_agent))) { + error("Could not extract payload from query"); + freez(data); return 1; + } if (unlikely(!cloud_to_agent->callback_topic)) { error("Missing callback_topic");