opensourcemirror
/
netdata
mirror of https://github.com/netdata/netdata.git
1
0
Fork 0
Code Issues Releases Wiki Activity

address lgtm alerts (#7441)

This commit is contained in:
Jacek Kolasa 2019-12-05 13:41:15 +01:00 committed by GitHub
parent f92a092417
commit 7953472f11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.remarkrc.js
View File

@ -1,8 +1,5 @@
// Source: https://github.com/codacy/codacy-remark-lint/raw/master/.remarkrc.js
const fs = require("fs");
const path = require("path");
exports.settings = {
gfm: true,
commonmark: true,
@ -19,13 +16,6 @@ exports.settings = {
incrementListMarker: true
};
const personalDictionaryPath = path.join(__dirname, ".dictionary");
const personalDictionary = fs.existsSync(personalDictionaryPath)
? {
personal: fs.readFileSync(personalDictionaryPath, "utf8")
}
: {};
const remarkPresetLintMarkdownStyleGuide = {
plugins: require("remark-preset-lint-markdown-style-guide").plugins.filter(
function(elem) {

2
web/gui/dash-example.html
View File

@ -692,7 +692,7 @@ class PickNSort {
for (var i = 0; i < aProps.length; i++) {
var propName = aProps[i];
var aa = a[propName]
var aa = a[propName];
var aaProps = Object.keys(aa);
var bb = b[propName];
var bbProps = Object.keys(bb);

7
web/gui/main.js
View File

@ -1818,7 +1818,7 @@ function renderPage(menus, data) {
if (!isMemoryModeDbEngine) {
sidebar += '<br />&nbsp;<br />Get more history by ' +
'<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>'
'<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>';
}
sidebar += '<br/>&nbsp;<br/><strong>netdata</strong><br/>' + data.version.toString() + '</small></li>';
@ -4956,7 +4956,8 @@ function handleSignInMessage(e) {
netdataRegistryCallback(registryAgents);
if (e.data.redirectURI && !window.location.href.includes(e.data.redirectURI)) {
window.location.replace(e.data.redirectURI);
// lgtm false-positive - redirectURI does not come from user input, but from iframe callback
window.location.replace(e.data.redirectURI); // lgtm[js/client-side-unvalidated-url-redirection]
}
}
@ -5183,5 +5184,5 @@ if (document.readyState === "complete") {
if (document.readyState === "complete") {
initializeApp();
}
})
});
}