From 1b200d99360c1a4737f1d36206f3385a77d7d93e Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Fri, 14 Feb 2020 03:43:28 -0500 Subject: [PATCH] checkhealth: ignore cpamn "!" output #11869 cpanm outputs a warning that suggest to use 'sudo' or use local::lib. cpanm exits with 0 so nvim thinks that the command worked. cpanm output that starts with "!" is likely an error. Close #11858 --- runtime/autoload/health/provider.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/autoload/health/provider.vim b/runtime/autoload/health/provider.vim index 1d720b5876..601a8f83ef 100644 --- a/runtime/autoload/health/provider.vim +++ b/runtime/autoload/health/provider.vim @@ -708,9 +708,9 @@ function! s:check_perl() abort endif call health#report_info('Nvim perl host: '. host) - let latest_cpan_cmd = 'cpanm --info Neovim::Ext' + let latest_cpan_cmd = 'cpanm --info -q Neovim::Ext' let latest_cpan = s:system(latest_cpan_cmd) - if s:shell_error || empty(latest_cpan) + if s:shell_error || empty(latest_cpan) || latest_cpan[0] ==# '!' call health#report_error('Failed to run: '. latest_cpan_cmd, \ ["Make sure you're connected to the internet.", \ 'Are you behind a firewall or proxy?'])