kraken3: Rename to self._fw; init to None

Signed-off-by: Aleksa Savić <savicaleksa83@gmail.com>
This commit is contained in:
Aleksa Savić 2024-04-10 17:14:57 +02:00 committed by Jonas Malaco
parent a86237cc66
commit 255821125c
1 changed files with 6 additions and 5 deletions

View File

@ -213,6 +213,7 @@ class KrakenX3(UsbHidDriver):
self._speed_channels = speed_channels
self._color_channels = color_channels
self._hwmon_ctrl_mapping = hwmon_ctrl_mapping
self._fw = None
def initialize(self, direct_access=False, **kwargs):
"""Initialize the device and the driver.
@ -248,11 +249,11 @@ class KrakenX3(UsbHidDriver):
self._status = []
self._read_until({b"\x11\x01": self.parse_firm_info, b"\x21\x03": self.parse_led_info})
self._status.append(("Firmware version", f"{self.fw[0]}.{self.fw[1]}.{self.fw[2]}", ""))
self._status.append(("Firmware version", f"{self._fw[0]}.{self._fw[1]}.{self._fw[2]}", ""))
return sorted(self._status)
def parse_firm_info(self, msg):
self.fw = (msg[0x11], msg[0x12], msg[0x13])
self._fw = (msg[0x11], msg[0x12], msg[0x13])
def parse_led_info(self, msg):
channel_count = msg[14]
@ -648,7 +649,7 @@ class KrakenZ3(KrakenX3):
return False
def _get_fw_version(self, clear_reports=True):
if self.fw is not None:
if self._fw is not None:
return # Already cached
if clear_reports:
@ -689,7 +690,7 @@ class KrakenZ3(KrakenX3):
# request static infos
self._get_fw_version(clear_reports=False)
self._status.append(("Firmware version", f"{self.fw[0]}.{self.fw[1]}.{self.fw[2]}", ""))
self._status.append(("Firmware version", f"{self._fw[0]}.{self._fw[1]}.{self._fw[2]}", ""))
self._write([0x30, 0x01]) # lcd info
self._read_until({b"\x31\x01": self.parse_lcd_info})
@ -786,7 +787,7 @@ class KrakenZ3(KrakenX3):
device_product_id = self.device.product_id
if device_product_id == 0x300E:
self._get_fw_version()
if self.fw[0] == 2:
if self._fw[0] == 2:
raise NotSupportedByDriver(
"setting images is not supported on firmware 2.X.Y, please see issue #631"
)