From c2f3ef8d8f16bccd08f17d33f6a6e10f0e79cdb3 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 2 Sep 2020 20:16:38 +0000 Subject: [PATCH 1/3] vcbuild: fix library name for expat with make MSVC=1 Signed-off-by: Orgad Shaneh Acked-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- compat/vcbuild/scripts/clink.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl index 61ad084a7b..df167d1e1a 100755 --- a/compat/vcbuild/scripts/clink.pl +++ b/compat/vcbuild/scripts/clink.pl @@ -66,7 +66,7 @@ while (@ARGV) { } push(@args, $lib); } elsif ("$arg" eq "-lexpat") { - push(@args, "expat.lib"); + push(@args, "libexpat.lib"); } elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") { $arg =~ s/^-L/-LIBPATH:/; push(@lflags, $arg); From 3384a1ef78cae095d527d106cc15ca13b075c05f Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 2 Sep 2020 20:18:20 +0000 Subject: [PATCH 2/3] vcbuild: fix batch file name in README Signed-off-by: Orgad Shaneh Acked-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- compat/vcbuild/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compat/vcbuild/README b/compat/vcbuild/README index 42292e7c09..51fb083dbb 100644 --- a/compat/vcbuild/README +++ b/compat/vcbuild/README @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line. Use ONE of the following forms which should match how you want to compile git.exe. - $ ./compat/vcbuild/vcpkg_copy_packages.bat debug - $ ./compat/vcbuild/vcpkg_copy_packages.bat release + $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug + $ ./compat/vcbuild/vcpkg_copy_dlls.bat release 3. Build git using MSVC from an SDK bash window using one of the following commands: From e58e40556fc40cc39c018d98f7fcc09bdf3c398e Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 7 Sep 2020 06:00:05 +0000 Subject: [PATCH 3/3] contrib/buildsystems: fix expat library name for generated vcxproj expat.lib -> libexpat.lib (libexpatd.lib for debug build). Signed-off-by: Orgad Shaneh Acked-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- contrib/buildsystems/Generators/Vcxproj.pm | 1 + contrib/buildsystems/engine.pl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/buildsystems/Generators/Vcxproj.pm b/contrib/buildsystems/Generators/Vcxproj.pm index 5c666f9ac0..d2584450ba 100644 --- a/contrib/buildsystems/Generators/Vcxproj.pm +++ b/contrib/buildsystems/Generators/Vcxproj.pm @@ -80,6 +80,7 @@ sub createProject { $libs_release = join(";", sort(grep /^(?!libgit\.lib|xdiff\/lib\.lib|vcs-svn\/lib\.lib)/, @{$$build_structure{"$prefix${name}_LIBS"}})); $libs_debug = $libs_release; $libs_debug =~ s/zlib\.lib/zlibd\.lib/g; + $libs_debug =~ s/libexpat\.lib/libexpatd\.lib/g; $libs_debug =~ s/libcurl\.lib/libcurl-d\.lib/g; } diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 070978506a..2ff9620459 100755 --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems/engine.pl @@ -349,7 +349,7 @@ sub handleLinkLine } elsif ("$part" eq "-lcurl") { push(@libs, "libcurl.lib"); } elsif ("$part" eq "-lexpat") { - push(@libs, "expat.lib"); + push(@libs, "libexpat.lib"); } elsif ("$part" eq "-liconv") { push(@libs, "libiconv.lib"); } elsif ($part =~ /^[-\/]/) {