opensourcemirror
/
git
mirror of https://github.com/git/git.git
1
0
Fork 0
Code Issues Releases Wiki Activity

promisor-remote: remove unused variable 

The variable core_partial_clone_filter_default has been unused since
fa3d1b63e8 ("promisor-remote: parse remote.*.partialclonefilter",
2019-06-25), when Git was changed to refer to
remote.*.partialclonefilter as the default filter when fetching in a
partial clone, but (perhaps inadvertently) there was no fallback to
core.partialclonefilter.

One alternative is to add the fallback, but the aforementioned change
was made more than a year ago and I have not heard of any complaints
regarding this matter. In addition, there is currently no mention of
core.partialclonefilter in the user documentation. So it seems best to
reaffirm that Git will only support remote.*.partialclonefilter.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jonathan Tan 2020-09-21 20:03:56 -07:00 committed by Junio C Hamano
parent 385c171a01
commit 625e7f148e
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
promisor-remote.c
View File

@ -6,7 +6,6 @@
#include "strvec.h"
static char *repository_format_partial_clone;
static const char *core_partial_clone_filter_default;
void set_repository_format_partial_clone(char *partial_clone)
{
@ -100,10 +99,6 @@ static int promisor_remote_config(const char *var, const char *value, void *data
size_t namelen;
const char *subkey;
if (!strcmp(var, "core.partialclonefilter"))
return git_config_string(&core_partial_clone_filter_default,
var, value);
if (parse_config_key(var, "remote", &name, &namelen, &subkey) < 0)
return 0;

2
promisor-remote.h
View File

@ -9,7 +9,7 @@ struct object_id;
* Promisor remote linked list
*
* Information in its fields come from remote.XXX config entries or
* from extensions.partialclone or core.partialclonefilter.
* from extensions.partialclone.
*/
struct promisor_remote {
struct promisor_remote *next;