From 44143583b76decf93c55b73adaf2367c22c88998 Mon Sep 17 00:00:00 2001 From: Derrick Stolee Date: Tue, 31 Dec 2019 13:17:48 +0000 Subject: [PATCH 1/2] sparse-checkout: use extern for global variables When the core.sparseCheckoutCone config setting was added in 879321eb0b ("sparse-checkout: add 'cone' mode" 2019-11-21), the variables storing the config values for core.sparseCheckout and core.sparseCheckoutCone were rearranged in cache.h, but in doing so the "extern" keyword was dropped. While we are tending to drop the "extern" keyword for function declarations, it is still necessary for global variables used across multiple *.c files. The impact of not having the extern keyword may be unpredictable. Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano --- cache.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cache.h b/cache.h index d3c89e7a53..097f5883ac 100644 --- a/cache.h +++ b/cache.h @@ -925,8 +925,8 @@ extern int protect_hfs; extern int protect_ntfs; extern const char *core_fsmonitor; -int core_apply_sparse_checkout; -int core_sparse_checkout_cone; +extern int core_apply_sparse_checkout; +extern int core_sparse_checkout_cone; /* * Include broken refs in all ref iterations, which will From 757ff352bd66de31715580f8c525e54ad30b22eb Mon Sep 17 00:00:00 2001 From: Taylor Blau Date: Thu, 2 Jan 2020 15:51:40 -0700 Subject: [PATCH 2/2] Documentation/git-sparse-checkout.txt: fix a typo This typo was introduced in 94c0956b60 (sparse-checkout: create builtin with 'list' subcommand, 2019-11-21). Signed-off-by: Taylor Blau Acked-by: Derrick Stolee Signed-off-by: Junio C Hamano --- Documentation/git-sparse-checkout.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-sparse-checkout.txt b/Documentation/git-sparse-checkout.txt index 9c3c66cc37..a3c920fa6c 100644 --- a/Documentation/git-sparse-checkout.txt +++ b/Documentation/git-sparse-checkout.txt @@ -5,7 +5,7 @@ NAME ---- git-sparse-checkout - Initialize and modify the sparse-checkout configuration, which reduces the checkout to a set of paths -given by a list of atterns. +given by a list of patterns. SYNOPSIS