Warning: Undefined array key "pop" in install.php on line 427
In PHP 8, attempting to read an undefined array key throws a warning
instead of a notice as in earlier versions [1].
[1]: https://www.php.net/manual/en/migration80.incompatible.php
* Checks for PHP mail in install.php and warns if mail used after install.
* fixed spacing in instal.php
* Reconfigured warning message and code for PHP mail not existing or disabled. Removed the substitute mail function in inc/compatibility.php
* fixed some spacing errors in install.php
* Adds warning to error_log when call is made to unavailable PHP mail function and posts the warning to browser top if current user is admin.
* adds newline at end of compatibility.php and $lang global to Mailer.class.php
* Changes to handling of msg and `return false` as suggested by @phy25
* Removed tab from lilne 719
* removed additional tabs from Mailer.class.php
* Update inc/Mailer.class.php
removes unnecessary object
* Update inc/Mailer.class.php
changed msg styling for msg_managers_only warning for no PHP mail function
* Update inc/Mailer.class.php
* Update inc/Mailer.class.php
Nowadays it is not necessary to specify "type" or "charset" attribute at <script> tag:
1. "type" attribute defaults to "application/javascript", so there is no need to specify that. The recent value "text/javascript" is obsolete in favor of the default "application/javascript", as stated e.g. here: https://www.iana.org/assignments/media-types/media-types.xhtml#text
2. "charset" attribute of the <script> tag defaults to encoding be the same as the encoding of the script element's node document. As DokuWiki's default encoding is "utf-8", there is no need to specify this encoding in external resources. See: https://html.spec.whatwg.org/multipage/scripting.html#the-script-element
Manual merging, closes#2921.
Co-Authored-By: petrkajzar <58340153+petrkajzar@users.noreply.github.com>
Fixes#1892. This will be triggered by:
- PHP 7+: "If an appropriate source of randomness cannot be found, an Exception will be thrown"
- paragonie/random_compat: PHP 5.6 support will fail if urandom is not readable
users.auth.php is the only file in DokuWiki that is generated by using existing .dist file, instead of inline templates in install.php. This may cause problem when install.php is being run to create animal wiki in farm mode, because in this case DOKU_CONF may have no files at all, so install cannot populate users.auth.php properly. This closes#2845, which may be a result of this behavior - without proper comments at the beginning of the file, once the last authplain user is removed (if users has other auth backend as a proxy of authplain), the whole file will get removed, which causes fatal error.
* master: (22 commits)
Support "local" subdir when listing the smiley directory
fix zero ID/NS issue with page_findnearest
add ID/NS = '0' test against page_findnearest
fix zero value issue with metadata indexer
add key/value = '0' test to metadata indexer
fix zero ID issue with linkwiz and search indexer
fix zero ID issue with wl() and getID()
add $ID = '0' test against wl() and getID()
cookie.js when setValue‘s value parameter is false delete entry
install.php: respect useacl=0 choice, fixes#2576
cookie.js add def parameter to getValue()
cookie.js convert value type to string
set_doku_pref bugfix, closes#2721
more definition tests of doku_pref, for #1129
add tests for get/set_doku_pref #2721
fix Windows tests for #2702
use absolute URL in index.php when redirecting to doku.php, fixes#2706
Adding "recursive_groups" setting for authad-plugin in configuration-manager
Fix notices when using dw CLI
Fix issue #2396
...
I opted for ignoring the camel case funtion check not because the public hash_*
methods are widely used but because I find this style actually cleaner
in this case where the method name is auto-built from the hash type
name.
Background: I was trying to install DokuWiki in my chrooted OpenBSD webserver. The install seemed funky (generated config but not ACLs), and the installer page, instead of even showing any errors, was just blank after submitting initial parameters. Long story short, I edited install.php to approximately this effect, and finally got a visible error, which let me find out that I needed to create $CHROOT/dev/{a,u,s,}random. I would have found that out a lot sooner and torn out a lot less of my beautiful hair if something like this were already in place. After all, the installation phase is where one expects many edge cases and whatnot. Would help newcomers with strange environments to make more actionable forum posts crying for help. Please consider.
This check was useful in ages past, when there was no conf/local.php
However, nowadays it causes the installer to fail with the snapshot
version of DokuWiki and since we now have a dedicated local.php, it has
become obsolete.
When a server has no PHP support enabled, it will either prompt to
download a PHP file or may display it as HTML instead. When a user tries
to run install.php with a server that does the latter, they will see
some weird garbage with the browser trying to interpret raw PHP as HTML.
This pathc adds a warning at the top, telling the user what is going on.
Otherwise the it will fail with the following error:
2017/02/20 14:34:57 [error] 16242#0: *59 FastCGI sent in stderr: "PHP message: PHP Fatal error: Call to undefined function random_int() in /var/www/dokuwiki/inc/PassHash.class.php on line 630" while reading response header from upstream, client: 172.18.35.245, server: _, request: "POST /dokuwiki/install.php HTTP/1.1", upstream: "fastcgi://unix:/var/run/php-fpm/php-fpm.sock:", host: "10.5.234.170", referrer: "http://10.5.234.170/dokuwiki/install.php"
Fixes#1852
In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.
this adds the ability to place a install.conf file next to the
install.php which contains additional config options to be written to
conf/local.php on completion of the installer. The install.conf is
automatically deleted then.
This is useful for automated DokuWiki installers or downloaders that
take care of downloading DokuWiki and then drop the user in the default
install dialog for initial setup. These tools may set up host specific
things options like rewrites, image magic path or file permission
settings in this preset.
Andreas Gohr