feat: set useDefineForClassFields to true (#10119)

Fixes: #9773

cli/ast.rs

@@ -267,7 +267,7 @@ fn strip_config_from_emit_options(
         typescript::strip::ImportsNotUsedAsValues::Remove
       }
     },
-    ..Default::default()
+    use_define_for_class_fields: true,
   }
 }
 

cli/lsp/language_server.rs

@@ -372,6 +372,7 @@ impl Inner {
       "noEmit": true,
       "strict": true,
       "target": "esnext",
+      "useDefineForClassFields": true,
     }));
     let (maybe_config, maybe_root_uri) = {
       let config = &self.config;

cli/module_graph.rs

@@ -803,6 +803,7 @@ impl Graph {
       "strict": true,
       "target": "esnext",
       "tsBuildInfoFile": "deno:///.tsbuildinfo",
+      "useDefineForClassFields": true,
     }));
     if options.emit {
       config.merge(&json!({
@@ -948,6 +949,7 @@ impl Graph {
       "module": "esnext",
       "strict": true,
       "target": "esnext",
+      "useDefineForClassFields": true,
     }));
     let opts = match options.bundle_type {
       BundleType::Esm | BundleType::Iife => json!({

cli/tests/091_use_define_for_class_fields.ts

@@ -0,0 +1,4 @@
+class A {
+  b = this.a;
+  constructor(public a: unknown) {}
+}

cli/tests/091_use_define_for_class_fields.ts.out

@@ -0,0 +1,4 @@
+[WILDCARD]error: TS2729 [ERROR]: Property 'a' is used before its initialization.
+  b = this.a;
+           ^
+[WILDCARD]

cli/tests/bundle/fixture13.out

@@ -9,11 +9,9 @@ function d() {
     return Object.assign(promise, methods);
 }
 class A {
+    s = d();
     a() {
         this.s.resolve();
     }
-    constructor(){
-        this.s = d();
-    }
 }
 new A();

cli/tests/integration_tests.rs

@@ -2867,6 +2867,12 @@ console.log("finish");
     util::test_pty(args, output, input);
   }
 
+  itest!(_091_use_define_for_class_fields {
+    args: "run 091_use_define_for_class_fields.ts",
+    output: "091_use_define_for_class_fields.ts.out",
+    exit_code: 1,
+  });
+
   itest!(js_import_detect {
     args: "run --quiet --reload js_import_detect.ts",
     output: "js_import_detect.ts.out",

cli/tsc_config.rs

@@ -128,6 +128,7 @@ pub const IGNORED_RUNTIME_COMPILER_OPTIONS: &[&str] = &[
   "traceResolution",
   "tsBuildInfoFile",
   "typeRoots",
+  "useDefineForClassFields",
   "version",
   "watch",
 ];