From 52830414daa40b19ed8e06182bb2ea68cfd316af Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Fri, 3 May 2019 18:54:25 +0200 Subject: [PATCH] ci: make the sanitize build fast again (#2280) sccache doesn't work for cache debug builds at the moment, because it doesn't support the `-Xclang -fdebug-compilation-dir` flag that has been added by the most recent V8 upgrade. This patch should make the asan/lsan job on Travis CI fast again. --- .travis.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 7e1883a4b3..0109041d90 100644 --- a/.travis.yml +++ b/.travis.yml @@ -124,13 +124,18 @@ jobs: # tests. We want to detect leaks during the build process as well as # when executing the tests. So set the ASAN_OPTIONS env var before # build.py is run. - - name: "lsan debug linux" + - name: "asan/lsan linux" os: linux script: - ./tools/lint.py - ./tools/test_format.py - echo is_asan=true >> target/debug/args.gn - echo is_lsan=true >> target/debug/args.gn + # TODO(ry) sccache doesn't support "-Xclang -fdebug-compilation-dir" + # Which is enabled for ASAN builds if symbol_level != 0. + # https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?l=1087&rcl=573da77f569b41e23527f2952938f492678ab4bb + # Ideally we can remove this constraint in the future. + - echo symbol_level=0 >> target/debug/args.gn # Call gn gen again to make sure new args are recognized. - third_party/depot_tools/gn gen target/debug - export ASAN_OPTIONS=detect_leaks=1