test/static-code: change approach to running ruff

Instead of running ruff on *.py, with a large number of exemptions (all
of test/verify, test/common, tools/, etc) we now run it on all of the
Python files that test/static-code can find.

Previous commits have done some amount of code cleanups on the
newly-exposed code, but we deal with most remaining issues by using
per-directory ruff.toml files which let us adjust the configuration in a
subdirectory.  We make sure to add those to test/static-code so that
they will be available for partial linting during hooks.

containers/flatpak/test/ruff.toml

@@ -0,0 +1,5 @@
+extend = "../../../pyproject.toml"
+ignore = [
+    "PT009",    # Use a regular `assert` instead of unittest-style `assertEqual`
+    "FBT003"    # Boolean positional value in function call
+]

pkg/ruff.toml

@@ -0,0 +1,13 @@
+extend = "../pyproject.toml"
+ignore = [
+    "E501",     # https://github.com/charliermarsh/ruff/issues/3206#issuecomment-1562681390
+
+    "A001",     # Variable is shadowing a Python builtin
+    "A002",     # Argument is shadowing a Python builtin
+    "EXE001",   # Shebang is present but file is not executable
+    "F821",     # Undefined name
+    "FBT002",   # Boolean default value in function definition
+    "FBT003",   # Boolean positional value in function call
+    "I001",     # Import block is un-sorted or un-formatted
+    "RUF005",   # Consider `[..., *var, ...]` instead of concatenation
+]

pyproject.toml

@@ -50,10 +50,6 @@ exclude = [
     ".git/",
     "modules/",
     "node_modules/",
-    "pkg/",
-    "test/common/",
-    "test/verify/",
-    "tools/",
 ]
 ignore = [
     "A003",  # Class attribute is shadowing a python builtin

src/client/ruff.toml

@@ -0,0 +1,4 @@
+extend = "../../pyproject.toml"
+ignore = [
+    "FBT003",   # Boolean positional value in function call
+]

test/common/ruff.toml

@@ -0,0 +1,39 @@
+extend = "../../pyproject.toml"
+ignore = [
+    "E501",     # https://github.com/charliermarsh/ruff/issues/3206#issuecomment-1562681390
+
+    "A001",     # Variable is shadowing a Python builtin
+    "A002",     # Argument is shadowing a Python builtin
+    "B006",     # Do not use mutable data structures for argument defaults
+    "B007",     # Loop control variable` not used within loop body
+    "B010",     # Do not call `setattr` with a constant attribute value. It is not any safer than normal property access.
+    "C417",     # Unnecessary `map` usage (rewrite using a `list` comprehension)
+    "FBT001",   # Boolean positional arg in function definition
+    "FBT002",   # Boolean default value in function definition
+    "FBT003",   # Boolean positional value in function call
+    "PT009",    # Use a regular `assert` instead of unittest-style `assertEqual`
+]
+
+[isort]
+section-order = [
+    "future", "standard-library", "third-party",
+    "test-common", "bots",
+    "first-party", "local-folder"
+]
+force-to-top = ["parent"]
+
+[isort.sections]
+"bots" = [
+    "lib",
+    "machine_core",
+    "task",
+    "testvm",
+]
+"test-common" = [
+    "cdp",
+    "parent",
+    "netlib",
+    "packagelib",
+    "storagelib",
+    "testlib",
+]

test/static-code

@@ -4,6 +4,12 @@
 set -eu
 
 # requires: pyproject.toml
+# requires: containers/flatpak/test/ruff.toml
+# requires: pkg/ruff.toml
+# requires: src/client/ruff.toml
+# requires: test/common/ruff.toml
+# requires: test/verify/ruff.toml
+# requires: tools/vulture-suppressions/ruff.toml
 
 # we consider any function named test_* to be a test case
 # each test is considered to succeed if it exits with no output
@@ -33,8 +39,7 @@ test_flake8() {
 
 test_ruff() {
     command -v ruff >/dev/null || skip 'no ruff'
-    test -n "$(ruff check --show-files . 2>/dev/null)" || return 0  # no python changes
-    ruff check --no-cache .
+    find_python_files | xargs -r -0 ruff check --no-cache
 }
 
 if [ "${WITH_PARTIAL_TREE:-0}" = 0 ]; then

test/verify/ruff.toml

@@ -0,0 +1,9 @@
+extend = "../common/ruff.toml"
+ignore = [
+    "PT",       # This is not pytest code
+
+    "B023",     # Function definition does not bind loop variable
+    "B905",     # `zip()` without an explicit `strict=` parameter
+    "DTZ005",   # The use of `datetime.datetime.now()` without `tz` argument is not allowed
+    "RUF005",   # Consider `[..., *var, ...]` instead of concatenation
+]

tools/vulture-suppressions/ruff.toml

@@ -0,0 +1,4 @@
+extend = "../../pyproject.toml"
+ignore = [
+    "B018"  # Found useless expression. Either assign it to a variable or remove it.
+]