opensourcemirror
/
RawTherapee
mirror of https://github.com/Beep6581/RawTherapee.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix Clang-10 warnings

This commit is contained in:
Flössie 2020-04-02 13:23:57 +02:00
parent 29596bb457
commit 8886402e93
5 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rtengine/iccstore.cc
View File

@ -635,7 +635,7 @@ public:
MyMutex::MyLock lock(mutex);
for (const auto profile : fileProfiles) {
for (const auto& profile : fileProfiles) {
if (
(
type == ICCStore::ProfileType::MONITOR

16
rtengine/ipwavelet.cc
View File

@ -1845,8 +1845,8 @@ void ImProcFunctions::WaveletcontAllL(LabImage * labco, float ** varhue, float *
WavCoeffs_L0[i] = aft[i];
}
delete bef;
delete aft;
delete[] bef;
delete[] aft;
}
//
#ifdef _OPENMP
@ -2070,8 +2070,8 @@ void ImProcFunctions::WaveletcontAllL(LabImage * labco, float ** varhue, float *
WavCoeffs_L[dir][co] = aft[co];
}
delete bef;
delete aft;
delete[] bef;
delete[] aft;
}
}
}
@ -2288,8 +2288,8 @@ void ImProcFunctions::WaveletcontAllAB(LabImage * labco, float ** varhue, float
WavCoeffs_ab0[i] = aft[i];
}
delete bef;
delete aft;
delete[] bef;
delete[] aft;
}
@ -2371,8 +2371,8 @@ void ImProcFunctions::WaveletcontAllAB(LabImage * labco, float ** varhue, float
WavCoeffs_ab[dir][co] = aft[co];
}
delete bef;
delete aft;
delete[] bef;
delete[] aft;
}

2
rtgui/editorpanel.cc
View File

@ -172,7 +172,7 @@ private:
const std::vector<Glib::ustring> profiles = rtengine::ICCStore::getInstance()->getProfiles (rtengine::ICCStore::ProfileType::MONITOR);
for (const auto profile : profiles) {
for (const auto& profile : profiles) {
profileBox.append (profile);
}

4
rtgui/preferences.cc
View File

@ -778,7 +778,7 @@ Gtk::Widget* Preferences::getColorManPanel ()
const std::vector<Glib::ustring> profiles = rtengine::ICCStore::getInstance ()->getProfiles (rtengine::ICCStore::ProfileType::MONITOR);
for (const auto profile : profiles) {
for (const auto& profile : profiles) {
if (profile.find("file:") != 0) {
std::string fileis_RTv4 = profile.substr(0, 4);
@ -847,7 +847,7 @@ Gtk::Widget* Preferences::getColorManPanel ()
const std::vector<Glib::ustring> prtprofiles = rtengine::ICCStore::getInstance ()->getProfiles (rtengine::ICCStore::ProfileType::PRINTER);
for (const auto prtprofile : prtprofiles) {
for (const auto& prtprofile : prtprofiles) {
prtProfile->append (prtprofile);
}

4
rtgui/profilestorecombobox.cc
View File

@ -182,7 +182,7 @@ Gtk::TreeIter ProfileStoreComboBox::findRowFromEntry (const ProfileStoreEntry *p
Gtk::TreeIter ProfileStoreComboBox::findRowFromFullPath_ (Gtk::TreeModel::Children childs, int parentFolderId, const Glib::ustring &name) const
{
for (const auto iter : childs) {
for (const auto& iter : childs) {
const Gtk::TreeModel::Row row = *iter;
// Hombre: is there a smarter way of knowing if this row has childs?
const ProfileStoreEntry *pse = row[methodColumns.profileStoreEntry];
@ -309,7 +309,7 @@ Gtk::TreeIter ProfileStoreComboBox::getRowFromLabel (const Glib::ustring &name)
const Gtk::TreeModel::Children childs = refTreeModel->children();
if (!name.empty()) {
for (const auto iter : childs) {
for (const auto& iter : childs) {
const Gtk::TreeModel::Row currRow = *iter;
const ProfileStoreEntry *pse = currRow[methodColumns.profileStoreEntry];